Received: by 2002:a25:2c96:0:0:0:0:0 with SMTP id s144csp954941ybs; Mon, 25 May 2020 03:36:10 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwrLenbZb7cn70fhLqtg8kPfhbSrBCGgSAznMIth949pP//u8AtrvH8UkmwRyKUZd3MBKQb X-Received: by 2002:a17:906:2455:: with SMTP id a21mr17563235ejb.73.1590402969982; Mon, 25 May 2020 03:36:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1590402969; cv=none; d=google.com; s=arc-20160816; b=cmu/JmaqtD6J5S4Mg/y1uuahr/1VhBOHOskpBKUfnPrWf6bSb0OSW9w2YTEfZvMGg0 qe6gH8Oj89Qh2gkUSN/2jSTxyzv6ChnaE/mJAfk8LENqg5ZRVYIpsx593Di8Q9aK2hxY mE6Rzic0p7zvXKpSSDr9ea0DeMIwklDfPAZHkYg2Tdl5sIdnpQxNMfBxLxE6Ia1fMA1l HNV22v9RO/+rk3hKIQ2mhHQDHBPkOx0x+o4Vi6BHx8qEC5VUNCeZ5l+N1JF4YF4wI+m1 cT910idl26LvqaU4wUvH3dia/e8ZNKsb6iOl8PmBSPThcWyWkbXFfRCAi7pt+iVu5oPH Y+5g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-language :content-transfer-encoding:in-reply-to:mime-version:user-agent:date :message-id:references:cc:to:subject:from:dkim-signature; bh=bcIsWmmEkRWoaOrX+BaWGDzqoQqiuKveo/AD/DMmyLs=; b=clrAITjzTXw54ZWtMlRahL148kGeKeQbITgo7jdF67GIPrCGlKELUt6cXYZtg047kJ jM95UDU2j4ol7cqWvfdEja1ugQVA4s07q4n+Ude41AMLewTmG7EAnwZI5IC08boVGrbV Vdms3u5gcYqaqD04+eSjMXBYQLM04aG1bbI0RS9X3KJ6m4hTh8oQJGs3p031dCeKNPR5 aPLPIn2B2/F6HeLxt5fs04CodKlpFw0DIdSNG1UduMUh5jbWbSbagDNPFgogJhMkz90x SLVapXOpQN8okZjPsoSLhATGYdtr17bCI6pBBnR9FAfTSD5gCbGC+9Jw3NcbtWa/B887 TVKQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@footclan-ninja.20150623.gappssmtp.com header.s=20150623 header.b=0CisCT68; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id d31si9401714edc.462.2020.05.25.03.35.46; Mon, 25 May 2020 03:36:09 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@footclan-ninja.20150623.gappssmtp.com header.s=20150623 header.b=0CisCT68; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389770AbgEYKdh (ORCPT + 99 others); Mon, 25 May 2020 06:33:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37440 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389373AbgEYKdh (ORCPT ); Mon, 25 May 2020 06:33:37 -0400 Received: from mail-pl1-x641.google.com (mail-pl1-x641.google.com [IPv6:2607:f8b0:4864:20::641]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D6E6DC05BD43 for ; Mon, 25 May 2020 03:33:36 -0700 (PDT) Received: by mail-pl1-x641.google.com with SMTP id bh7so443056plb.11 for ; Mon, 25 May 2020 03:33:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=footclan-ninja.20150623.gappssmtp.com; s=20150623; h=from:subject:to:cc:references:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=bcIsWmmEkRWoaOrX+BaWGDzqoQqiuKveo/AD/DMmyLs=; b=0CisCT68V7ucr2HapFKzya24WVrp+iCTX2mnNGSV7JVfHbSNPfE5UgX9XFcvhC3YeK lzwT19u8/X2J7Gl6lbQIw4N65c+l+3gD8aSY4/RsPeIHlYAYJvZPHPdbWIZXcg49iTbQ vzKwFSPxNE/Q120KjNrTQM3hd5nP+W+BybSFXzZ2+fQsVeQoqcdHlI3H+dowRiFZKoIO 2XCCOkB0IzkW4usH0DBj1vaiyYC66MWzYshUmvTm2eZtrJrIWFp151EeWd/HTg//tZy0 II4FZXgKMQyMxa18Snt+SqCb/qf9TRJJlL6MIFurKt6cp7S7vWzi7it+ZgxYg+wfcBWv fekA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:subject:to:cc:references:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=bcIsWmmEkRWoaOrX+BaWGDzqoQqiuKveo/AD/DMmyLs=; b=gJxHHw/BlVOUTJmazupAfwk5DUhxbrRPtTz0WEHBzCnwgpjXZBec/x08Sk1ajs+dUA /6F6nGdxARjoD6+mEmrtYoCHGbndh/F5MlSXcXBj7f+WH4Z6LXNx0gSJkCxNcO6MK5TC IflNzqdruECOZJuUDF9YIAc120zVKYT7COe6Qg8xZ2A3Qe5NK2GtPBK8iZ8KU1C+xq6y tqSlXMmn2j+gByNo0+rc9M2kevwuzGml68Ujryxt1qEnztEK2FjNFqqhAL+uWaMmoZMG U5+ulD2emMq1PEQLd0N7dBTo7Z+GJ/VTyYA00axjCjAqiNufcZA2xn844JB81ycpu/Sc BFVw== X-Gm-Message-State: AOAM532ZZk4/MVfX+BFRp5lOgLnfALZ2rtYwEter9woR4uErTIo+vvD1 cG/M8TTDdMSPljk9vm8As0n0HrjmsUWZCZ5oOD0sr4iNSbsdHQcZSZVdiOnwet3nfxZqEGFJToj S4kizMNq4P2Bg+dxtO7dhoSqByB2WP/iKysS8OZh15CSBCjfMDUrIu8JN4r+ZRryI4+bDu91KIi u3rlb9 X-Received: by 2002:a17:90a:c78f:: with SMTP id gn15mr19715320pjb.103.1590402816108; Mon, 25 May 2020 03:33:36 -0700 (PDT) Received: from [192.168.8.100] (pa49-195-155-227.pa.nsw.optusnet.com.au. [49.195.155.227]) by smtp.gmail.com with ESMTPSA id x2sm12521503pfc.106.2020.05.25.03.33.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 25 May 2020 03:33:35 -0700 (PDT) From: Matt Jolly X-Google-Original-From: Matt Jolly Subject: Re: [PATCH v2] USB: serial: qcserial: Add DW5816e QDL support To: Johan Hovold Cc: Greg Kroah-Hartman , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org References: <20200521004358.8949-1-Kangie@footclan.ninja> <20200525093951.GC5276@localhost> Message-ID: Date: Mon, 25 May 2020 20:33:31 +1000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: <20200525093951.GC5276@localhost> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > On 25/5/20 7:39 pm, Johan Hovold wrote: >> Hmm. I'd a call a build breakage a bit more than just a "typo" as it >> indicates this patch was never tested at all before being submitted. I applied, built, and tested it against the sources for the kernel I run on my machine, but made several silly mistakes: both manually applying the patch to my copy of the repo (which is not my running kernel), and not build testing that change before submission. Not good indeed. I could definitely have been more descriptive in the change notes. Consider me appropriately chastised!