Received: by 2002:a25:2c96:0:0:0:0:0 with SMTP id s144csp997773ybs; Mon, 25 May 2020 04:47:57 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyBZsVLR36ivPWA8cJ/XxL5f3B4ZLbF1qDgwPfoFLWLHR7glRkmsecoK+GIKNBmO9Q9wMFK X-Received: by 2002:a17:906:c82b:: with SMTP id dd11mr19075580ejb.380.1590407277077; Mon, 25 May 2020 04:47:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1590407277; cv=none; d=google.com; s=arc-20160816; b=Td1TQ7Cy0dDPLOPHecnuHMINXIMTcYDzsYDr3ZMs1bHMyGKu3NUjvKCVJbUJRNhAIJ Bk9Oo8PNjJW1Vc5i+Adlgzskun8VWgNe9Ojk9fTLBANWtR75ZP3QZNdZCVwRJUn2kIyF kzwP43k14Lo1sl8GU/crbAGy2MDuKRJbsFJTGFLwktXeYe32NwJKYU7HoyMRknJMAFU/ JWzhXQwxWz38mt2O2rRcJJGDaIKJo37QUijjBOuUAMwkB5jXVXUu6DgYmEW+cJ1MRSxs hFDSeYoIGefNxLbIZOKG0J5pRImhfeuXbp/u/h7t7DHVYXkJDImDfz2u7yuVNlSCs2Ka s+Jg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=m0bTqGH0d3JeEaC20G6hb99dE+zC2wBcu3IzF6mWVOI=; b=lb0cUaORDUZtzozHov3u+efsXYPHK75lp35atdM4aHawXClUDUGoO9/4UPomJO5lj/ D5ANVIllXaVKSV8EkxcbamPa+R8czzynOazFMhE93DtvBHNxhi1C9cZu3Q3q7HX/MX14 UKsXiI7gys+ftbrzNK5vDI3KvMfKTGeo61zHsqWCub/GEOB4YtHdQ4cDqu4fL+vAKMlJ DxJUynFzFlomPhLH6yQaHL7xsmNrYNk4GyTjYJ5BX2Glp8LDH3B5NiX4Mca3iuzN/XZj U4djxQyZQBVBWnLLRRSELfDoE7lewoq7b3LhY7YzSXf+YNkh+4eIfdFT3L9zKelJM7SL VZUQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=KM80Gu8H; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id s19si5523913ejz.75.2020.05.25.04.47.33; Mon, 25 May 2020 04:47:57 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=KM80Gu8H; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390278AbgEYLnj (ORCPT + 99 others); Mon, 25 May 2020 07:43:39 -0400 Received: from mail.kernel.org ([198.145.29.99]:60622 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2390189AbgEYLnj (ORCPT ); Mon, 25 May 2020 07:43:39 -0400 Received: from localhost (fw-tnat.cambridge.arm.com [217.140.96.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 36CE020723; Mon, 25 May 2020 11:43:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1590407018; bh=ohGuMmEbw6jcckmjGuy7SWze+kKppKGgRxKK0h8JEr0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=KM80Gu8HAcmZ1l6c68I4DnrdiD57M88zpiXWycjvRd03XGvrbG2HqVCawIo5VHm3F HJEWyIi+trARwAOz28eZPsmxmVUJW4EKfcNfq4Cq0gz0TOCHmckoj6KzZVgbzVQc1z SfCVNxC1mpxzGiTSEs5yrLbejv0JMu2jkSzODsaQ= Date: Mon, 25 May 2020 12:43:36 +0100 From: Mark Brown To: dillon min Cc: Rob Herring , p.zabel@pengutronix.de, Maxime Coquelin , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Alexandre Torgue , thierry.reding@gmail.com, Sam Ravnborg , Dave Airlie , Daniel Vetter , Michael Turquette , Stephen Boyd , Linux ARM , linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, "open list:DRM PANEL DRIVERS" , linux-clk Subject: Re: [PATCH v4 3/8] spi: stm32: Add 'SPI_SIMPLEX_RX', 'SPI_3WIRE_RX' support for stm32f4 Message-ID: <20200525114336.GD4544@sirena.org.uk> References: <1589800165-3271-1-git-send-email-dillon.minfei@gmail.com> <1589800165-3271-4-git-send-email-dillon.minfei@gmail.com> <20200522113634.GE5801@sirena.org.uk> <20200522162901.GP5801@sirena.org.uk> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="fXStkuK2IQBfcDe+" Content-Disposition: inline In-Reply-To: X-Cookie: Help a swallow land at Capistrano. User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --fXStkuK2IQBfcDe+ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Sat, May 23, 2020 at 09:35:06AM +0800, dillon min wrote: > - if (ctlr->flags & (SPI_CONTROLLER_MUST_RX | SPI_CONTROLLER_MUST_TX)) { > + if ((ctlr->flags & (SPI_CONTROLLER_MUST_RX | SPI_CONTROLLER_MUST_TX)) && > + !(msg->spi->mode & SPI_3WIRE)) { > max_tx = 0; > max_rx = 0; > for my board, lcd panel ilitek ill9341 use 3wire mode, gyro l3gd20 use > simplex rx mode. > it's has benefits to l3gd20, no impact to ili9341. > if it's fine to spi-core, i will include it to my next submits. Yes, looks reasonable. --fXStkuK2IQBfcDe+ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl7Lr2cACgkQJNaLcl1U h9Czfgf5AZokYX+RDns/ATZTiNwwtWO8zgdUKtvU2B95mvVnSoH/+u22jEMjyBEV VTql9iv86CkoWuw8ClYb6Ii3VcZhJlMJjs6f6TPlihKzhOKSAvVrUwf0GXQlWaS5 +uyF6imcop10LBRU7tKfWP+LpK90XFTt8wGtpnHqquhnlvs4zDEFu/Yvp91raDXu FfWKf+2Aqu7xuWMGdHJjF/SiRINbFZVw70Rv9GM06ywcTkThXhrKpn5z4fCdWlEQ iDy1RvrcqNwjm9MtAgYmwoOF/NVEcZaygAE11tHi6JOjrXYW+29jJRQDn4N06CZZ tIaKNPu+scagmjfGwKU2PSW4mVUAuA== =Yagp -----END PGP SIGNATURE----- --fXStkuK2IQBfcDe+--