Received: by 2002:a25:2c96:0:0:0:0:0 with SMTP id s144csp1106604ybs; Mon, 25 May 2020 07:20:43 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzHBxLoqtwfkUbLTm285FB2BpwjBUv+VaUDBYKtv7zzadukywYLa/q34c+8c+WYHcRMn5XG X-Received: by 2002:a17:906:80da:: with SMTP id a26mr18497365ejx.475.1590416443293; Mon, 25 May 2020 07:20:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1590416443; cv=none; d=google.com; s=arc-20160816; b=e7HSTZf92ROsb1eRycvPL1d63O8Z78icHmxnbUynUpBb9x4liVjjWNab3vuuoY/FqR OQti1b8EU0xc7r48YQqWw+9OuOmM4Tf2oe38eS9rvbmv02aTkETFGJffgFoht/w2N4W2 mXFWJRYf9AwBUnDq+nIj771fvAkNueo3r1Kfpp9XhPJbSnbnryPuMDKDjG8yB4O2nDk5 U1hZ/MULo7oTHSVdJE6rCxmQrUW0QXbPZKfixwAUZ8wRZ9O39hAACoxJyAaGrOC9MyVu LvRStHrI/9L7CDGOA1RwuvM/XszvAFhPurBSbuaIQYghhoPk/9TGDNj6xL2ADwbjknua BfHw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=Kr9buj3Bzk9juOwV9KAH42CouIIua7TPJ6CsB4FDIvo=; b=uuU4PaYw5i+jiI/UOjiP1He9MHAeRi0f1YKUV83osBCh6yu5HFESOI8tofBn9KrEjR izky+oI4Nx1Am9bz3iqA9K5V+rqA+7ylYQwMWnlh6XQrH/KSjq3G+WFR10HmKMQLNZbo qWuP/UIa0tTuJP+ZufiGrhoN706TK5veEGg8IEMJNzXaHdSxJenoViQ23VSB4QgYcBwj F/YMogYD/Uq+sRfDKD76JNRYn0B/T5kyh0X0rLXjqsJ2pAzHZ4PafkwSQapiN6Tgp0g9 jGewTkfS1O4dkIpp1U9mgXQmlIHh8mFOObn2eEwd78UQoNzAzcScHR5uSzkXE5LUId2R mndA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=merlin.20170209 header.b=1LaOXVpx; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id y13si9879707edm.63.2020.05.25.07.20.19; Mon, 25 May 2020 07:20:43 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=merlin.20170209 header.b=1LaOXVpx; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390938AbgEYORm (ORCPT + 99 others); Mon, 25 May 2020 10:17:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44530 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2390872AbgEYORm (ORCPT ); Mon, 25 May 2020 10:17:42 -0400 Received: from merlin.infradead.org (unknown [IPv6:2001:8b0:10b:1231::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EFEBEC061A0E for ; Mon, 25 May 2020 07:17:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=merlin.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=Kr9buj3Bzk9juOwV9KAH42CouIIua7TPJ6CsB4FDIvo=; b=1LaOXVpxbh4kKq0WRwK771k5k+ IFL66RFj2QvC04aQnG2UgDS6g2q4/9jSBXN9vYRSH9Lvv+WIGEtu9XIF6sbUnlGLoB+1Ex4Btc1ha KDeEetD7C/tNJJWw/yY6CfkHu22dmwWwUG12Sf4sl3e372SyF7Z9Xq9PZW596ONN1EBZPgBF8nyOF jPdH7j7JcyxfjEiqCllRK4JPte946n6+tBD6nRh1X35GPD8vEEe7iRMFByyGqEB+3CoTYVgHt1JE7 TvUZSQTwMVSg8EVEt9ffMKMFrwRL3vnU04Tr2Tylxs4S7KaTSGkFbGcQSdmAUXaHtWEI5XGpQF+tv 3GDKOqzg==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=noisy.programming.kicks-ass.net) by merlin.infradead.org with esmtpsa (Exim 4.92.3 #3 (Red Hat Linux)) id 1jdDuk-0000Ae-0B; Mon, 25 May 2020 14:17:14 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id 94E6B300478; Mon, 25 May 2020 16:17:11 +0200 (CEST) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id 800832389FE09; Mon, 25 May 2020 16:17:11 +0200 (CEST) Date: Mon, 25 May 2020 16:17:11 +0200 From: Peter Zijlstra To: Frederic Weisbecker Cc: Qian Cai , "Paul E. McKenney" , Linux Kernel Mailing List , Thomas Gleixner , Michael Ellerman , linuxppc-dev , Borislav Petkov Subject: Re: Endless soft-lockups for compiling workload since next-20200519 Message-ID: <20200525141711.GI325303@hirez.programming.kicks-ass.net> References: <20200520125056.GC325280@hirez.programming.kicks-ass.net> <20200521004035.GA15455@lenoir> <20200521093938.GG325280@hirez.programming.kicks-ass.net> <20200521104937.GB325303@hirez.programming.kicks-ass.net> <20200521110027.GC325303@hirez.programming.kicks-ass.net> <20200521124113.GC15455@lenoir> <20200525132105.GW325280@hirez.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200525132105.GW325280@hirez.programming.kicks-ass.net> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, May 25, 2020 at 03:21:05PM +0200, Peter Zijlstra wrote: > - flags = atomic_fetch_andnot(NOHZ_KICK_MASK, nohz_flags(this_cpu)); > - if (!(flags & NOHZ_KICK_MASK)) > + if (idle != CPU_IDLE) > return false; > > _nohz_idle_balance(this_rq, flags, idle); Bah, I think I broke something there. Lemme go mend.