Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 25 May 2020 17:12:37 +0200
From:   Daniel Vetter <daniel@ffwll.ch>
To:     James Hilliard <james.hilliard1@gmail.com>
Cc:     dri-devel@lists.freedesktop.org, Eric Anholt <eric@anholt.net>,
        David Airlie <airlied@linux.ie>,
        Daniel Vetter <daniel@ffwll.ch>, linux-kernel@vger.kernel.org
Subject: Re: [RESEND PATCH] drm/vc4: hdmi: Silence pixel clock error on
 -EPROBE_DEFER
Message-ID: <20200525151237.GJ206103@phenom.ffwll.local>
Mail-Followup-To: James Hilliard <james.hilliard1@gmail.com>,
        dri-devel@lists.freedesktop.org, Eric Anholt <eric@anholt.net>,
        David Airlie <airlied@linux.ie>, linux-kernel@vger.kernel.org
References: <20200525012859.267433-1-james.hilliard1@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200525012859.267433-1-james.hilliard1@gmail.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Sun, May 24, 2020 at 07:28:59PM -0600, James Hilliard wrote:
> If the vc4 hdmi driver loads before the pixel clock is available we
> see a spurious "*ERROR* Failed to get pixel clock" error.
> 
> Signed-off-by: James Hilliard <james.hilliard1@gmail.com>
> ---
> no response in over 2 weeks

Thanks for poking again, not sure who exactly is supporting drm/vc4
nowadays. Eric at least doesn't work at broadcom anymore.

I queued up the patch in drm-misc-next.
-Daniel

> ---
>  drivers/gpu/drm/vc4/vc4_hdmi.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/vc4/vc4_hdmi.c b/drivers/gpu/drm/vc4/vc4_hdmi.c
> index 340719238753..6d4ee3f6b445 100644
> --- a/drivers/gpu/drm/vc4/vc4_hdmi.c
> +++ b/drivers/gpu/drm/vc4/vc4_hdmi.c
> @@ -1338,8 +1338,10 @@ static int vc4_hdmi_bind(struct device *dev, struct device *master, void *data)
>  
>  	hdmi->pixel_clock = devm_clk_get(dev, "pixel");
>  	if (IS_ERR(hdmi->pixel_clock)) {
> -		DRM_ERROR("Failed to get pixel clock\n");
> -		return PTR_ERR(hdmi->pixel_clock);
> +		ret = PTR_ERR(hdmi->pixel_clock);
> +		if (ret != -EPROBE_DEFER)
> +			DRM_ERROR("Failed to get pixel clock\n");
> +		return ret;
>  	}
>  	hdmi->hsm_clock = devm_clk_get(dev, "hdmi");
>  	if (IS_ERR(hdmi->hsm_clock)) {
> -- 
> 2.25.1
> 

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch