Received: by 2002:a25:2c96:0:0:0:0:0 with SMTP id s144csp1184613ybs; Mon, 25 May 2020 09:09:43 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzwdVggUJ7KYSmoMezFpxF0clvf1L7ke7ybJ43bVNIZXOG2c2PIFhP/nradR4SpFdDKMTYl X-Received: by 2002:a05:6402:959:: with SMTP id h25mr15555453edz.287.1590422983160; Mon, 25 May 2020 09:09:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1590422983; cv=none; d=google.com; s=arc-20160816; b=FhEsT/2gLV26qfiV3QvgQy23L+zDA2JQKQ+6Yjw6IqlBnpv3Bea6XXpDNMpT2fMiz7 oYsSb3K5/12BkIiE/eJAeKq/UK3SCVerpVfsLOtX4/lqmKPSvuIjkhtqFT3AYpywCIg1 F+yMcTD+lbPXfWb0TjyVxOowppIpqZm9NKiQDVFPm5H6R14Zl+zTFR+aUaCgBhejdybr sequsLIpCDrTJuJS03c3s4mTfmSlGjOx0rjDDk8zjrghyO4IM/1JfuIrTuSXu+tpJ6fA +cS57pcZHZhm3nzvmwLAk4rn19Exrog+h6aa+EoFIm3fPO56u93p1oLRi/PJC1sUTjlR Giug== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from; bh=Y0Htu0OoMYdDEw17BBfn2uLarWr/tYHK4SNoUkwYROA=; b=kLTh3uaqAUHqHk93vqDX/Pk8lIIEk1oNZyorC+Hlr0RQrkusXhQjgVevgO5SD5osLu CGLdTj9MA4y+LXoJZVX+97tfd1sLCMY1LVXVEZecpsC50qwoPRmTEeDHqsgJLU2E3Esw APf+BlHelT1bX0YEQ2oyJM90kGnJbqHLSx9edBXTAPsTjX29sZ5rQ32On2DwIvCFaKna zyuhFYq0jReosF4KLshniyITjKGH7uWvqGBEf5DPYbKLBgTQ8y0s9rUglOuzQFzeWwPw ZREzFvHBIt1RLM3VJrMz2gWTA467xk8uLwc/nH/VNrG3OCezyNRRN9YTlCFD+3kSZkHI 7MqA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id r26si10065625edi.376.2020.05.25.09.09.20; Mon, 25 May 2020 09:09:43 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389005AbgEYHLy (ORCPT + 99 others); Mon, 25 May 2020 03:11:54 -0400 Received: from mail.loongson.cn ([114.242.206.163]:53602 "EHLO loongson.cn" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S2388948AbgEYHLy (ORCPT ); Mon, 25 May 2020 03:11:54 -0400 Received: from linux.localdomain (unknown [113.200.148.30]) by mail.loongson.cn (Coremail) with SMTP id AQAAf9Dxr2uyb8teEdE4AA--.1329S2; Mon, 25 May 2020 15:11:46 +0800 (CST) From: Tiezhu Yang To: Bartlomiej Zolnierkiewicz Cc: dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org, Xuefeng Li , Tiezhu Yang Subject: [PATCH] video: fbdev: pxafb: Use correct return value for pxafb_probe() Date: Mon, 25 May 2020 15:11:45 +0800 Message-Id: <1590390705-22898-1-git-send-email-yangtiezhu@loongson.cn> X-Mailer: git-send-email 2.1.0 X-CM-TRANSID: AQAAf9Dxr2uyb8teEdE4AA--.1329S2 X-Coremail-Antispam: 1UD129KBjvdXoWruw18Zw1xXFykWFyrtFyxZrb_yoW3AFb_Cw 48ur93XryUtr1vg3Wqya15Ary2yF97Wr4fXanrK3yYy347uryfuryUZr1v9FW8Xw4jyFn8 ZF4qgr1avr4fCjkaLaAFLSUrUUUUjb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUIcSsGvfJTRUUUbckFF20E14v26r1j6r4UM7CY07I20VC2zVCF04k26cxKx2IYs7xG 6rWj6s0DM7CIcVAFz4kK6r1j6r18M28lY4IEw2IIxxk0rwA2F7IY1VAKz4vEj48ve4kI8w A2z4x0Y4vE2Ix0cI8IcVAFwI0_Xr0_Ar1l84ACjcxK6xIIjxv20xvEc7CjxVAFwI0_Cr0_ Gr1UM28EF7xvwVC2z280aVAFwI0_Gr1j6F4UJwA2z4x0Y4vEx4A2jsIEc7CjxVAFwI0_Gc CE3s1le2I262IYc4CY6c8Ij28IcVAaY2xG8wAqx4xG64xvF2IEw4CE5I8CrVC2j2WlYx0E 2Ix0cI8IcVAFwI0_Jrv_JF1lYx0Ex4A2jsIE14v26r4j6F4UMcvjeVCFs4IE7xkEbVWUJV W8JwACjcxG0xvY0x0EwIxGrwACjI8F5VA0II8E6IAqYI8I648v4I1lc2xSY4AK67AK6r4x MxAIw28IcxkI7VAKI48JMxC20s026xCaFVCjc4AY6r1j6r4UMI8I3I0E5I8CrVAFwI0_Jr 0_Jr4lx2IqxVCjr7xvwVAFwI0_JrI_JrWlx4CE17CEb7AF67AKxVWUAVWUtwCIc40Y0x0E wIxGrwCI42IY6xIIjxv20xvE14v26r1j6r1xMIIF0xvE2Ix0cI8IcVCY1x0267AKxVWUJV W8JwCI42IY6xAIw20EY4v20xvaj40_Zr0_Wr1UMIIF0xvEx4A2jsIE14v26r4j6F4UMIIF 0xvEx4A2jsIEc7CjxVAFwI0_Gr0_Gr1UYxBIdaVFxhVjvjDU0xZFpf9x0JUIApnUUUUU= X-CM-SenderInfo: p1dqw3xlh2x3gn0dqz5rrqw2lrqou0/ Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org When call function devm_platform_ioremap_resource(), we should use IS_ERR() to check the return value and return PTR_ERR() if failed. Signed-off-by: Tiezhu Yang --- drivers/video/fbdev/pxafb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/video/fbdev/pxafb.c b/drivers/video/fbdev/pxafb.c index 00b96a7..423331c 100644 --- a/drivers/video/fbdev/pxafb.c +++ b/drivers/video/fbdev/pxafb.c @@ -2305,7 +2305,7 @@ static int pxafb_probe(struct platform_device *dev) fbi->mmio_base = devm_platform_ioremap_resource(dev, 0); if (IS_ERR(fbi->mmio_base)) { dev_err(&dev->dev, "failed to get I/O memory\n"); - ret = -EBUSY; + ret = PTR_ERR(fbi->mmio_base); goto failed; } -- 2.1.0