Received: by 2002:a25:2c96:0:0:0:0:0 with SMTP id s144csp1314789ybs; Mon, 25 May 2020 12:41:06 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxeh9O/Hd+QXt4TNRpoWwu8HaYJv2LBLLvpYD7h8pLBzr5brCUh2fDnS/Ttscth3kNO99vb X-Received: by 2002:a05:6402:1c0e:: with SMTP id ck14mr17326713edb.356.1590435666628; Mon, 25 May 2020 12:41:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1590435666; cv=none; d=google.com; s=arc-20160816; b=jy31vqRS5szt7047H01HKJnJ8GmxElRAS+4RgBDU4kjUs36z4Gv7HbGAIMg1b0OSH9 W2CRdAuAO56eTx+Sw6gDaoruH8vB4WUZ6uy6y1YGmwjTWNMrdjfCpinI0oHnSO9sv3Jx tNHtPthfbCPTgATd5IM/o1Hc7GqLTEvWQBOGeNUsBfnkN/3oE+WOIuuLZLWHzzsASJtw pcj3o+ozvyCRvP32WcP4N43+SDQHjeT3TBY81QJO+8TLju6RmX9NSumJwb3yf/5kRQQz uSANZvtwyL2c8r04a6VWYvNwqLzOdSVbJaqsRgHZ3PWdrEL8yI94umwR+3FXOOtZ8hlt sx0A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=DZr4IPFA4Vnbkt6An22aT54SGu2lLj63yMeWXMh2dCU=; b=rOUuvxSckaoZW2K+GsfrVsc4UlgvbrHEBxyqshHDVxUdt5iX+5PyPsH/O0nCQcWcr6 UnJSdJG/lUVbaB9eIDBzY1poyuqocdHzgcy0l4HKSZpvBompfLr2XqeIT+J5smLpVbrJ O60B3o9pTR9s42ToOwdwLk5LULodoO8xiaqTQLydm15g+LNSytgSQM3CSXgc5ll1KwtZ 5rkzT68ExXeCWbq5B407DyZU3gLdHslUnkew7R3VJjDhcqfBDxZqeD33YBwZraF11HbL M4MqawqX9U6DJxmNDulaga0Wsq8+wHRTn3Au1fmHpQVXLjC0cIqr/Cm7kIbut0t83dQJ 5mog== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=mMy73XZt; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id i64si1651225edd.574.2020.05.25.12.40.44; Mon, 25 May 2020 12:41:06 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=mMy73XZt; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390715AbgEYNCw (ORCPT + 99 others); Mon, 25 May 2020 09:02:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:32804 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388757AbgEYNCw (ORCPT ); Mon, 25 May 2020 09:02:52 -0400 Received: from mail-ej1-x644.google.com (mail-ej1-x644.google.com [IPv6:2a00:1450:4864:20::644]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 12B70C061A0E; Mon, 25 May 2020 06:02:52 -0700 (PDT) Received: by mail-ej1-x644.google.com with SMTP id l21so20405577eji.4; Mon, 25 May 2020 06:02:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=DZr4IPFA4Vnbkt6An22aT54SGu2lLj63yMeWXMh2dCU=; b=mMy73XZtjjq+v4fDME0JBmckAwsdZlGQrcp1G0zD8WngkTBWfH8HjpTofWsjJgwraQ ncz6Rex61aGiRYH768s46xsWQhHLzdLe+qi7H71M8wHZZh318/BIb+Kzd5ljR9FhsExI Y2VNq5YIzefbTqjzrHmYmgdsZU/SnNdopkjk3ByxS+Jz0popDoFuQJjrziYpS8S0GhCx Y4tLWe5ROO8kQzaBLll0odz/tcULVeR1RkqKR11ed9IyOCy9v6pjqS2HRqr5HNTMtNkx b1rdKVPBUHwclqn85zggGlfCuHdP1ndh4g0dleq/9Tj7GiwnkBUROk3iM8J0VcDSsOpq zAaw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=DZr4IPFA4Vnbkt6An22aT54SGu2lLj63yMeWXMh2dCU=; b=RFxwan3zqfPWkMg7acC6TEMvNel1IHWQ4PjxqG6gNqx7DAIdR8r/he8fjgimtDgeVI JudUy5kTZY7sNxTwXHSkshcWn+vhx7HHe8xv464jRJFrExZ++RX+UyEEzn1BouniLbeB mXVi+kDcqV0v+t+kntmLXAlj4EW4LxZQwVnA22VysH8pCP2F7SYqLIVcq6MV38aZCCbD t52Xbd656qGWbGpvXZ8vyWNFiT7942aosEQqsN3ix26qoXKCri6f8m2Ui2igZ/32NZaW VHjvf9CBQDqeSh34AyuYNdeT9NCq6nn3E6/7E3UE54cnd+EHz3ZsTykPnVSsPAdEOvTf i3wg== X-Gm-Message-State: AOAM530OoH6MTkNiBFFTSWo6ejuFu8oHv1eAIQ0CW6uIsr7iOxcwqUM8 khbNPxfrX4QirucgruQO7Xw= X-Received: by 2002:a17:906:aeca:: with SMTP id me10mr19856510ejb.367.1590411770746; Mon, 25 May 2020 06:02:50 -0700 (PDT) Received: from localhost.localdomain ([188.25.147.193]) by smtp.gmail.com with ESMTPSA id d15sm15656750edr.3.2020.05.25.06.02.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 May 2020 06:02:50 -0700 (PDT) From: Vladimir Oltean To: gregkh@linuxfoundation.org, linux-serial@vger.kernel.org Cc: jslaby@suse.com, andriy.shevchenko@linux.intel.com, lukas@wunner.de, heikki.krogerus@linux.intel.com, vigneshr@ti.com, linux-kernel@vger.kernel.org, fido_max@inbox.ru, radu-andrei.bulie@nxp.com Subject: [PATCH] serial: 8250: probe all 16550A variants by default Date: Mon, 25 May 2020 16:02:38 +0300 Message-Id: <20200525130238.3614179-1-olteanv@gmail.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Vladimir Oltean On NXP T1040, the UART is typically detected as 16550A_FSL64. After said patch, it gets detected as plain 16550A and the Linux console is completely garbled and missing characters. So clearly, introducing the SERIAL_8250_16550A_VARIANTS config option has broken many existing users because it has changed the default behavior. Restore that by adding a 'default y' to this option. Users who care about 20 ms shorter boot time can always disable it, but stop wasting many debugging hours for people who don't care all that much. Fixes: dc56ecb81a0a ("serial: 8250: Support disabling mdelay-filled probes of 16550A variants") Signed-off-by: Vladimir Oltean --- drivers/tty/serial/8250/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/tty/serial/8250/Kconfig b/drivers/tty/serial/8250/Kconfig index af0688156dd0..89c7ecb55619 100644 --- a/drivers/tty/serial/8250/Kconfig +++ b/drivers/tty/serial/8250/Kconfig @@ -63,6 +63,7 @@ config SERIAL_8250_PNP config SERIAL_8250_16550A_VARIANTS bool "Support for variants of the 16550A serial port" depends on SERIAL_8250 + default y help The 8250 driver can probe for many variants of the venerable 16550A serial port. Doing so takes additional time at boot. -- 2.25.1