Received: by 2002:a25:2c96:0:0:0:0:0 with SMTP id s144csp1420151ybs; Mon, 25 May 2020 15:57:13 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx8V6UoqiwB544ImXsXI+UpaA7cE+zznCo9jI6MRXRNEdHEnYbwGqApg2yQB3U2p2/vxZjX X-Received: by 2002:a17:906:938a:: with SMTP id l10mr19914426ejx.186.1590447433448; Mon, 25 May 2020 15:57:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1590447433; cv=none; d=google.com; s=arc-20160816; b=M4uBLAF30QoPqd8IZDmLi8GqyU8viIdS2tEBfzSa0YyLXXhFjQqfJILvh3omWVvd9N P9JiCkdb4eyTw/oXk9HSxnw+38OwcEw1tzCed6djgdoSqcYIGxIrcrN936I5lnv5Vlic 3lkw7T3+EMBGIyvCL78PjhvZHoD5kKim+++q0VHhtm2UA+IFlx3P+ecE8XTuF3I3jXbz iEG1dhnbA2kP56R2EgmXHxph8fhYi7dSx+d49/I8Q3Pdm7vlkYQhnVcV7iLtRvmQVcGs 0srYYTnvI5Sm4OkphXtNDuhfCAMt6DG8wCg8ej8/9EAlgRZkIZ2IIPUPpSozkYIlE9J2 +5WA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=U75/cbCcAyXfzuiFK7KXv+sfRvsN3iSpASew1Ubcwn8=; b=JIIb2HXxLYtZ/DE2YkRB2/LRe6UApuV9nthehkQ1FNxRKt1lgty8FZz7jPTTXgYY41 FqUOMh+5Bt3/5IS3K+mhlSkEwIFwE3dhvC7Ws8ebHeQey3WN/HHBi6XRP3jE+KFVbS1K oz8FrFxNIdpxvFckMpRVJWZte+BW035O5VN7H1RBMkcdns6Iq6kpYjAWRlPpBwJfxoJe ZTisgiVA9rWMtuBV93/Li+OLYdS0UZ1Hg5X6Jmnt4jx1djaw8p3KTPiuJcKctXjnK9ak 53LVD4t0ztH8annjyvYG4ynRKOJCdEEcPMRqmCjFH32EiO2PZh5yzhIfiF3/l2Et0cmF Y2Yg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=zFIAMLsx; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id rv13si512350ejb.301.2020.05.25.15.56.50; Mon, 25 May 2020 15:57:13 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=zFIAMLsx; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728551AbgEYWbs (ORCPT + 99 others); Mon, 25 May 2020 18:31:48 -0400 Received: from mail.kernel.org ([198.145.29.99]:59934 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725964AbgEYWbr (ORCPT ); Mon, 25 May 2020 18:31:47 -0400 Received: from localhost.localdomain (c-73-231-172-41.hsd1.ca.comcast.net [73.231.172.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 2356F207CB; Mon, 25 May 2020 22:31:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1590445907; bh=U75/cbCcAyXfzuiFK7KXv+sfRvsN3iSpASew1Ubcwn8=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=zFIAMLsxnzq3sufRj+2AkgYKks9Kc0bnKKuFfqIbeDy/c8dqMka8T76n+a1MftXQn cdRmILx7yjnTnG/RQs3wOW5XKNUELtHk9Poa/ytnQcFLHen0aTN9BSbbs9exYo2Bj+ L94COAxZM2PJ73n1dXxxacGsf0vU0WAaPS5ZgRSw= Date: Mon, 25 May 2020 15:31:46 -0700 From: Andrew Morton To: Wei Yang Cc: Andy Shevchenko , Jesse Brandeburg , christian.brauner@ubuntu.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH] bitops: simplify get_count_order_long() Message-Id: <20200525153146.c1337b1ca7af386ac30e5702@linux-foundation.org> In-Reply-To: <20200525215741.zd3gry4yyqqplix6@master> References: <20200524123551.9469-1-richard.weiyang@gmail.com> <20200525091458.GK1634618@smile.fi.intel.com> <20200525144312.mbw2z3ydncyasvss@master> <20200525153216.GD1634618@smile.fi.intel.com> <20200525134110.5737dd603d5fa1230e2f7ece@linux-foundation.org> <20200525215741.zd3gry4yyqqplix6@master> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 25 May 2020 21:57:41 +0000 Wei Yang wrote: > I see the patch just merged, so I suppose to add the above test code into that > one? Well, that's not really test code. But yes, something which tests both the 32-bit and 64-bit functions would be nice, sometime.