Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: S9Fx4ajfGqhgqzo84fzOZniEiEYWXdH0rjRzZ3oAe+ab3KrAkfmSeVBv3vl5DTq1WRhYz1y7Bc
 X7k5RhCAVXtQ==
IronPort-SDR: p+bdVQOGmBhaDsJ21DrxF7LQs9nd6Wdqqg3jlOcTyeNeNoubxtYMpcwPFyN0gOkt+qoR7yRrQM
 Zum3xcRZwJWA==
Date:   Mon, 25 May 2020 18:32:16 +0300
From:   Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To:     Wei Yang <richard.weiyang@gmail.com>,
        Jesse Brandeburg <jesse.brandeburg@intel.com>
Cc:     akpm@linux-foundation.org, christian.brauner@ubuntu.com,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] bitops: simplify get_count_order_long()
Message-ID: <20200525153216.GD1634618@smile.fi.intel.com>
References: <20200524123551.9469-1-richard.weiyang@gmail.com>
 <20200525091458.GK1634618@smile.fi.intel.com>
 <20200525144312.mbw2z3ydncyasvss@master>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200525144312.mbw2z3ydncyasvss@master>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, May 25, 2020 at 02:43:12PM +0000, Wei Yang wrote:
> On Mon, May 25, 2020 at 12:14:58PM +0300, Andy Shevchenko wrote:
> >On Sun, May 24, 2020 at 12:35:51PM +0000, Wei Yang wrote:
> >> These two cases could be unified into one.
> >
> >Care to provide a test case which supports your change?
> >
> 
> Hmm.. where should I put the test? tools/testing/selftests/ ?

I guess into test_bitops.c [1]? I though it eventually should make kernel, but I don't see it.

Andrew, can you apply that or do you need Jesse to resend?

[1]: https://lore.kernel.org/lkml/20200310221747.2848474-2-jesse.brandeburg@intel.com/

> 
> >> Signed-off-by: Wei Yang <richard.weiyang@gmail.com>
> >> ---
> >>  include/linux/bitops.h | 5 +----
> >>  1 file changed, 1 insertion(+), 4 deletions(-)
> >> 
> >> diff --git a/include/linux/bitops.h b/include/linux/bitops.h
> >> index 9acf654f0b19..5b5609e81a84 100644
> >> --- a/include/linux/bitops.h
> >> +++ b/include/linux/bitops.h
> >> @@ -206,10 +206,7 @@ static inline int get_count_order_long(unsigned long l)
> >>  {
> >>  	if (l == 0UL)
> >>  		return -1;
> >> -	else if (l & (l - 1UL))
> >> -		return (int)fls_long(l);
> >> -	else
> >> -		return (int)fls_long(l) - 1;
> >> +	return (int)fls_long(--l);
> >>  }
> >
> >-- 
> >With Best Regards,
> >Andy Shevchenko
> >
> 
> -- 
> Wei Yang
> Help you, Help me

-- 
With Best Regards,
Andy Shevchenko