Received: by 2002:a25:2c96:0:0:0:0:0 with SMTP id s144csp1441378ybs; Mon, 25 May 2020 16:32:26 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwbjNWEDZnzAYIlYcvvUMCxvw7VxHVaUOq1l0VU0L3LV7b9MOipZkcK+v6/4POa3SUt54Jb X-Received: by 2002:a17:906:3b4f:: with SMTP id h15mr22072554ejf.408.1590449545879; Mon, 25 May 2020 16:32:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1590449545; cv=none; d=google.com; s=arc-20160816; b=Bj6mEBmOkRvALYZBVY4sT08yrfFFpCkdCe/pwKJ2emPJ+iJy74QmsuHlWYStxwKJi7 9n570j3cumBXosh9jtS2cICEi51UhUeTBx7eVeNyzV4GldX7AKvBx0jXgu/R8LrfEbQY I5VhIWQM5/WeSFTrJmYVWJm0MXEJ/7HMHe6pz9eTD6Ts7tQ1RQVkYIc4kCmTWXX48O8h X7+uHU7KEVk412XKYd470wmc9GpxMCx//i91oqX1o+rmufrbYEPkh4sDbGm4OAqOhQQd Tp3cia/x18Ri94TcHEwCgJe4ZXVeQiERkKJ3WlTsnXqSOUzor+4BqvNCFMdOrE20SnCH 1lvA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=CM3xbvfT6889wPKnUUjils4zHkgMqAlAinbEADPEzjg=; b=dvw2fVw+L9+aODLiidnfbxSDTF5UyHNdNLfmbELqWztTJ/R5YotX+xKV0JocOvSEc6 +VYC5Dfd1T4t18z2bQU5Yo835jCw8fglbJZ0ZTa5LsvWK9LJc0AN9MGsklywXGO4OpX9 3G5w9+2V7oWv1CgQ3GOdwl1jmq+mapKgoQ5ipMfyVXfCGrXLoYo0NAQOq6I3JEo+4Z27 wRXcsIOItExi1He3wsx8M9FK9LJRJFOAhOWT1RlwQiO5xlLM6uKTRgyxccOWqQxFWUyi yHC0IZ5o/aqOiF3j8DcQ/EAdNgVgtgzDb55w9O6W9hKvZnN/np4jlB7QyiTqXoYdi2qH Sg6w== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail (test mode) header.i=@armlinux.org.uk header.s=pandora-2019 header.b="d4fo5X/i"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=armlinux.org.uk Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id a99si11214743edf.381.2020.05.25.16.32.03; Mon, 25 May 2020 16:32:25 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=fail (test mode) header.i=@armlinux.org.uk header.s=pandora-2019 header.b="d4fo5X/i"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=armlinux.org.uk Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729984AbgEYVIJ (ORCPT + 99 others); Mon, 25 May 2020 17:08:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53624 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729550AbgEYVII (ORCPT ); Mon, 25 May 2020 17:08:08 -0400 Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [IPv6:2001:4d48:ad52:3201:214:fdff:fe10:1be6]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 05C06C061A0E; Mon, 25 May 2020 14:08:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=CM3xbvfT6889wPKnUUjils4zHkgMqAlAinbEADPEzjg=; b=d4fo5X/icyYj5Xn8uC1O6UBcs /c2uultrJSj6riGRJtx5DqN7YU3CLvhEDk+7l6i2sBln/Uqj9h8nV0uMToJK6fC/wKkPzf3bE1Y9n vC5FWqWJZ5CLELKEg2d3qd7dQRhxYlY6MK1YpXNkz3VTH6dst/yMtQk1POklsUVRTs/un0hYAv1yf W18mphu+Hgm9ivVgCqHVC5gpasHesJoqR77lR4PZ1+04lw+phtuAuf9uCVKRka1bm1tUE6LiTtw1F t2No96ghT8LJ2dryRg/SITKaACHnkvS5rjg+oI02tHy0SqM2PdIkOcjgrBae07BgXDztD+Lo3v0i4 bMeYXTsxg==; Received: from shell.armlinux.org.uk ([2001:4d48:ad52:3201:5054:ff:fe00:4ec]:44992) by pandora.armlinux.org.uk with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jdKKD-00062L-7c; Mon, 25 May 2020 22:07:57 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.92) (envelope-from ) id 1jdKK7-0004fb-G0; Mon, 25 May 2020 22:07:51 +0100 Date: Mon, 25 May 2020 22:07:51 +0100 From: Russell King - ARM Linux admin To: Jeremy Linton Cc: netdev@vger.kernel.org, davem@davemloft.net, andrew@lunn.ch, f.fainelli@gmail.com, hkallweit1@gmail.com, madalin.bucur@oss.nxp.com, calvin.johnson@oss.nxp.com, linux-kernel@vger.kernel.org Subject: Re: [RFC 01/11] net: phy: Don't report success if devices weren't found Message-ID: <20200525210751.GN1551@shell.armlinux.org.uk> References: <20200522213059.1535892-1-jeremy.linton@arm.com> <20200522213059.1535892-2-jeremy.linton@arm.com> <20200523182054.GW1551@shell.armlinux.org.uk> <20200525094536.GK1551@shell.armlinux.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, May 25, 2020 at 04:02:13PM -0500, Jeremy Linton wrote: > > So, I think you're going to have to add a work-around to ignore bit 0, > > which brings up the question whether this is worth it or not. > > It does ignore bit 0, it gets turned into the C22 regs flag, and > cleared/ignored in the remainder of the code (do to MMD loop indexes > starting at 1). However, I've already pointed out that that isn't the case in a number of functions that I listed in another email, and I suspect was glossed over. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTC for 0.8m (est. 1762m) line in suburbia: sync at 13.1Mbps down 424kbps up