Received: by 2002:a25:2c96:0:0:0:0:0 with SMTP id s144csp1511435ybs; Mon, 25 May 2020 18:46:25 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyC1Fi3dMZtRW2tG033+ZEV4zpPVokY+N6MlQf/lYiZuz6W6lqQHGSCuF9G/Qdihl1+41n1 X-Received: by 2002:a17:906:6a43:: with SMTP id n3mr20100886ejs.33.1590457585652; Mon, 25 May 2020 18:46:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1590457585; cv=none; d=google.com; s=arc-20160816; b=W+1DuSiiqnMkE029+zbeea1yikJEaZid3vt7GBHzwCb80gcCVr2tYsr5BYzx1cJ/35 rfXxGzl4oi8Yj0TFbAdqT7lZ8JvuH6q3bqPrVBXPAIlaWaO5jbpJVh0EKq6PE4fdzrZm 0TwgljIcie2FPhCS/D1D0jLslvEFdqK1z8MACbSu+FMzVt0oVRmGWGzX33jszrWJRdjX /n91wBiKNQNCttC9PwPqP8cV2E26CpVIMX/o0TT+ZmMm/wPvc5r5VtkYUcM/5tQeuVpu oZvqiCxylQL/KNeNtQhOFcbsiQoGb75xxVYxqIxS2U5Gqf+nVz4gimkpxzgJ9Vih66q2 Tljw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=nncKvtcoVcTBq2vypwYG4Y05pUvnhd2A7cUwYa2jRrQ=; b=mcXKHKs7CmoVofjRX8DEUEoZBxBRCdfvpSg/Wp6spHBb1UVDNrHW+rKeMTNa8jRIFW rn/7yaSNxEKWTDBocEH2Ct/alo6X/igPBUzhNDGUdgnJrpzgj+oOgeV+QYAaitiKJPqY 3YXdzqsVC7UTgCgU7Pwf0uwer2zrG+nUznjC0fRgN6wwrBVdtdme5bXYZhJ46yp34H93 w3lMrmAhKnhw4xlBvTs34PHFsw/TpNPG1aQGOIEAs1ee1OBM2YR+gOUSMWwnzQ7o7d6W UqEKdGUqXVhRYcnr+s6/qqL7w9DJrtckM2L+xVMUHW54nUckvacoa021iJflAD+EwpJV /2vA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id ci12si10978281ejb.656.2020.05.25.18.46.02; Mon, 25 May 2020 18:46:25 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388560AbgEZBmv (ORCPT + 99 others); Mon, 25 May 2020 21:42:51 -0400 Received: from out30-131.freemail.mail.aliyun.com ([115.124.30.131]:33955 "EHLO out30-131.freemail.mail.aliyun.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387794AbgEZBmu (ORCPT ); Mon, 25 May 2020 21:42:50 -0400 X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R171e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e01422;MF=laijs@linux.alibaba.com;NM=1;PH=DS;RN=10;SR=0;TI=SMTPD_---0Tzg71.L_1590457346; Received: from localhost(mailfrom:laijs@linux.alibaba.com fp:SMTPD_---0Tzg71.L_1590457346) by smtp.aliyun-inc.com(127.0.0.1); Tue, 26 May 2020 09:42:26 +0800 From: Lai Jiangshan To: linux-kernel@vger.kernel.org Cc: Lai Jiangshan , Andy Lutomirski , Peter Zijlstra , Thomas Gleixner , x86@kernel.org, Ingo Molnar , Borislav Petkov , "H. Peter Anvin" , Alexandre Chartre Subject: [RFC PATCH V2 1/7] x86/hw_breakpoint: add within_area() to check data breakpoints Date: Tue, 26 May 2020 01:42:15 +0000 Message-Id: <20200526014221.2119-2-laijs@linux.alibaba.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200526014221.2119-1-laijs@linux.alibaba.com> References: <20200525152517.GY325280@hirez.programming.kicks-ass.net> <20200526014221.2119-1-laijs@linux.alibaba.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org within_area() is added for checking if the data breakpoints overlap with cpu_entry_area, and will be used for checking if the data breakpoints overlap with GDT, IDT, or TSS in places other than cpu_entry_area next patches. Cc: Andy Lutomirski Cc: Peter Zijlstra (Intel) Cc: Thomas Gleixner Cc: x86@kernel.org Signed-off-by: Lai Jiangshan --- arch/x86/kernel/hw_breakpoint.c | 13 +++++++++++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/arch/x86/kernel/hw_breakpoint.c b/arch/x86/kernel/hw_breakpoint.c index 9ddf441ccaa8..c149c7b29ac3 100644 --- a/arch/x86/kernel/hw_breakpoint.c +++ b/arch/x86/kernel/hw_breakpoint.c @@ -227,14 +227,23 @@ int arch_check_bp_in_kernelspace(struct arch_hw_breakpoint *hw) return (va >= TASK_SIZE_MAX) || ((va + len - 1) >= TASK_SIZE_MAX); } +/* + * Checks whether the range [addr, end], overlaps the area [base, base + size). + */ +static inline bool within_area(unsigned long addr, unsigned long end, + unsigned long base, unsigned long size) +{ + return end >= base && addr < (base + size); +} + /* * Checks whether the range from addr to end, inclusive, overlaps the CPU * entry area range. */ static inline bool within_cpu_entry_area(unsigned long addr, unsigned long end) { - return end >= CPU_ENTRY_AREA_BASE && - addr < (CPU_ENTRY_AREA_BASE + CPU_ENTRY_AREA_TOTAL_SIZE); + return within_area(addr, end, CPU_ENTRY_AREA_BASE, + CPU_ENTRY_AREA_TOTAL_SIZE); } static int arch_build_bp_info(struct perf_event *bp, -- 2.20.1