Received: by 2002:a25:2c96:0:0:0:0:0 with SMTP id s144csp1673361ybs; Tue, 26 May 2020 00:20:28 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyjGecj2Dt2nRW4c4aLF/w/DkuXVcK5RZQFOhDOtM005Z28nCCxUmz49zM+NRnRJhmjia3U X-Received: by 2002:a17:906:e0c7:: with SMTP id gl7mr21202409ejb.306.1590477628294; Tue, 26 May 2020 00:20:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1590477628; cv=none; d=google.com; s=arc-20160816; b=rJooHlWFugzjrNCHyTsb4dECRLTxLItCd0VGG+MZ/E25HGY4snTNQ8SW+9jgxchN7G ZO2jZkeJegRayDh4NkwsAAnVzBrHL6BfRE0oF05Da/OnjHel9AZpztRBCTxi8k00BXHG yCZtWzr/d/Ox3Qa2diNqz1B5qMNEX4BnwkZQ87cK5bqxah7AYP5Ho/cTfEp7B6R3vPuw nEa+DzjHiq03EyK3TAYwzmsG5R+Mb5RnSjo1i/Pmj0aJzNIvKmfS7qGxV4EPDyrGJMcc VMwpFivWAFGaDy/JuBZ69/ipfGufB9qpIQdGW1zvBq72ZfRkPE3OLGDiHJ+SBCv+ixg7 KJfg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=pOrIHrEqmE1Ff6PLoUb1mXHZ6R6WiATLaOFWqHMNu6U=; b=M28Ki+tYZzTI/ODkgcT2kcjjxd79I8St3w0es5IGg13VW6EM+KffG4d46YLJu2o7KT ytWYBSpHDW29ZuSuZOmYq+Moepgoc31x5eD2f9hPZ1PwxtZKTsKRxiZCMRhXi2RIdSfb 47sKZkwpH9Fc9FKK5ZLJRahT9XYLhoxZKPF+ZqIMoEKlYA7MUMl5onZKcWj2tlIIxeOH lzlM45LiHiIA0q1Lb0wzWKvsqkoMZauqJpQNGlZRVZ2okDzTdHlQPfQ/fxkqIqWm2fWA r84SXY6k4tlYQuYaDcOAng7k/5yU4We3/Z9xP0SniLpG0nKISAhLyeNEDhGLL7OtlXL4 uDzQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ozlabs.org header.s=201707 header.b="dr7/DCW1"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=ozlabs.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id t2si9826709eds.9.2020.05.26.00.20.01; Tue, 26 May 2020 00:20:28 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@ozlabs.org header.s=201707 header.b="dr7/DCW1"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=ozlabs.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726768AbgEZF7c (ORCPT + 99 others); Tue, 26 May 2020 01:59:32 -0400 Received: from bilbo.ozlabs.org ([203.11.71.1]:34689 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726598AbgEZF7b (ORCPT ); Tue, 26 May 2020 01:59:31 -0400 Received: by ozlabs.org (Postfix, from userid 1003) id 49WNZn11tSz9sRY; Tue, 26 May 2020 15:59:29 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ozlabs.org; s=201707; t=1590472769; bh=UvsMjZEYjC+bU7cDuBcQ49xsO8s4tc7S4Vm5YquVl3s=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=dr7/DCW1ueRx4rYAQYErFOviGddLWKlo5BpU5HFciy9CJet5sWJEf2BjRFaWIfdr8 exnM7o9NB/Edk/VdBss9/EVVuN4f8bDfV11zfFBbmNSYetArbeqDrPhOe9n7g0jy2w jPlaaGtU/Bys9q0B1FhwBdGuQzbxpZlMef7Omzw1nQCaKfe0sUl0HzmqRRaLXCiNsq 9mwubjD8MVwaThkdXmLYOSbANn8EQAl66FmLO02dquKK/12GEHaZ8qqqsY5MwEIHvQ CTVrP2oC3cIqV5tanqXHRykuANp24K+isJl9f5Ks+0pA8PSIeFjFgqi3fPTEglfkPk PJf2vvuHBAlag== Date: Tue, 26 May 2020 15:49:50 +1000 From: Paul Mackerras To: Tianjia Zhang Cc: pbonzini@redhat.com, tsbogend@alpha.franken.de, mpe@ellerman.id.au, benh@kernel.crashing.org, borntraeger@de.ibm.com, frankja@linux.ibm.com, david@redhat.com, cohuck@redhat.com, heiko.carstens@de.ibm.com, gor@linux.ibm.com, sean.j.christopherson@intel.com, vkuznets@redhat.com, wanpengli@tencent.com, jmattson@google.com, joro@8bytes.org, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, x86@kernel.org, hpa@zytor.com, maz@kernel.org, james.morse@arm.com, julien.thierry.kdev@gmail.com, suzuki.poulose@arm.com, christoffer.dall@arm.com, peterx@redhat.com, thuth@redhat.com, chenhuacai@gmail.com, kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, linux-mips@vger.kernel.org, kvm-ppc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 4/7] KVM: PPC: clean up redundant 'kvm_run' parameters Message-ID: <20200526054950.GC282305@thinks.paulus.ozlabs.org> References: <20200427043514.16144-1-tianjia.zhang@linux.alibaba.com> <20200427043514.16144-5-tianjia.zhang@linux.alibaba.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200427043514.16144-5-tianjia.zhang@linux.alibaba.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Apr 27, 2020 at 12:35:11PM +0800, Tianjia Zhang wrote: > In the current kvm version, 'kvm_run' has been included in the 'kvm_vcpu' > structure. For historical reasons, many kvm-related function parameters > retain the 'kvm_run' and 'kvm_vcpu' parameters at the same time. This > patch does a unified cleanup of these remaining redundant parameters. > > Signed-off-by: Tianjia Zhang This looks OK, though possibly a little larger than it needs to be because of variable name changes (kvm_run -> run) that aren't strictly necessary. Reviewed-by: Paul Mackerras