Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20200525093019.2253-1-qiang.zhang@windriver.com>
In-Reply-To: <20200525093019.2253-1-qiang.zhang@windriver.com>
From:   Lai Jiangshan <jiangshanlai@gmail.com>
Date:   Tue, 26 May 2020 16:56:19 +0800
Message-ID: <CAJhGHyC4XcNL8yzWZKZ=73wZJej4JwCaAHGV8qjYn-AqcEAEjQ@mail.gmail.com>
Subject: Re: [PATCH v3] workqueue: Fix double kfree for rescuer
To:     qiang.zhang@windriver.com
Cc:     Tejun Heo <tj@kernel.org>, markus.elfring@web.de,
        LKML <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, May 25, 2020 at 5:22 PM <qiang.zhang@windriver.com> wrote:
>
> From: Zhang Qiang <qiang.zhang@windriver.com>
>
> The callback function "rcu_free_wq" could be called after memory
> was released for "rescuer" already, Thus delete a misplaced call
> of the function "kfree".

Hello

wq->rescuer is guaranteed to be NULL in rcu_free_wq()
since def98c84b6cd
("workqueue: Fix spurious sanity check failures in destroy_workqueue()")

And the resucer is already free in destroy_workqueue()
since 8efe1223d73c
("workqueue: Fix missing kfree(rescuer) in destroy_workqueue()")

The patch is a cleanup to remove a "kfree(NULL);".
But the changelog is misleading.

>
> Fixes: 6ba94429c8e7 ("workqueue: Reorder sysfs code")

It is totally unrelated.

> Signed-off-by: Zhang Qiang <qiang.zhang@windriver.com>
> ---
>  v1->v2->v3:
>  Only commit information modification.
>  kernel/workqueue.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/kernel/workqueue.c b/kernel/workqueue.c
> index 891ccad5f271..a2451cdcd503 100644
> --- a/kernel/workqueue.c
> +++ b/kernel/workqueue.c
> @@ -3491,7 +3491,6 @@ static void rcu_free_wq(struct rcu_head *rcu)
>         else
>                 free_workqueue_attrs(wq->unbound_attrs);
>
> -       kfree(wq->rescuer);
>         kfree(wq);
>  }
>
> --
> 2.24.1
>