Received: by 2002:a25:2c96:0:0:0:0:0 with SMTP id s144csp179312ybs; Tue, 26 May 2020 06:40:01 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwJzyZgV4hpSNEVZQfYub65ZpYPBAZ8MIEkCGZPWKEAvII+yHUjsAujcU+I4olpV0ZeK4PW X-Received: by 2002:a17:906:5243:: with SMTP id y3mr1166205ejm.193.1590500400831; Tue, 26 May 2020 06:40:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1590500400; cv=none; d=google.com; s=arc-20160816; b=wIixSOvC41v7mcx1Iy2gx+fBr5VPJV3ufGh89Dn1/kTMW8LhFAl2RVV0mdb7tYe+P2 WSfX4A7H9chK6Fkuk70AbFZHiC/6+ClsHrTtDN1ZBtR5fMPbyAL4gX7xRnVjhhJA5nTO IFBgolTanMT1VGFc1PxvYgUFdOlc/7Phmab2Vwn4Q3+7cnsY61ys5hCfelstzUusOOC1 eGXUVNJitFhkYwMbu96QENSAkQUeuBdKttIB35Hhx5tyBxIULRbKTS86kS3Wcz8+8vnk sklTX8DRk2tLEQIVuh4nof8wojBjV4tkAoFq6iNp77PFhuCXSj6kpXdBzfGcPalVUjm1 WcIA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=mNf/MLE9EJKF49V8THzb8CUWHV8D399d1KXQQjEU8ko=; b=wn9DpzTqPR+3DSm9ORRqcbz3H1a2MKFZPQ8Gn0xtXIxkh/wp5b637aqR4XSxx4fIEg lQgT2sLtS6TDtwkDkGgzS0ez7zXKrR8qMhQCuwFAfi26bbY9LqDUX/8q9lxiV9TGIXpr hHZ3VbZYl8I++7g+7cS5DLecxZMlhPRs8yU0YjV5dUSd/yvcN1MhnNmt6hWfSaFWCD7z yCeMrP5EBy1rql6lyOp0aXIG9VF8QGAZDuq50YZb/7sdWGBhYjhe8tjbIY4XVQmWe0J+ WE5MdDxU3NDj5122d7viQjGpaE/8D8O2aiOXFeoioAgL64zOkPvBecqW3zY7CZtvgpuY 0PKQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id a17si10909574ejy.272.2020.05.26.06.39.37; Tue, 26 May 2020 06:40:00 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731877AbgEZKK1 (ORCPT + 99 others); Tue, 26 May 2020 06:10:27 -0400 Received: from foss.arm.com ([217.140.110.172]:48548 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731716AbgEZKK1 (ORCPT ); Tue, 26 May 2020 06:10:27 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 7F6941FB; Tue, 26 May 2020 03:10:26 -0700 (PDT) Received: from bogus (unknown [10.37.8.209]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 56E413F52E; Tue, 26 May 2020 03:10:22 -0700 (PDT) Date: Tue, 26 May 2020 11:10:19 +0100 From: Sudeep Holla To: Jianyong Wu Cc: "netdev@vger.kernel.org" , "yangbo.lu@nxp.com" , "john.stultz@linaro.org" , "tglx@linutronix.de" , "pbonzini@redhat.com" , "sean.j.christopherson@intel.com" , "maz@kernel.org" , "richardcochran@gmail.com" , Mark Rutland , "will@kernel.org" , Suzuki Poulose , Steven Price , Justin He , Wei Chen , "kvm@vger.kernel.org" , Steve Capper , "linux-kernel@vger.kernel.org" , Kaly Xin , nd , Sudeep Holla , "kvmarm@lists.cs.columbia.edu" , "linux-arm-kernel@lists.infradead.org" Subject: Re: [RFC PATCH v12 03/11] psci: export smccc conduit get helper. Message-ID: <20200526101019.GB11414@bogus> References: <20200522083724.38182-1-jianyong.wu@arm.com> <20200522083724.38182-4-jianyong.wu@arm.com> <20200522131206.GA15171@bogus> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, May 25, 2020 at 01:37:56AM +0000, Jianyong Wu wrote: > Hi Sudeep, > > > -----Original Message----- > > From: Sudeep Holla > > Sent: Friday, May 22, 2020 9:12 PM > > To: Jianyong Wu > > Cc: netdev@vger.kernel.org; yangbo.lu@nxp.com; john.stultz@linaro.org; > > tglx@linutronix.de; pbonzini@redhat.com; sean.j.christopherson@intel.com; > > maz@kernel.org; richardcochran@gmail.com; Mark Rutland > > ; will@kernel.org; Suzuki Poulose > > ; Steven Price ; Justin > > He ; Wei Chen ; > > kvm@vger.kernel.org; Steve Capper ; linux- > > kernel@vger.kernel.org; Kaly Xin ; nd ; > > Sudeep Holla ; kvmarm@lists.cs.columbia.edu; > > linux-arm-kernel@lists.infradead.org > > Subject: Re: [RFC PATCH v12 03/11] psci: export smccc conduit get helper. > > > > On Fri, May 22, 2020 at 04:37:16PM +0800, Jianyong Wu wrote: > > > Export arm_smccc_1_1_get_conduit then modules can use smccc helper > > > which adopts it. > > > > > > Acked-by: Mark Rutland > > > Signed-off-by: Jianyong Wu > > > --- > > > drivers/firmware/psci/psci.c | 1 + > > > 1 file changed, 1 insertion(+) > > > > > > diff --git a/drivers/firmware/psci/psci.c > > > b/drivers/firmware/psci/psci.c index 2937d44b5df4..fd3c88f21b6a 100644 > > > --- a/drivers/firmware/psci/psci.c > > > +++ b/drivers/firmware/psci/psci.c > > > @@ -64,6 +64,7 @@ enum arm_smccc_conduit > > > arm_smccc_1_1_get_conduit(void) > > > > > > return psci_ops.conduit; > > > } > > > +EXPORT_SYMBOL(arm_smccc_1_1_get_conduit); > > > > > > > I have moved this into drivers/firmware/smccc/smccc.c [1] Please update > > this accordingly. > > Ok, I will remove this patch next version. You may need it still, just that this patch won't apply as the function is moved to a new file. -- Regards, Sudeep