Received: by 2002:a25:2c96:0:0:0:0:0 with SMTP id s144csp187922ybs; Tue, 26 May 2020 06:52:57 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyuh9sNZ1xvyMPqCYV1daq88SxeSwP+5ic4kPNAPZhXnpCTMjK1C8lUnGK5zraH1L3OlN+b X-Received: by 2002:a17:906:51b:: with SMTP id j27mr1176380eja.246.1590501177837; Tue, 26 May 2020 06:52:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1590501177; cv=none; d=google.com; s=arc-20160816; b=rGbQ63d107NjJbn3SYGozbgXuOUsP2BVfa4Ww9DxR3kYQCrfxgzWADkI2OnZMXsKlO tr7PzoyqgDSIRuvGCuwF/XbP6V2wCJdr8gp/LqHDxiFXyETNKJIgkl13ml3WkiuPfyW2 /aTxtlmSoulGr8aUfFGtYdSTTr810/4NtQIEPV1qPDQos2tTsOI4zO2Y1dKtrHO7HCL/ 39jxOTKIn18NDLu1tMPC4pXQfiVjUfaIxjN3FmtCDJOeV7C2yMjcwKQmtjjvVpppUmEk z9G/cuz5tTyV8LWxinbRn7VTJUM80HrN+wBm6AZv/0ksuVbbGabmW4R1z2sjuFwtXWo2 t7cQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=cTbv0uh9H2v3GlvnxZThLbkjwBjPPrRm8Gwj2rU9LtU=; b=X8fECuidannEMFC1KnjjvF3ouZcc/2y+7Or9WoCTQIlgt9Cs5HxSp4how8inkahWET qRbvCY4rSfRY+xrqHMWRuutZC6qMRxvK3kzkL2e7tXHoppfZ+24vEi70CF48HkBUF2ly YJWU0K0SYbJ0TVQoqwqp7raxye3VpzIWCUlQ9Z2bP9t54d6+zn4BffgdLwZHLMTO8/ZN MuSRGuTN2/RlfdL01aINGgiPx5ACDIyMO4WKnsCgb60G4X/kdslphqVPzrHHyWjia9bH ZjayubRTaftEAYfYiqr3+EW/olqdcK63ggZKgSct1e+N+E+mHzj+AxEr75ExUEQXONSW 4A9g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id m7si10896175edg.244.2020.05.26.06.52.34; Tue, 26 May 2020 06:52:57 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729085AbgEZNHQ (ORCPT + 99 others); Tue, 26 May 2020 09:07:16 -0400 Received: from elvis.franken.de ([193.175.24.41]:39897 "EHLO elvis.franken.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728682AbgEZNHP (ORCPT ); Tue, 26 May 2020 09:07:15 -0400 Received: from uucp (helo=alpha) by elvis.franken.de with local-bsmtp (Exim 3.36 #1) id 1jdZIW-00088o-02; Tue, 26 May 2020 15:07:12 +0200 Received: by alpha.franken.de (Postfix, from userid 1000) id DA835C041A; Tue, 26 May 2020 15:05:25 +0200 (CEST) Date: Tue, 26 May 2020 15:05:25 +0200 From: Thomas Bogendoerfer To: Lichao Liu Cc: YuanJunQing , paulburton@kernel.org, chenhc@lemote.com, linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] MIPS: Fix IRQ tracing when call handle_fpe() Message-ID: <20200526130525.GC8487@alpha.franken.de> References: <20200525033123.13114-1-yuanjunqing66@163.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200525033123.13114-1-yuanjunqing66@163.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 26, 2020 at 02:03:14PM +0800, Lichao Liu wrote: > From: YuanJunQing > > Register "a1" is unsaved in this function, > when CONFIG_TRACE_IRQFLAGS is enabled, > the TRACE_IRQS_OFF macro will call trace_hardirqs_off(), > and this may change register "a1". > The variment of register "a1" may send SIGFPE signal > to task when call do_fpe(),and this may kill the task. > > Signed-off-by: YuanJunQing if you send patches from other people, please add your Signed-off-by. Thomas. -- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ]