Received: by 2002:a25:ef43:0:0:0:0:0 with SMTP id w3csp50094ybm; Tue, 26 May 2020 10:27:49 -0700 (PDT) X-Google-Smtp-Source: ABdhPJye8PdvcSap16ALgrk6oF1bgp/YfbXZZ54K/EOdGwCTTzQzs0AvE3vb83qBP4Qpx/w56eXP X-Received: by 2002:a17:906:dbcf:: with SMTP id yc15mr2054924ejb.176.1590514069217; Tue, 26 May 2020 10:27:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1590514069; cv=none; d=google.com; s=arc-20160816; b=D/5bz8noeklMMta3onmGRcHwyRpG+DKRGwpNWfTsJmPcYXPCd0vkNuyKqaTjEfsFUr vZbyajVRoSuyAwIKd2dcWyv7nyDkdi9ndSeh/0X/d1U+yv9ZPM7/ABqGVGrkCENG81u8 kHsr+Xp9F9BRpqBsJKSZxq6XDnS+v6B8U+GlI8ij/1CTBsky+WgtH1T+lO8QaYvxH+Pb WhMFN0QwgUjhBWkUStMpzuOxvFzh3gQpxsX9wyoT8a3VcvQ459fHDnv5HEB7AjtN4GyY i6sOrRQTW3Bw25DZkWSY+tk+N0GGIxwO9TYERZBkSBOI9d82JYM0mkjuG4mcNf/cVla1 d8aw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=SYQZMFTEBJ18xeJeS1buRtQuG/fExe+cZBQxRWLCEdI=; b=1I2vdQsgFMS8ZpSN/YGmQx+IVQCE5fr1K3J83jv6CoxKBfX72Cx631dzFceN2GLA2n nYMyg2OeTJ2wzOGP66muRym8VoyekKzPDK9pPw99R96Mx0yPbCpbe4YH6VXWy0tS3O1V dt++9hKXF9dJDneyNMMmHEwzKWfAt9wZ2P1TSVJ79+teveU8AYmnSfVKRLd5dfr7QBs7 664+gP+XKCmdCzfP+yAOl6XEYU9uJmamVT/v4Urggz8ppq+4tIa02+3/XhAOuJroWx1Q yH1/gtW5oxNtJMOfC03bOT45Grg1HNU8lautFKTAM+B8Bqk+64dC5PCBaSsVgC5SkI4o TRhg== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=DBB2dXXy; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id z6si284809eju.289.2020.05.26.10.27.26; Tue, 26 May 2020 10:27:49 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=DBB2dXXy; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389498AbgEZRYx (ORCPT + 99 others); Tue, 26 May 2020 13:24:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45638 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388844AbgEZRXo (ORCPT ); Tue, 26 May 2020 13:23:44 -0400 Received: from mail-qv1-xf44.google.com (mail-qv1-xf44.google.com [IPv6:2607:f8b0:4864:20::f44]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CEF73C03E96D; Tue, 26 May 2020 10:23:43 -0700 (PDT) Received: by mail-qv1-xf44.google.com with SMTP id dh1so9783207qvb.13; Tue, 26 May 2020 10:23:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=SYQZMFTEBJ18xeJeS1buRtQuG/fExe+cZBQxRWLCEdI=; b=DBB2dXXyQS8i2KL6fgI0iY3v+kzmXamXskvxCjgHOeueAxTFhY4qC9ElWV+f2i479K QgcXP98W5NFfdi6cLmwRIm5jRaajZ8Xq7c0jS72HCWME/8Aas5rcXPl/uwSEOB+PWYmO Z3J++foQU1ozkoo2brpOSl+duSw8dye0KsWj/pmWQjzzjVRDRm7PUb6cnoCrFBZvZwMW InpmBDBrFiYlJd+AhV8vkCA3HCv+Ri0pjM+wDegKgRiYKUdb2EOcEM6peCwi5NR1/peF tGUKznRKDoHnuAvvD+pPYLR7nxGJWvxFBE7FlmmQc/4cwA0CRXHJEEDCXEqIH6PsKNep vYRQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to; bh=SYQZMFTEBJ18xeJeS1buRtQuG/fExe+cZBQxRWLCEdI=; b=n7+QUx2OtX1zV0w2oYk0t7Pef67ElN6QPRgQKAHQOc9kLv8K7Ozbqa8zM9UuucCvEv WY+3Gj0lpo1uLHr+4saZL53Y5Ebj6Z0GJTTFf1Rhm7Wzx3oO3Qx1BBo//GOouIcW+A8u O50yZorojILT/RlDB8I4MfeTDnubo6r5qO/LRBlUHDUhXwEV/XcolkzVcdAbMarB1D5s 7M7pqdU2HNNKGN7OhWFXGJhYeYe4bsq+MYn57/yRco3IKTRwxCqbzRrEuVlCZR6CJQQi VnXZVWzJFMTMsSioeZeU5YubTi/seKIW9yst7FFeP3CrAuEwXk0MEcDhkn5hOuyr0dHn IrpQ== X-Gm-Message-State: AOAM532doG7CK3oRbmPA1EDfzOkVsbLyBSx4qu1NptfTr7Ld7E+b586t oCdmE8sKOqqQd/v7g0l0XUc= X-Received: by 2002:ad4:4d03:: with SMTP id l3mr21657230qvl.158.1590513823004; Tue, 26 May 2020 10:23:43 -0700 (PDT) Received: from localhost ([2620:10d:c091:480::1:85c0]) by smtp.gmail.com with ESMTPSA id d56sm277843qtb.54.2020.05.26.10.23.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 May 2020 10:23:42 -0700 (PDT) Date: Tue, 26 May 2020 13:23:40 -0400 From: Tejun Heo To: Wu Bo Cc: axboe@kernel.dk, cgroups@vger.kernel.org, linux-block@vger.kernel.org, Markus.Elfring@web.de, linux-kernel@vger.kernel.org, liuzhiqiang26@huawei.com, linfeilong@huawei.com Subject: Re: [PATCH] blkcg:Fix memory leaks in blkg_conf_prep() Message-ID: <20200526172340.GD83516@mtj.thefacebook.com> References: <1589805366-328489-1-git-send-email-wubo40@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1589805366-328489-1-git-send-email-wubo40@huawei.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, May 18, 2020 at 08:36:06PM +0800, Wu Bo wrote: > From: Wu Bo > > If a call of the function blkg_lookup_check() failed, > we should be release the previously allocated block group > before jumping to the lable 'fail_unlock' in the implementation of > the function blkg_conf_prep(). > > Suggested-by: Markus Elfring > Signed-off-by: Wu Bo Acked-by: Tejun Heo Thanks. -- tejun