Received: by 2002:a25:ef43:0:0:0:0:0 with SMTP id w3csp76937ybm; Tue, 26 May 2020 11:09:46 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyqG2rmySnxdxxKgWtlZ+CDzv0OzfplOyAq57qI1KuauJZtS6RUTEOI6forWuIjH/jTgauf X-Received: by 2002:a17:906:7c4e:: with SMTP id g14mr2300086ejp.353.1590516586224; Tue, 26 May 2020 11:09:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1590516586; cv=none; d=google.com; s=arc-20160816; b=QxYmQCBAZXcWyO+ARfE15cE9SYl723piun82SyDvscbUh8WGO8B8HM2+HuUNO1z3iu MfjbCGnxWW2f2REKp2lz6HVDl+KJw7pk5pwKl59Ay9aL0O8fkjcCbsMVKQFIfWQ++j1t 9XZqbZiKCLdmpi4pV2OOKA5M/OmZRXfS4iIHKjrz1LdL/0fmlYm1PYnZABcPL8fbLINA R9iN+MsIedU+oMgDX7kqKFToyEuSOulZnaie1UWrcjLfI1UZGhuz3IckpzwqoLIPICFT F9is78JRhy/1GBtJedrXobdiOxyxeUGnPmlpXnbx3qc871GTaFu4+LWHS2xUFhusvA2h VAKQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:to:subject:dkim-signature; bh=xN18P3pXk9ov3jRcuqdGEQKpjL9tqNKMSa/qU3w2Kps=; b=Tr4x518Rtp8EC9sBatDEpqZeheh9AwFZnAxjPSTARvNXub8NbFgZtATq+EB4afTL2e YwdZhf/CYU3GTjuhHstZrF+sb9aCMU383qDU5123PiHPTYo6G9BbeoC2a5Sj62WO/85a uFy5lSPsv3WQzkfot3ujxMy15Dr4EKYu3gXSue2EXOsZhHRY2kE1O/3/3G+d4T/wlm1I K7Q1VpPaZyCiC2M4LGTXKMbyvupizqO9HEJ8nnSHkzEko/nX+XvCoCK3Uw0w2TQN6NY0 oF0IIvX506U02QBf2FsOl/LgI5+Idb1G8fPK2Rxn3BjN6n7xhdFhWJJZKKvYO+mNDzNB bWIw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel-dk.20150623.gappssmtp.com header.s=20150623 header.b=ApLZTDpG; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id f19si314499edy.584.2020.05.26.11.09.23; Tue, 26 May 2020 11:09:46 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel-dk.20150623.gappssmtp.com header.s=20150623 header.b=ApLZTDpG; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729203AbgEZSET (ORCPT + 99 others); Tue, 26 May 2020 14:04:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52096 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727016AbgEZSES (ORCPT ); Tue, 26 May 2020 14:04:18 -0400 Received: from mail-pl1-x643.google.com (mail-pl1-x643.google.com [IPv6:2607:f8b0:4864:20::643]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 56CA5C03E96D for ; Tue, 26 May 2020 11:04:18 -0700 (PDT) Received: by mail-pl1-x643.google.com with SMTP id x10so8980590plr.4 for ; Tue, 26 May 2020 11:04:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20150623.gappssmtp.com; s=20150623; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=xN18P3pXk9ov3jRcuqdGEQKpjL9tqNKMSa/qU3w2Kps=; b=ApLZTDpGOEg4R7/2rp5QFVKZE7iFxMEbcqJkKDrxsOipoLnv9LrxngGBL3toqQwBS3 k/iOjFfSmW5BYbXuZ6S5t8TsDCHTJvle4RUy7BjbbJb19eiSdGpKrWztU5ReBkO7xVwd V0Z7R55BsYY9mIZ7kxZvncdiVbaYws8kC8HO2AtG6aC3qVoKsSSrzNkt8unBpMZgFFLd L4kRIVrQR/TJnfaFA2xxA4nDQLZNy+xbYk1noHXpDA+U+mKpG+kgPy446qZ45nl6bQW8 +YYdbwc+xPMQIBujm5KHqIwqrLTKlClQnbS3zrUDECg5x/2j0qN3xcl68JeGWqXcIlZU MwHg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=xN18P3pXk9ov3jRcuqdGEQKpjL9tqNKMSa/qU3w2Kps=; b=c0ZwTgZCnFtnoOfqPv98smMf6G6Gy64cz3OxFTAA67p2bZTN7bJhC2EMI3omL+CeMn ZYieiVlXaW+9jNEllc4Aq1L0DLlXC6CClTBpPErUmIe6UySQvOnujHOpr1GB8quL2a+h oF7+aiBFdMs6tuZNJU4L09uI9lPVxTXvPmbPVhvqTtERYJHOIlN/P2t3LMAUwSH4DhCp 57fTWZLtIISPiFhqSdf8j7p547tiBZI7dPTTY+gHHa8YkU0JP2bAt6+DfQSVlNN1xKaA YjU9sSU/Ru5vBEL/ITnXEkGhFFMN4d2fUy7pJxYBl02t/ofhx4XtwIje40SVEGdwc2lu qj8Q== X-Gm-Message-State: AOAM5328cMalZ0CfjlwClSVRwUu1oaJEo+/LEXDWnUevSRZRCpFvwi5+ igVBKBFtl+Dp2OIT/q/kGIzWuWAg0ZTekg== X-Received: by 2002:a17:90a:4b47:: with SMTP id o7mr389452pjl.205.1590516257560; Tue, 26 May 2020 11:04:17 -0700 (PDT) Received: from ?IPv6:2600:380:495a:792b:6476:7a3a:9257:12c7? ([2600:380:495a:792b:6476:7a3a:9257:12c7]) by smtp.gmail.com with ESMTPSA id u14sm196285pfc.87.2020.05.26.11.04.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 26 May 2020 11:04:17 -0700 (PDT) Subject: Re: [PATCH 1/6] io_uring: fix flush req->refs underflow To: Pavel Begunkov , io-uring@vger.kernel.org, linux-kernel@vger.kernel.org References: From: Jens Axboe Message-ID: <82761dbe-d0c6-c14d-0898-1bb324d38b9e@kernel.dk> Date: Tue, 26 May 2020 12:04:15 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 5/26/20 11:34 AM, Pavel Begunkov wrote: > In io_uring_cancel_files(), after refcount_sub_and_test() leaves 0 > req->refs, it calls io_put_req(), which would also put a ref. Call > io_free_req() instead. Needs a: Fixes: 2ca10259b418 ("io_uring: prune request from overflow list on flush") I added it. -- Jens Axboe