Received: by 2002:a25:ef43:0:0:0:0:0 with SMTP id w3csp107860ybm; Tue, 26 May 2020 12:00:05 -0700 (PDT) X-Google-Smtp-Source: ABdhPJygtfhFDfYBHxjJlAVQP9WfqGMLfjCB3l7ImUBXAZULzetLMsBPp6Ns60GefrtBxbOBVqAY X-Received: by 2002:a17:906:e0c5:: with SMTP id gl5mr2321476ejb.524.1590519605707; Tue, 26 May 2020 12:00:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1590519605; cv=none; d=google.com; s=arc-20160816; b=ii8SLjlwMU3ldLMUJuWVza/2wADu3vtLfnig4jWVB0ONw1ZeCDhqAOqAemICZuQ0Wu oXUvCn0YW84DD+PXNG5S6GRV6lZjOmB1C5qhSQASzr7DCcFuEMc0ABnebH0g3+yicxYL VMB/ZcNWRhrw9r2/QB/8yAjqfTtqwjCyNImnbF5ERvau58XC3A7TgBS437IuklIsKAP/ i3DKA+1mkqyCGkvNqnouVer3Sj7IkdcWtGkzOPn4Z/UpVfYW3/GjD02HXde5IA3bFnW8 1XGXrOC56SUJ8M2/ViAZkh6WQY1BTJa/XqDjoVz5XK89lFJMewFBz2a8qBhfo7Ez6cK9 5+0Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=Q1vy94jN+/0fWRGK8bneUQVlFC6EXmZBAP8ggDIp2xQ=; b=Ha5zX7TJDEl1r9UBYBKy/ou7wYz401d2r6ejtJJnTSpvNO3ywj9AX13v/rm3rm4ddi td8vMm9N2uk+Q6e96xksMYiGlOpK6loZKxVsRLYDgSlyftcDnvrgoORKjK5H43oQmTEO oU4sN77mTtBn16NH+bqUiDjPNLWaZ2qL19dbUiEJv1ileafs0fiAfSnqweVOyEP1DSF3 Vx14sKn9OeA5FrMrm1K3ZSuDMTtUAg7TfM4s8jn6DhKcK4Ig9ZTyBbhEK3/G/wr8hhdY iuaqSOn1BicEMYk8XaKmay/0ojN8JLY4wRaFL9q2GTPCX6t7wMo5C0bI+VZOopq/bw8c yZaQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=eSOLbiZR; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id k2si433646edh.454.2020.05.26.11.59.42; Tue, 26 May 2020 12:00:05 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=eSOLbiZR; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389206AbgEZS5H (ORCPT + 99 others); Tue, 26 May 2020 14:57:07 -0400 Received: from mail.kernel.org ([198.145.29.99]:50194 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2390011AbgEZS5D (ORCPT ); Tue, 26 May 2020 14:57:03 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id F1CA120849; Tue, 26 May 2020 18:57:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1590519423; bh=EdGQCx22tbM38b0Jb+wVTLYFKvjDqoUuGV5CoJixVO0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=eSOLbiZRQ6kepghAMVxHej2p3PL2n9pAtooTkyA7Yefnr8orQvkY/L4pr5h5qkpe2 8GVXVME58SVf7p+zff5oByIPMQf+gr2offDwKYvWsn29FPMLHU44f6h5U2mh+DfQPP zSIBMhRVuV4yYsmdOygFzZzyHkq7O0iEuEaPi67k= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Christophe JAILLET , Stable@vger.kernel.org, Jonathan Cameron , Sasha Levin Subject: [PATCH 4.4 64/65] iio: sca3000: Remove an erroneous get_device() Date: Tue, 26 May 2020 20:53:23 +0200 Message-Id: <20200526183929.129743752@linuxfoundation.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200526183905.988782958@linuxfoundation.org> References: <20200526183905.988782958@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Christophe JAILLET [ Upstream commit 928edefbc18cd8433f7df235c6e09a9306e7d580 ] This looks really unusual to have a 'get_device()' hidden in a 'dev_err()' call. Remove it. While at it add a missing \n at the end of the message. Fixes: 574fb258d636 ("Staging: IIO: VTI sca3000 series accelerometer driver (spi)") Signed-off-by: Christophe JAILLET Cc: Signed-off-by: Jonathan Cameron Signed-off-by: Sasha Levin --- drivers/staging/iio/accel/sca3000_ring.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/iio/accel/sca3000_ring.c b/drivers/staging/iio/accel/sca3000_ring.c index 20b878d35ea2..fc8b6f179ec6 100644 --- a/drivers/staging/iio/accel/sca3000_ring.c +++ b/drivers/staging/iio/accel/sca3000_ring.c @@ -56,7 +56,7 @@ static int sca3000_read_data(struct sca3000_state *st, st->tx[0] = SCA3000_READ_REG(reg_address_high); ret = spi_sync_transfer(st->us, xfer, ARRAY_SIZE(xfer)); if (ret) { - dev_err(get_device(&st->us->dev), "problem reading register"); + dev_err(&st->us->dev, "problem reading register"); goto error_free_rx; } -- 2.25.1