Received: by 2002:a25:ef43:0:0:0:0:0 with SMTP id w3csp110395ybm; Tue, 26 May 2020 12:03:15 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwqrQJu5EYxo9kOs7fhDvqqislqfFiYYLn4UmH1TSe+ggX7Od/mZhAL/tpElT+nsPv2ZBld X-Received: by 2002:a17:906:538d:: with SMTP id g13mr2359974ejo.194.1590519795305; Tue, 26 May 2020 12:03:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1590519795; cv=none; d=google.com; s=arc-20160816; b=HV14DqU0Q6oFEVSD8lOo3UgaHIGpwrDzmAZ6DHqkeslACourl7avW4dOzd3XXr6UwI JAVYiYLBSomFHyXEnvkVK+zfR0IQTNUFu6dIqxjLRdhlF8TpHe/obDi4p8ugDVAXRmMm Ep63v3o0c4GvqIjzloLrwLOnN91w2xs670Gli8qmNBUyXOCYqHlLxicvbInuhrE5gRVC y/jbviwlLbTfwFja9eNKQnem9X3WKsJZi//XjR7svE095+9MjSIU/+b4qwNNdwetvT/E Tl6yPXix90lOKVCuxM6fxSl6Ll1d4QYyhzpmwccizZDJHJfs8L+QuuD9UaHONocpA3z/ CgIw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=qMN4UnEFDwueAQ6mBhAPGPYDySwiLJZzd59BIA7gWLU=; b=fjp9YNQVwTgE4LnGyPVFDCIfoBcZYKzQ4qSAGbLHjoeVbkASZx0vwnqqouSXlbxVvM D3TOuqGMppLMz+lfonx8Tr0Ss2XHZw89T4N+/285tZbSSXjPYOyhrNdBVy77tW8Ddyo6 DXTBpsS6ciOyBSSQPH2M7psVDq9k2v7ara6HOZy5avvrNaanOwfPSFT5+ztvrU1gHfpf HiOD/xyFDyH3hdcsdOrxy8k8qs6ryJaWXKKDtwqoWeU7pYTEJLqa+1EarfsCdpiS5l2Y oCaVt7mCNYXJlk8H6DZVOlLD8mIKTzFxmsvi/FjVIYDQWvAIv2v+HkAUEXLetVdANkoA revg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="FzS/gNIF"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id x26si381694edv.448.2020.05.26.12.02.51; Tue, 26 May 2020 12:03:15 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="FzS/gNIF"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389990AbgEZS77 (ORCPT + 99 others); Tue, 26 May 2020 14:59:59 -0400 Received: from mail.kernel.org ([198.145.29.99]:53908 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389977AbgEZS74 (ORCPT ); Tue, 26 May 2020 14:59:56 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 59B3220849; Tue, 26 May 2020 18:59:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1590519595; bh=NebaGoNend4UooMfkkfS/aWjy97aPsiF5iAluBswIgI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=FzS/gNIFFTUI7nCISV3Ig91/4H1DA0yXd65z6YfRiBHNAhNvv+enMSK5/LzeBMxKN cgYiyviXi8VBdQ3QeziPMIoEG3zVIMExoHqiIFAUNHQ3CNUnPl5S94QDdPFrmvzhDO wVg9yCPWH0d/zKfdYnHbof6WKQqup7CmcqGNcUyY= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Christophe JAILLET , Stable@vger.kernel.org, Jonathan Cameron , Sasha Levin Subject: [PATCH 4.9 64/64] iio: sca3000: Remove an erroneous get_device() Date: Tue, 26 May 2020 20:53:33 +0200 Message-Id: <20200526183931.808755173@linuxfoundation.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200526183913.064413230@linuxfoundation.org> References: <20200526183913.064413230@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Christophe JAILLET [ Upstream commit 928edefbc18cd8433f7df235c6e09a9306e7d580 ] This looks really unusual to have a 'get_device()' hidden in a 'dev_err()' call. Remove it. While at it add a missing \n at the end of the message. Fixes: 574fb258d636 ("Staging: IIO: VTI sca3000 series accelerometer driver (spi)") Signed-off-by: Christophe JAILLET Cc: Signed-off-by: Jonathan Cameron Signed-off-by: Sasha Levin --- drivers/staging/iio/accel/sca3000_ring.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/iio/accel/sca3000_ring.c b/drivers/staging/iio/accel/sca3000_ring.c index d1cb9b9cf22b..391cbcc4ed77 100644 --- a/drivers/staging/iio/accel/sca3000_ring.c +++ b/drivers/staging/iio/accel/sca3000_ring.c @@ -56,7 +56,7 @@ static int sca3000_read_data(struct sca3000_state *st, st->tx[0] = SCA3000_READ_REG(reg_address_high); ret = spi_sync_transfer(st->us, xfer, ARRAY_SIZE(xfer)); if (ret) { - dev_err(get_device(&st->us->dev), "problem reading register"); + dev_err(&st->us->dev, "problem reading register"); goto error_free_rx; } -- 2.25.1