Received: by 2002:a25:ef43:0:0:0:0:0 with SMTP id w3csp116649ybm; Tue, 26 May 2020 12:11:19 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxYaWDDqH11ZeDHczGrdu7/yy416/d8+fD+5+c7JkaYG/x6LTzgk+baGmfRNVnvvaX3wXRl X-Received: by 2002:a17:906:8383:: with SMTP id p3mr2343152ejx.529.1590520279158; Tue, 26 May 2020 12:11:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1590520279; cv=none; d=google.com; s=arc-20160816; b=j9F/91j8/g+xQigkEz0T7QUYgXKvtTQI3xZJfWN7F2LEPg92lHoP7vOJ1AX3+5jQNI bdQszq2JAmk+NvYwxoWYUyr7+H/vxZo3jUfHG3+NUIyT/ni2kmaL96B7YlkYoqR1wcYv AGZFPfI21VmbhZK3LXCRwfDKc0X89h3aSxrpNq5ZkoYbJgQvXrt0rvYpo0feD2Dd2njl 0lft7jQTYZ8MoS5AlIC+gx3qkJ0GoOQ1xsBlTdPtaYBkxmNGEf7/2iKkdFNb9wxbwx8X jALoujlmlkr7C4H7l9Z9cC/rS8NhTi4jZ/H0IQGCxnvf5m71qRYURxrdje4Xkre95BMM Hu+w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=Q1UpIawC/nBX/FfDLl+h+9qmz4DWKkRexBr2UEc5REc=; b=v2tP3a56owHSws1hY3rYjIFu4ELNkvSIxyACQv3Ai8Iw2x3ZXjhyojIN6WdGjgUTP1 IRbXtz6yZA3CPQ06pp5O6PLb2/+ePViT0Cfglk5XNvyOVSZTZMtsOCU797RELEd/3YpG /gZFIc964V5fNTFCL6rjb5TwyQTimxxKA0HiRH2efeB1J3NrZHeFjnwYRbL3smKzZy9n I7aEswVwIbBtYGVbGJ12LCHkTbt7caawsVFG255Z4Q37l3g/x0ybQtygwz7qk1i38/yb xELM/tFW4LXaArd0WprUTFmzgJXJjtoOCXPyiNv8VpNKHWsB8Sz3oJO0ANOXIeNcwk1g q72A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=wl7Zbc8G; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id j93si435299edd.458.2020.05.26.12.10.55; Tue, 26 May 2020 12:11:19 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=wl7Zbc8G; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2403870AbgEZTGJ (ORCPT + 99 others); Tue, 26 May 2020 15:06:09 -0400 Received: from mail.kernel.org ([198.145.29.99]:34030 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2391092AbgEZTF7 (ORCPT ); Tue, 26 May 2020 15:05:59 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 0B90F20776; Tue, 26 May 2020 19:05:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1590519958; bh=mRxvmJxdQSgll9Gs2py6a241v8LCbk3tjj+w8cKD8rg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=wl7Zbc8GKW06z3RUXeRFZgx9HB+RSwlxM3FShJlwBmgbihYhjI/3uAhfUZTHtwxZu TuGoSBy5cLL7x9VIXLETzJG9SiR83Sg2o8sQtes91ysUczkn4iu/JQX9l/qck7VpFL gdE9GhBt2VAacDbnbMUZ/GwwRL215Vy1FcYHjDCM= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Doug Berger , Florian Fainelli , "David S. Miller" , Sasha Levin Subject: [PATCH 4.19 58/81] net: bcmgenet: code movement Date: Tue, 26 May 2020 20:53:33 +0200 Message-Id: <20200526183933.528845980@linuxfoundation.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200526183923.108515292@linuxfoundation.org> References: <20200526183923.108515292@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Doug Berger [ Upstream commit a94cbf03eb514d4d64d8c4f4caa0616b7ce5040a ] This commit switches the order of bcmgenet_suspend and bcmgenet_resume in the file to prevent the need for a forward declaration in the next commit and to make the review of that commit easier. Signed-off-by: Doug Berger Reviewed-by: Florian Fainelli Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- .../net/ethernet/broadcom/genet/bcmgenet.c | 60 +++++++++---------- 1 file changed, 30 insertions(+), 30 deletions(-) diff --git a/drivers/net/ethernet/broadcom/genet/bcmgenet.c b/drivers/net/ethernet/broadcom/genet/bcmgenet.c index 89cc146d2c5c..60abf9fab810 100644 --- a/drivers/net/ethernet/broadcom/genet/bcmgenet.c +++ b/drivers/net/ethernet/broadcom/genet/bcmgenet.c @@ -3616,36 +3616,6 @@ static int bcmgenet_remove(struct platform_device *pdev) } #ifdef CONFIG_PM_SLEEP -static int bcmgenet_suspend(struct device *d) -{ - struct net_device *dev = dev_get_drvdata(d); - struct bcmgenet_priv *priv = netdev_priv(dev); - int ret = 0; - - if (!netif_running(dev)) - return 0; - - netif_device_detach(dev); - - bcmgenet_netif_stop(dev); - - if (!device_may_wakeup(d)) - phy_suspend(dev->phydev); - - /* Prepare the device for Wake-on-LAN and switch to the slow clock */ - if (device_may_wakeup(d) && priv->wolopts) { - ret = bcmgenet_power_down(priv, GENET_POWER_WOL_MAGIC); - clk_prepare_enable(priv->clk_wol); - } else if (priv->internal_phy) { - ret = bcmgenet_power_down(priv, GENET_POWER_PASSIVE); - } - - /* Turn off the clocks */ - clk_disable_unprepare(priv->clk); - - return ret; -} - static int bcmgenet_resume(struct device *d) { struct net_device *dev = dev_get_drvdata(d); @@ -3724,6 +3694,36 @@ static int bcmgenet_resume(struct device *d) clk_disable_unprepare(priv->clk); return ret; } + +static int bcmgenet_suspend(struct device *d) +{ + struct net_device *dev = dev_get_drvdata(d); + struct bcmgenet_priv *priv = netdev_priv(dev); + int ret = 0; + + if (!netif_running(dev)) + return 0; + + netif_device_detach(dev); + + bcmgenet_netif_stop(dev); + + if (!device_may_wakeup(d)) + phy_suspend(dev->phydev); + + /* Prepare the device for Wake-on-LAN and switch to the slow clock */ + if (device_may_wakeup(d) && priv->wolopts) { + ret = bcmgenet_power_down(priv, GENET_POWER_WOL_MAGIC); + clk_prepare_enable(priv->clk_wol); + } else if (priv->internal_phy) { + ret = bcmgenet_power_down(priv, GENET_POWER_PASSIVE); + } + + /* Turn off the clocks */ + clk_disable_unprepare(priv->clk); + + return ret; +} #endif /* CONFIG_PM_SLEEP */ static SIMPLE_DEV_PM_OPS(bcmgenet_pm_ops, bcmgenet_suspend, bcmgenet_resume); -- 2.25.1