Received: by 2002:a25:ef43:0:0:0:0:0 with SMTP id w3csp130641ybm; Tue, 26 May 2020 12:32:21 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzvPMjnl+i6jkmPexERj8uIysM3ChVB+hFlskD6Vygz9KMTKp3coSVTaTE1DAEw4VScDYhD X-Received: by 2002:a05:6402:555:: with SMTP id i21mr20770767edx.119.1590521541388; Tue, 26 May 2020 12:32:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1590521541; cv=none; d=google.com; s=arc-20160816; b=zHvhUagH5kx1SwAhKDp/Dqw3BXX46cwoDM3GeK3WqIN5g//KUXPs1FHMheI/BOnvGa LPrjNF0cfskU7uDySR1QKbNMeQPh1vYBrRd+tm0EJIsElv50PYOdc+WnNVSTArKkvFjP EYwwY3Lge1rkevD6X8sGwHmE8WP7+OpQAtqlqIsSVV+8EK/3CvgZ8ieXW4BVnl/V+FW/ Lgs9tiqehritrRtdVmS6rCn/N8fZOUr0vUGhuc6z3zCEUMjqwJ88yK3NXN5Hm07RcBFH Q227aIQMhnT4yg5fb+8lMh03DYvRbprrQ9XtL9sieUm27PgeS/q0mrcOukRvUrMbNz9V 4weQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=e9B/9QX084QTF6As/Hp9e9Do5L/dNuwXYWCdnVsIp+U=; b=EdoqB54aeQWA0JHJ7/Lg5eeQRuM/Sn8JTefwmc/WUoIxQUGonqx9xN5OgMMgAK2Wvy r1+Y+Nz4KS2YpUvVEIfZoe2Uc3d+2HVUVL/DYAfG6DQXZWFnWA8hOKkpj6Ug/atxmevK gJMO7TzZxFVgGh+Ee078RB/UtxDD1lWRw5J4earCiqsPRDcfkXLxV6gMUBAdx+QiOSB+ xkpYuMcPrZaSadbYp/tlqPUW7RizM4cxuZiOcWxqA213RSr2gV8IRhQ445P6QgorBjzG W3WVnGvNcZnUDDD+zuDEu+ufBj9a0HzDW8iRGz4FJ0LHta0AZvRMnLBgX7CMxJa8oDu9 EBJw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=YQYWI2bB; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id j1si401299ejy.734.2020.05.26.12.31.57; Tue, 26 May 2020 12:32:21 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=YQYWI2bB; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2391041AbgEZTCJ (ORCPT + 99 others); Tue, 26 May 2020 15:02:09 -0400 Received: from mail.kernel.org ([198.145.29.99]:56764 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2391036AbgEZTCH (ORCPT ); Tue, 26 May 2020 15:02:07 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 2C4492086A; Tue, 26 May 2020 19:02:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1590519726; bh=Ll3i88I6dH+M1vcXVswOh7ONTIPk/HSwLa9ixcVzbH0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=YQYWI2bBoseELmkKgvSXn/1a/a/KV71/BncWCt7Twx/mVgS00Yaz3jpkSYXYzD57t 7Q30iZaEh4Zuii65dad5IEGVq/WhWNhcV1CwRyclT5AVJ3uk/agyzmBEg0Ba2vlAy5 PacRVNNX3i5O/ff1KlK2n6iPVYX4X3XBrJ7U1fck= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Christophe JAILLET , Stable@vger.kernel.org, Jonathan Cameron Subject: [PATCH 4.14 52/59] iio: sca3000: Remove an erroneous get_device() Date: Tue, 26 May 2020 20:53:37 +0200 Message-Id: <20200526183923.000245316@linuxfoundation.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200526183907.123822792@linuxfoundation.org> References: <20200526183907.123822792@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Christophe JAILLET commit 928edefbc18cd8433f7df235c6e09a9306e7d580 upstream. This looks really unusual to have a 'get_device()' hidden in a 'dev_err()' call. Remove it. While at it add a missing \n at the end of the message. Fixes: 574fb258d636 ("Staging: IIO: VTI sca3000 series accelerometer driver (spi)") Signed-off-by: Christophe JAILLET Cc: Signed-off-by: Jonathan Cameron Signed-off-by: Greg Kroah-Hartman --- drivers/iio/accel/sca3000.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/iio/accel/sca3000.c +++ b/drivers/iio/accel/sca3000.c @@ -982,7 +982,7 @@ static int sca3000_read_data(struct sca3 st->tx[0] = SCA3000_READ_REG(reg_address_high); ret = spi_sync_transfer(st->us, xfer, ARRAY_SIZE(xfer)); if (ret) { - dev_err(get_device(&st->us->dev), "problem reading register"); + dev_err(&st->us->dev, "problem reading register\n"); return ret; }