Received: by 2002:a25:ef43:0:0:0:0:0 with SMTP id w3csp131786ybm; Tue, 26 May 2020 12:33:53 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwYI98xoqLnnyeF5WrpDwPN4x8DW31V6zdC2SaJ2fUdd2DDfX5XZVc7VckH7XNbbtkp+FgO X-Received: by 2002:a17:906:49c7:: with SMTP id w7mr2643253ejv.402.1590521632982; Tue, 26 May 2020 12:33:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1590521632; cv=none; d=google.com; s=arc-20160816; b=KGoHhDB3w5BmbJ/slpECbfoQz2FQfPTbRXOLJEpjbo6eWFdz8vCOZ2aum2Y4pgyY9C m/repKdSl/ehKzPg/p9fYzeERpUddthW7DGiaTQ8pCGNk650hUlJ3jisQHfVxJJyJtW3 3LAE6wLSyRxCsyztoBoOSpKI1Pd0w1PSaBPUWln/6Fc2YsaJOZY99PsldJNh1Q9Uj0GR I69NP4nk9FcUkV7urE/Q5szZ9k6ZT4+JEoHWsDdtnee0QwJ5qT8xqKoJFTdhjzZCofn/ /t6t+SUAJDQ8uDDsOyXijpvhKpMmVJwjflsXHWGiu9xSKxNRwQvgN136DkSq8H/5/bcG NFVg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=Y3XObm13X5ueiOLqFflTAorSIhtOgZJRQyFslOL+k7Q=; b=SURkBWNxLkoRYV5xfMpgJTs6mLTt25ETKPKDeMBAi9agZMJNoLaGKfKFzUcXLJTpd8 IEYtoYJBdACG5tyH0eVWhmS8ZjPnFiA8/GSQdoO4bvrrd0NIN7K+Zch7nkah8WRvSIy/ njd233T1gtVJYlXVAvmYdvL5G0ZQoGTW9GBsy7Lhcms3eXTRyKAQhz9DQxUTeDgLdX/P fEoiNefHZ7q1xCMNsxbN8X1N2Vyw5uJYD93w6i98yDNfV8m3HqGktBoh7OzlwFANpHiN vQkOEquhpyZet8hbnokLuIXprl8YDmdxmTDy5AUfgLqW0b8aoJbkexaZnLzC35KVCYG5 QaPg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=a3SpKxXT; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id r8si504946edi.84.2020.05.26.12.33.29; Tue, 26 May 2020 12:33:52 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=a3SpKxXT; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2391095AbgEZTC1 (ORCPT + 99 others); Tue, 26 May 2020 15:02:27 -0400 Received: from mail.kernel.org ([198.145.29.99]:57188 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2390269AbgEZTCZ (ORCPT ); Tue, 26 May 2020 15:02:25 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 275F420849; Tue, 26 May 2020 19:02:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1590519744; bh=H63YJtgJZbKb64vMUxzAPQwIpPLNoz1QOyiyGbsojyM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=a3SpKxXT3UYhD1YAJO6bSCvnIcqqhsV9MG5E3FFRwXnC/TAQhd64QU2SZqIAk9goY pRCZ2x7T54urCI2lvRWoReq5fV282BU4abc4Wc5PrJU5wxVz4Wy2DRuydkDbzBIBgy rI9CT4fTRjOIglyM9Xb9R3gXjlTyhFAHeJJ4c36M= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Peter Ujfalusi , Fabrice Gasnier , Jonathan Cameron , Sasha Levin Subject: [PATCH 4.14 58/59] iio: adc: stm32-adc: Use dma_request_chan() instead dma_request_slave_channel() Date: Tue, 26 May 2020 20:53:43 +0200 Message-Id: <20200526183924.580101506@linuxfoundation.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200526183907.123822792@linuxfoundation.org> References: <20200526183907.123822792@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Peter Ujfalusi [ Upstream commit 735404b846dffcb320264f62b76e6f70012214dd ] dma_request_slave_channel() is a wrapper on top of dma_request_chan() eating up the error code. By using dma_request_chan() directly the driver can support deferred probing against DMA. Signed-off-by: Peter Ujfalusi Acked-by: Fabrice Gasnier Signed-off-by: Jonathan Cameron Signed-off-by: Sasha Levin --- drivers/iio/adc/stm32-adc.c | 16 ++++++++++++++-- 1 file changed, 14 insertions(+), 2 deletions(-) diff --git a/drivers/iio/adc/stm32-adc.c b/drivers/iio/adc/stm32-adc.c index 3cfb2d4b2441..9a243f06389d 100644 --- a/drivers/iio/adc/stm32-adc.c +++ b/drivers/iio/adc/stm32-adc.c @@ -1633,9 +1633,21 @@ static int stm32_adc_dma_request(struct iio_dev *indio_dev) struct dma_slave_config config; int ret; - adc->dma_chan = dma_request_slave_channel(&indio_dev->dev, "rx"); - if (!adc->dma_chan) + adc->dma_chan = dma_request_chan(&indio_dev->dev, "rx"); + if (IS_ERR(adc->dma_chan)) { + ret = PTR_ERR(adc->dma_chan); + if (ret != -ENODEV) { + if (ret != -EPROBE_DEFER) + dev_err(&indio_dev->dev, + "DMA channel request failed with %d\n", + ret); + return ret; + } + + /* DMA is optional: fall back to IRQ mode */ + adc->dma_chan = NULL; return 0; + } adc->rx_buf = dma_alloc_coherent(adc->dma_chan->device->dev, STM32_DMA_BUFFER_SIZE, -- 2.25.1