Received: by 2002:a25:ef43:0:0:0:0:0 with SMTP id w3csp311349ybm; Tue, 26 May 2020 17:53:00 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw0ODSHU1yBvorPWak4DhC1zbyc7DjGOv6tpVU6jxCr94KiOaQ0jJ7H8IZXRDgOZP8/ZWEq X-Received: by 2002:a50:eb84:: with SMTP id y4mr21441610edr.374.1590540780004; Tue, 26 May 2020 17:53:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1590540779; cv=none; d=google.com; s=arc-20160816; b=0loS3NkyWFsdS9Kf/mzzyoTJdfyEkt83VemrdUeEVSwwcbpCDo0w8ger5PBiL2A9b0 cuJgHo+Rs2FzHoIkJDCcvd8DgHgKaUP2KBjxp/7F6oRaxpi147nCe/KAYrZdcMbvkzui YDDRlgzZ6uYGLjZ1eL4pcIXXSU6QgGIg1vyAcNi37NoS3T4hcGDXKD6jpmK/Zk0lEjAa 7J0nxuYVcfg3h+Hgu2DAb2mXFyDFhbjJEboJfLAf0Wtc9qKZeGVhp9lZ7Px4//TeQiLm PTlA2uYDka4mnXlJ/HNLWF4AcglR+GGJzseZ0rC6Bq97vUSAAC5uZwozl8hJkZiG38bA 12RQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=s0S43q7HstPYdmpVS81FsBCWXwXLzBoHznpcLL8i7eI=; b=lu1UjWi0MZZ1IIR2Gdo1l71IUSJXZVkKndByMmSj/+ifipmz58dK3mLR+Ss6M3lAsn gfnFa5mKNqn/ZxsWdwEYOYS0tYoUbpp5WdIfBM+RYJO/i+Fl3d+YCwOrcM1hBptnOMa6 jQxIs+qJCE/9k2u14apL5MmtftiKpDlcaLBcS16adCKE1noR8yaV5T5QOAT1Nw08K1Hq Dio1J+pnyLJBuHkrXIDk/0ErX7LowYYu3CtScLIiWj4lQt15Hg+7i0h/aV/3y6rAojJb bSDeiWTI9iCOat9c+BNSQW+luqrC4xfRu2hiqpYIG8jGgIaKUy4NMt1taIkvtqnIxOyR 7ZCA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=klTqCpIw; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id jo20si853848ejb.456.2020.05.26.17.52.37; Tue, 26 May 2020 17:52:59 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=klTqCpIw; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390833AbgEZVQE (ORCPT + 99 others); Tue, 26 May 2020 17:16:04 -0400 Received: from mail.kernel.org ([198.145.29.99]:36038 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2390435AbgEZVQD (ORCPT ); Tue, 26 May 2020 17:16:03 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id EF77320888; Tue, 26 May 2020 21:16:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1590527763; bh=kLV44yBWHPoT0T+3cEG/J3rOYNiGRyHwi2HVP15oYao=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=klTqCpIwX3VLtGCp+OKNHF5EJGtoR7u+BnCQZyqhMKg1pD2WdGe7Arsy0LNRzPTR8 2t+aVgefOfClQUZlWeh1dbWJHDiW7Lv8SRraHL9UeCMZdFHGA7dVNVllMpCBRlktuo Pj8Kv7kflWg2arOlWVVYfLSSUHbVGaReUkfUYsLo= Date: Tue, 26 May 2020 23:16:01 +0200 From: Greg KH To: Kees Cook Cc: Andi Kleen , x86@kernel.org, linux-kernel@vger.kernel.org, sashal@kernel.org, Andi Kleen , stable@vger.kernel.org Subject: Re: [PATCH v1] x86: Pin cr4 FSGSBASE Message-ID: <20200526211601.GA166522@kroah.com> References: <20200526052848.605423-1-andi@firstfloor.org> <20200526065618.GC2580410@kroah.com> <202005260912.8867B3AA@keescook> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <202005260912.8867B3AA@keescook> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 26, 2020 at 09:15:04AM -0700, Kees Cook wrote: > On Tue, May 26, 2020 at 08:56:18AM +0200, Greg KH wrote: > > What about those systems that panic-on-warn? > > This is (modulo the general discussion about whether it's the right > way to check) the correct use for WARN*(). It's an undesirable system > state; people choosing panic-on-warn want this: > https://www.kernel.org/doc/html/latest/process/deprecated.html#bug-and-bug-on Ok, tha's good to know, thanks for that. greg k-h