Received: by 2002:a25:ef43:0:0:0:0:0 with SMTP id w3csp426133ybm; Tue, 26 May 2020 21:53:37 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxaj3D4COANx/QpKab46kGItl3LFK5mKGmzyG30mMB1eVhIv5DUvtBmFFdUhNQcn+zUt9oo X-Received: by 2002:a17:906:9707:: with SMTP id k7mr2286002ejx.18.1590555217065; Tue, 26 May 2020 21:53:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1590555217; cv=none; d=google.com; s=arc-20160816; b=cXvmJCbb3vPEdZdu6JvnfwSOiCwJOl5zjlHBeeLMHS49VnZvGYWL519NewGzsQbr0M hY5ArJLh26B+srScZ+ASdbwSUuPV+Bg2HkdVDkkMXjJs3O18AtWSM0gO1OjzdSFdDsaX +wX67s+nuGHSIKll9N7vNCJdsrNuDYI9bWL6sGvMgtYLuqZbm+iG7yofSnhc5B8ei367 kzGQau2HfZJnAKMJp66OgAXdHdS9JXJEd2i4YCbD66nNlcQ7PyNHWlXoHdheS6sCfNYt rdUk3L9W9a5B34CVuV+mlGCtXXbwMMKMDMKeSOkqiOKCbKKnMOnhGVAOfaBbySl9tc5w OLBw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:cc:to:subject :message-id:date:from:in-reply-to:references:mime-version :dkim-signature; bh=xMXuJZJPA1nykg1fNqTt3mwyZ9do6rxURzLcPjc+9T0=; b=SZhwgB+I/5OFREEDt8DxQxOLeGSrYbk8/9eRWqGCxIUVkEad1mgtt/m//bY5ZjqV0m fzEwW1JJ0MH/7cNzv7gqGL9AyB9LW2gDc5N/7lalCO4qGmv8cUPQq1iWObMqguDp+SXk rteG191d04vdNfPkOymOMSgzfDFp1oAGWnExo9sF04n10EfH6V1yqjV0+TnuUsjWGMw0 gx4qJX2b3wBcrgUiwzamyPJuAInRi6XNUKpHssY/tKmGiAeKqouOr/sw9DW0sMHxNn+z pfokayZuHFZiQrWorwnzAljMQnpz5qD+ABIkWM9+CJHZ+Y9AnwkjPfwQMM5BBP9bV1Nx E3CQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b="Y0+/Z+8D"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id m5si1150584eds.245.2020.05.26.21.53.14; Tue, 26 May 2020 21:53:37 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b="Y0+/Z+8D"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726862AbgE0BsQ (ORCPT + 99 others); Tue, 26 May 2020 21:48:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39698 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726482AbgE0BsP (ORCPT ); Tue, 26 May 2020 21:48:15 -0400 Received: from mail-io1-xd43.google.com (mail-io1-xd43.google.com [IPv6:2607:f8b0:4864:20::d43]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3CAD2C061A0F for ; Tue, 26 May 2020 18:48:14 -0700 (PDT) Received: by mail-io1-xd43.google.com with SMTP id y18so3810620iow.3 for ; Tue, 26 May 2020 18:48:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=xMXuJZJPA1nykg1fNqTt3mwyZ9do6rxURzLcPjc+9T0=; b=Y0+/Z+8DiODEuPrlapJckt/3NJ9USA50m58imiH2IET7NKwUbYLvZu4mMeyd4kUSYo +HhXuGMI1IAF1Fy9U6P7vhsNyu0ZbYzWCvOaCxbwJNgbPI2KrNNWpo20xmkDhzGOVdRW 6EfyGW+Jj/gXzF64pnnTZC0ycsiR653L0sFzBJEgOIu0iUMKSWlKoJWy2dQciYHtsg6w h5MVe9A6R3mS5UJ82AirHeh6B1ME5ZRmYsRPzQ4TgXV5hBcfNKNl/4ldRKqsFumuLzrq oeGWNmnGX1bozwIeVTpY+PcMEUausZxJxDduIoU4wzn56/RKhsfTRTjIE9vLD9AoupL/ LNng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=xMXuJZJPA1nykg1fNqTt3mwyZ9do6rxURzLcPjc+9T0=; b=hZqhTWbHD3fnTIog81IPIVSTCWMym/iGozbpMq3hlOb69GsrdYAfIOZY+lqwvzR2o4 lm2rrNsvWxJUIjJRqjm5RkxxBtDtzRMF6Ft6tw28tI2R2d+QGMttu0Flf8AP7vbK16rM 0NalYQ1lpXkoD2lll2pk1EYHWRJ7MR+wXscyizXk3hgM9W1NPkY/k1mGjlKTWEIUx1LR bihSHbyfA0AQUs2X7+UjcmS2p2CzMyV2yrlV19TM6w7bFNJI4cmeeFHVX6YaNQno+Clz uChtyD4j3W7h/QFRWmqkHheZ50LwkWyeWFxlXlgmzqIotf1bXs5vaVFCt6o8wXz44k4e XT7Q== X-Gm-Message-State: AOAM530c90kLA210SOCY/9mQCjMh9JHvK1sKoQb5NMfxUY/T55Wm8Ynq ejeIp7BgK+PuXHsW0MzxSR17Y20kzzRk51ouIT8= X-Received: by 2002:a5e:aa14:: with SMTP id s20mr7181824ioe.58.1590544091951; Tue, 26 May 2020 18:48:11 -0700 (PDT) MIME-Version: 1.0 References: <1587641093-25441-1-git-send-email-gene.chen.richtek@gmail.com> In-Reply-To: <1587641093-25441-1-git-send-email-gene.chen.richtek@gmail.com> From: Gene Chen Date: Wed, 27 May 2020 09:47:59 +0800 Message-ID: Subject: Re: [PATCH v9] mfd: mt6360: add pmic mt6360 driver To: Lee Jones , matthias.bgg@gmail.com Cc: linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, Gene Chen , Wilma.Wu@mediatek.com, shufan_lee@richtek.com, cy_huang@richtek.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Gene Chen =E6=96=BC 2020=E5=B9=B44=E6=9C=8823= =E6=97=A5 =E9=80=B1=E5=9B=9B =E4=B8=8B=E5=8D=887:25=E5=AF=AB=E9=81=93=EF=BC= =9A > > Add mfd driver for mt6360 pmic chip include > Battery Charger/USB_PD/Flash LED/RGB LED/LDO/Buck > > Signed-off-by: Gene Chen > Acked-for-MFD-by: Lee Jones > --- > drivers/mfd/Kconfig | 12 ++ > drivers/mfd/Makefile | 1 + > drivers/mfd/mt6360-core.c | 425 +++++++++++++++++++++++++++++++++++++++= ++++++ > include/linux/mfd/mt6360.h | 240 +++++++++++++++++++++++++ > 4 files changed, 678 insertions(+) > create mode 100644 drivers/mfd/mt6360-core.c > create mode 100644 include/linux/mfd/mt6360.h > > changelogs between v1 & v2 > - include missing header file > > changelogs between v2 & v3 > - add changelogs > > changelogs between v3 & v4 > - fix Kconfig description > - replace mt6360_pmu_info with mt6360_pmu_data > - replace probe with probe_new > - remove unnecessary irq_chip variable > - remove annotation > - replace MT6360_MFD_CELL with OF_MFD_CELL > > changelogs between v4 & v5 > - remove unnecessary parse dt function > - use devm_i2c_new_dummy_device > - add base-commit message > > changelogs between v5 & v6 > - review return value > - remove i2c id_table > - use GPL license v2 > > changelogs between v6 & v7 > - add author description > - replace MT6360_REGMAP_IRQ_REG by REGMAP_IRQ_REG_LINE > - remove mt6360-private.h > > changelogs between v7 & v8 > - fix kbuild auto reboot by include interrupt header > > changelogs between v8 & v9 > - fix GPL license out of date > - add commit message about Acked-for-MFD-by > > diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig > index 2b20329..0f8c341 100644 > --- a/drivers/mfd/Kconfig > +++ b/drivers/mfd/Kconfig > @@ -857,6 +857,18 @@ config MFD_MAX8998 > additional drivers must be enabled in order to use the function= ality > of the device. > > +config MFD_MT6360 > + tristate "Mediatek MT6360 SubPMIC" > + select MFD_CORE > + select REGMAP_I2C > + select REGMAP_IRQ > + depends on I2C > + help > + Say Y here to enable MT6360 PMU/PMIC/LDO functional support. > + PMU part includes Charger, Flashlight, RGB LED > + PMIC part includes 2-channel BUCKs and 2-channel LDOs > + LDO part includes 4-channel LDOs > + > config MFD_MT6397 > tristate "MediaTek MT6397 PMIC Support" > select MFD_CORE > diff --git a/drivers/mfd/Makefile b/drivers/mfd/Makefile > index b83f172..8c35816 100644 > --- a/drivers/mfd/Makefile > +++ b/drivers/mfd/Makefile > @@ -238,6 +238,7 @@ obj-$(CONFIG_INTEL_SOC_PMIC) +=3D intel-soc-pm= ic.o > obj-$(CONFIG_INTEL_SOC_PMIC_BXTWC) +=3D intel_soc_pmic_bxtwc.o > obj-$(CONFIG_INTEL_SOC_PMIC_CHTWC) +=3D intel_soc_pmic_chtwc.o > obj-$(CONFIG_INTEL_SOC_PMIC_CHTDC_TI) +=3D intel_soc_pmic_chtdc_ti.o > +obj-$(CONFIG_MFD_MT6360) +=3D mt6360-core.o > mt6397-objs :=3D mt6397-core.o mt6397-irq.o > obj-$(CONFIG_MFD_MT6397) +=3D mt6397.o > obj-$(CONFIG_INTEL_SOC_PMIC_MRFLD) +=3D intel_soc_pmic_mrfld.o > diff --git a/drivers/mfd/mt6360-core.c b/drivers/mfd/mt6360-core.c > new file mode 100644 > index 0000000..9bb63e0 > --- /dev/null > +++ b/drivers/mfd/mt6360-core.c > @@ -0,0 +1,425 @@ > +// SPDX-License-Identifier: GPL-2.0 > +/* > + * Copyright (c) 2020 MediaTek Inc. > + * > + * Author: Gene Chen > + */ > + > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > + > +#include > + > +/* reg 0 -> 0 ~ 7 */ > +#define MT6360_CHG_TREG_EVT (4) > +#define MT6360_CHG_AICR_EVT (5) > +#define MT6360_CHG_MIVR_EVT (6) > +#define MT6360_PWR_RDY_EVT (7) > +/* REG 1 -> 8 ~ 15 */ > +#define MT6360_CHG_BATSYSUV_EVT (9) > +#define MT6360_FLED_CHG_VINOVP_EVT (11) > +#define MT6360_CHG_VSYSUV_EVT (12) > +#define MT6360_CHG_VSYSOV_EVT (13) > +#define MT6360_CHG_VBATOV_EVT (14) > +#define MT6360_CHG_VBUSOV_EVT (15) > +/* REG 2 -> 16 ~ 23 */ > +/* REG 3 -> 24 ~ 31 */ > +#define MT6360_WD_PMU_DET (25) > +#define MT6360_WD_PMU_DONE (26) > +#define MT6360_CHG_TMRI (27) > +#define MT6360_CHG_ADPBADI (29) > +#define MT6360_CHG_RVPI (30) > +#define MT6360_OTPI (31) > +/* REG 4 -> 32 ~ 39 */ > +#define MT6360_CHG_AICCMEASL (32) > +#define MT6360_CHGDET_DONEI (34) > +#define MT6360_WDTMRI (35) > +#define MT6360_SSFINISHI (36) > +#define MT6360_CHG_RECHGI (37) > +#define MT6360_CHG_TERMI (38) > +#define MT6360_CHG_IEOCI (39) > +/* REG 5 -> 40 ~ 47 */ > +#define MT6360_PUMPX_DONEI (40) > +#define MT6360_BAT_OVP_ADC_EVT (41) > +#define MT6360_TYPEC_OTP_EVT (42) > +#define MT6360_ADC_WAKEUP_EVT (43) > +#define MT6360_ADC_DONEI (44) > +#define MT6360_BST_BATUVI (45) > +#define MT6360_BST_VBUSOVI (46) > +#define MT6360_BST_OLPI (47) > +/* REG 6 -> 48 ~ 55 */ > +#define MT6360_ATTACH_I (48) > +#define MT6360_DETACH_I (49) > +#define MT6360_QC30_STPDONE (51) > +#define MT6360_QC_VBUSDET_DONE (52) > +#define MT6360_HVDCP_DET (53) > +#define MT6360_CHGDETI (54) > +#define MT6360_DCDTI (55) > +/* REG 7 -> 56 ~ 63 */ > +#define MT6360_FOD_DONE_EVT (56) > +#define MT6360_FOD_OV_EVT (57) > +#define MT6360_CHRDET_UVP_EVT (58) > +#define MT6360_CHRDET_OVP_EVT (59) > +#define MT6360_CHRDET_EXT_EVT (60) > +#define MT6360_FOD_LR_EVT (61) > +#define MT6360_FOD_HR_EVT (62) > +#define MT6360_FOD_DISCHG_FAIL_EVT (63) > +/* REG 8 -> 64 ~ 71 */ > +#define MT6360_USBID_EVT (64) > +#define MT6360_APWDTRST_EVT (65) > +#define MT6360_EN_EVT (66) > +#define MT6360_QONB_RST_EVT (67) > +#define MT6360_MRSTB_EVT (68) > +#define MT6360_OTP_EVT (69) > +#define MT6360_VDDAOV_EVT (70) > +#define MT6360_SYSUV_EVT (71) > +/* REG 9 -> 72 ~ 79 */ > +#define MT6360_FLED_STRBPIN_EVT (72) > +#define MT6360_FLED_TORPIN_EVT (73) > +#define MT6360_FLED_TX_EVT (74) > +#define MT6360_FLED_LVF_EVT (75) > +#define MT6360_FLED2_SHORT_EVT (78) > +#define MT6360_FLED1_SHORT_EVT (79) > +/* REG 10 -> 80 ~ 87 */ > +#define MT6360_FLED2_STRB_EVT (80) > +#define MT6360_FLED1_STRB_EVT (81) > +#define MT6360_FLED2_STRB_TO_EVT (82) > +#define MT6360_FLED1_STRB_TO_EVT (83) > +#define MT6360_FLED2_TOR_EVT (84) > +#define MT6360_FLED1_TOR_EVT (85) > +/* REG 11 -> 88 ~ 95 */ > +/* REG 12 -> 96 ~ 103 */ > +#define MT6360_BUCK1_PGB_EVT (96) > +#define MT6360_BUCK1_OC_EVT (100) > +#define MT6360_BUCK1_OV_EVT (101) > +#define MT6360_BUCK1_UV_EVT (102) > +/* REG 13 -> 104 ~ 111 */ > +#define MT6360_BUCK2_PGB_EVT (104) > +#define MT6360_BUCK2_OC_EVT (108) > +#define MT6360_BUCK2_OV_EVT (109) > +#define MT6360_BUCK2_UV_EVT (110) > +/* REG 14 -> 112 ~ 119 */ > +#define MT6360_LDO1_OC_EVT (113) > +#define MT6360_LDO2_OC_EVT (114) > +#define MT6360_LDO3_OC_EVT (115) > +#define MT6360_LDO5_OC_EVT (117) > +#define MT6360_LDO6_OC_EVT (118) > +#define MT6360_LDO7_OC_EVT (119) > +/* REG 15 -> 120 ~ 127 */ > +#define MT6360_LDO1_PGB_EVT (121) > +#define MT6360_LDO2_PGB_EVT (122) > +#define MT6360_LDO3_PGB_EVT (123) > +#define MT6360_LDO5_PGB_EVT (125) > +#define MT6360_LDO6_PGB_EVT (126) > +#define MT6360_LDO7_PGB_EVT (127) > + > +static const struct regmap_irq mt6360_pmu_irqs[] =3D { > + REGMAP_IRQ_REG_LINE(MT6360_CHG_TREG_EVT, 8), > + REGMAP_IRQ_REG_LINE(MT6360_CHG_AICR_EVT, 8), > + REGMAP_IRQ_REG_LINE(MT6360_CHG_MIVR_EVT, 8), > + REGMAP_IRQ_REG_LINE(MT6360_PWR_RDY_EVT, 8), > + REGMAP_IRQ_REG_LINE(MT6360_CHG_BATSYSUV_EVT, 8), > + REGMAP_IRQ_REG_LINE(MT6360_FLED_CHG_VINOVP_EVT, 8), > + REGMAP_IRQ_REG_LINE(MT6360_CHG_VSYSUV_EVT, 8), > + REGMAP_IRQ_REG_LINE(MT6360_CHG_VSYSOV_EVT, 8), > + REGMAP_IRQ_REG_LINE(MT6360_CHG_VBATOV_EVT, 8), > + REGMAP_IRQ_REG_LINE(MT6360_CHG_VBUSOV_EVT, 8), > + REGMAP_IRQ_REG_LINE(MT6360_WD_PMU_DET, 8), > + REGMAP_IRQ_REG_LINE(MT6360_WD_PMU_DONE, 8), > + REGMAP_IRQ_REG_LINE(MT6360_CHG_TMRI, 8), > + REGMAP_IRQ_REG_LINE(MT6360_CHG_ADPBADI, 8), > + REGMAP_IRQ_REG_LINE(MT6360_CHG_RVPI, 8), > + REGMAP_IRQ_REG_LINE(MT6360_OTPI, 8), > + REGMAP_IRQ_REG_LINE(MT6360_CHG_AICCMEASL, 8), > + REGMAP_IRQ_REG_LINE(MT6360_CHGDET_DONEI, 8), > + REGMAP_IRQ_REG_LINE(MT6360_WDTMRI, 8), > + REGMAP_IRQ_REG_LINE(MT6360_SSFINISHI, 8), > + REGMAP_IRQ_REG_LINE(MT6360_CHG_RECHGI, 8), > + REGMAP_IRQ_REG_LINE(MT6360_CHG_TERMI, 8), > + REGMAP_IRQ_REG_LINE(MT6360_CHG_IEOCI, 8), > + REGMAP_IRQ_REG_LINE(MT6360_PUMPX_DONEI, 8), > + REGMAP_IRQ_REG_LINE(MT6360_CHG_TREG_EVT, 8), > + REGMAP_IRQ_REG_LINE(MT6360_BAT_OVP_ADC_EVT, 8), > + REGMAP_IRQ_REG_LINE(MT6360_TYPEC_OTP_EVT, 8), > + REGMAP_IRQ_REG_LINE(MT6360_ADC_WAKEUP_EVT, 8), > + REGMAP_IRQ_REG_LINE(MT6360_ADC_DONEI, 8), > + REGMAP_IRQ_REG_LINE(MT6360_BST_BATUVI, 8), > + REGMAP_IRQ_REG_LINE(MT6360_BST_VBUSOVI, 8), > + REGMAP_IRQ_REG_LINE(MT6360_BST_OLPI, 8), > + REGMAP_IRQ_REG_LINE(MT6360_ATTACH_I, 8), > + REGMAP_IRQ_REG_LINE(MT6360_DETACH_I, 8), > + REGMAP_IRQ_REG_LINE(MT6360_QC30_STPDONE, 8), > + REGMAP_IRQ_REG_LINE(MT6360_QC_VBUSDET_DONE, 8), > + REGMAP_IRQ_REG_LINE(MT6360_HVDCP_DET, 8), > + REGMAP_IRQ_REG_LINE(MT6360_CHGDETI, 8), > + REGMAP_IRQ_REG_LINE(MT6360_DCDTI, 8), > + REGMAP_IRQ_REG_LINE(MT6360_FOD_DONE_EVT, 8), > + REGMAP_IRQ_REG_LINE(MT6360_FOD_OV_EVT, 8), > + REGMAP_IRQ_REG_LINE(MT6360_CHRDET_UVP_EVT, 8), > + REGMAP_IRQ_REG_LINE(MT6360_CHRDET_OVP_EVT, 8), > + REGMAP_IRQ_REG_LINE(MT6360_CHRDET_EXT_EVT, 8), > + REGMAP_IRQ_REG_LINE(MT6360_FOD_LR_EVT, 8), > + REGMAP_IRQ_REG_LINE(MT6360_FOD_HR_EVT, 8), > + REGMAP_IRQ_REG_LINE(MT6360_FOD_DISCHG_FAIL_EVT, 8), > + REGMAP_IRQ_REG_LINE(MT6360_USBID_EVT, 8), > + REGMAP_IRQ_REG_LINE(MT6360_APWDTRST_EVT, 8), > + REGMAP_IRQ_REG_LINE(MT6360_EN_EVT, 8), > + REGMAP_IRQ_REG_LINE(MT6360_QONB_RST_EVT, 8), > + REGMAP_IRQ_REG_LINE(MT6360_MRSTB_EVT, 8), > + REGMAP_IRQ_REG_LINE(MT6360_OTP_EVT, 8), > + REGMAP_IRQ_REG_LINE(MT6360_VDDAOV_EVT, 8), > + REGMAP_IRQ_REG_LINE(MT6360_SYSUV_EVT, 8), > + REGMAP_IRQ_REG_LINE(MT6360_FLED_STRBPIN_EVT, 8), > + REGMAP_IRQ_REG_LINE(MT6360_FLED_TORPIN_EVT, 8), > + REGMAP_IRQ_REG_LINE(MT6360_FLED_TX_EVT, 8), > + REGMAP_IRQ_REG_LINE(MT6360_FLED_LVF_EVT, 8), > + REGMAP_IRQ_REG_LINE(MT6360_FLED2_SHORT_EVT, 8), > + REGMAP_IRQ_REG_LINE(MT6360_FLED1_SHORT_EVT, 8), > + REGMAP_IRQ_REG_LINE(MT6360_FLED2_STRB_EVT, 8), > + REGMAP_IRQ_REG_LINE(MT6360_FLED1_STRB_EVT, 8), > + REGMAP_IRQ_REG_LINE(MT6360_FLED2_STRB_TO_EVT, 8), > + REGMAP_IRQ_REG_LINE(MT6360_FLED1_STRB_TO_EVT, 8), > + REGMAP_IRQ_REG_LINE(MT6360_FLED2_TOR_EVT, 8), > + REGMAP_IRQ_REG_LINE(MT6360_FLED1_TOR_EVT, 8), > + REGMAP_IRQ_REG_LINE(MT6360_BUCK1_PGB_EVT, 8), > + REGMAP_IRQ_REG_LINE(MT6360_BUCK1_OC_EVT, 8), > + REGMAP_IRQ_REG_LINE(MT6360_BUCK1_OV_EVT, 8), > + REGMAP_IRQ_REG_LINE(MT6360_BUCK1_UV_EVT, 8), > + REGMAP_IRQ_REG_LINE(MT6360_BUCK2_PGB_EVT, 8), > + REGMAP_IRQ_REG_LINE(MT6360_BUCK2_OC_EVT, 8), > + REGMAP_IRQ_REG_LINE(MT6360_BUCK2_OV_EVT, 8), > + REGMAP_IRQ_REG_LINE(MT6360_BUCK2_UV_EVT, 8), > + REGMAP_IRQ_REG_LINE(MT6360_LDO1_OC_EVT, 8), > + REGMAP_IRQ_REG_LINE(MT6360_LDO2_OC_EVT, 8), > + REGMAP_IRQ_REG_LINE(MT6360_LDO3_OC_EVT, 8), > + REGMAP_IRQ_REG_LINE(MT6360_LDO5_OC_EVT, 8), > + REGMAP_IRQ_REG_LINE(MT6360_LDO6_OC_EVT, 8), > + REGMAP_IRQ_REG_LINE(MT6360_LDO7_OC_EVT, 8), > + REGMAP_IRQ_REG_LINE(MT6360_LDO1_PGB_EVT, 8), > + REGMAP_IRQ_REG_LINE(MT6360_LDO2_PGB_EVT, 8), > + REGMAP_IRQ_REG_LINE(MT6360_LDO3_PGB_EVT, 8), > + REGMAP_IRQ_REG_LINE(MT6360_LDO5_PGB_EVT, 8), > + REGMAP_IRQ_REG_LINE(MT6360_LDO6_PGB_EVT, 8), > + REGMAP_IRQ_REG_LINE(MT6360_LDO7_PGB_EVT, 8), > +}; > + > +static int mt6360_pmu_handle_post_irq(void *irq_drv_data) > +{ > + struct mt6360_pmu_data *mpd =3D irq_drv_data; > + > + return regmap_update_bits(mpd->regmap, > + MT6360_PMU_IRQ_SET, MT6360_IRQ_RETRIG, MT6360_IRQ_RETRIG)= ; > +} > + > +static struct regmap_irq_chip mt6360_pmu_irq_chip =3D { > + .irqs =3D mt6360_pmu_irqs, > + .num_irqs =3D ARRAY_SIZE(mt6360_pmu_irqs), > + .num_regs =3D MT6360_PMU_IRQ_REGNUM, > + .mask_base =3D MT6360_PMU_CHG_MASK1, > + .status_base =3D MT6360_PMU_CHG_IRQ1, > + .ack_base =3D MT6360_PMU_CHG_IRQ1, > + .init_ack_masked =3D true, > + .use_ack =3D true, > + .handle_post_irq =3D mt6360_pmu_handle_post_irq, > +}; > + > +static const struct regmap_config mt6360_pmu_regmap_config =3D { > + .reg_bits =3D 8, > + .val_bits =3D 8, > + .max_register =3D MT6360_PMU_MAXREG, > +}; > + > +static const struct resource mt6360_adc_resources[] =3D { > + DEFINE_RES_IRQ_NAMED(MT6360_ADC_DONEI, "adc_donei"), > +}; > + > +static const struct resource mt6360_chg_resources[] =3D { > + DEFINE_RES_IRQ_NAMED(MT6360_CHG_TREG_EVT, "chg_treg_evt"), > + DEFINE_RES_IRQ_NAMED(MT6360_PWR_RDY_EVT, "pwr_rdy_evt"), > + DEFINE_RES_IRQ_NAMED(MT6360_CHG_BATSYSUV_EVT, "chg_batsysuv_evt")= , > + DEFINE_RES_IRQ_NAMED(MT6360_CHG_VSYSUV_EVT, "chg_vsysuv_evt"), > + DEFINE_RES_IRQ_NAMED(MT6360_CHG_VSYSOV_EVT, "chg_vsysov_evt"), > + DEFINE_RES_IRQ_NAMED(MT6360_CHG_VBATOV_EVT, "chg_vbatov_evt"), > + DEFINE_RES_IRQ_NAMED(MT6360_CHG_VBUSOV_EVT, "chg_vbusov_evt"), > + DEFINE_RES_IRQ_NAMED(MT6360_CHG_AICCMEASL, "chg_aiccmeasl"), > + DEFINE_RES_IRQ_NAMED(MT6360_WDTMRI, "wdtmri"), > + DEFINE_RES_IRQ_NAMED(MT6360_CHG_RECHGI, "chg_rechgi"), > + DEFINE_RES_IRQ_NAMED(MT6360_CHG_TERMI, "chg_termi"), > + DEFINE_RES_IRQ_NAMED(MT6360_CHG_IEOCI, "chg_ieoci"), > + DEFINE_RES_IRQ_NAMED(MT6360_PUMPX_DONEI, "pumpx_donei"), > + DEFINE_RES_IRQ_NAMED(MT6360_ATTACH_I, "attach_i"), > + DEFINE_RES_IRQ_NAMED(MT6360_CHRDET_EXT_EVT, "chrdet_ext_evt"), > +}; > + > +static const struct resource mt6360_led_resources[] =3D { > + DEFINE_RES_IRQ_NAMED(MT6360_FLED_CHG_VINOVP_EVT, "fled_chg_vinovp= _evt"), > + DEFINE_RES_IRQ_NAMED(MT6360_FLED_LVF_EVT, "fled_lvf_evt"), > + DEFINE_RES_IRQ_NAMED(MT6360_FLED2_SHORT_EVT, "fled2_short_evt"), > + DEFINE_RES_IRQ_NAMED(MT6360_FLED1_SHORT_EVT, "fled1_short_evt"), > + DEFINE_RES_IRQ_NAMED(MT6360_FLED2_STRB_TO_EVT, "fled2_strb_to_evt= "), > + DEFINE_RES_IRQ_NAMED(MT6360_FLED1_STRB_TO_EVT, "fled1_strb_to_evt= "), > +}; > + > +static const struct resource mt6360_pmic_resources[] =3D { > + DEFINE_RES_IRQ_NAMED(MT6360_BUCK1_PGB_EVT, "buck1_pgb_evt"), > + DEFINE_RES_IRQ_NAMED(MT6360_BUCK1_OC_EVT, "buck1_oc_evt"), > + DEFINE_RES_IRQ_NAMED(MT6360_BUCK1_OV_EVT, "buck1_ov_evt"), > + DEFINE_RES_IRQ_NAMED(MT6360_BUCK1_UV_EVT, "buck1_uv_evt"), > + DEFINE_RES_IRQ_NAMED(MT6360_BUCK2_PGB_EVT, "buck2_pgb_evt"), > + DEFINE_RES_IRQ_NAMED(MT6360_BUCK2_OC_EVT, "buck2_oc_evt"), > + DEFINE_RES_IRQ_NAMED(MT6360_BUCK2_OV_EVT, "buck2_ov_evt"), > + DEFINE_RES_IRQ_NAMED(MT6360_BUCK2_UV_EVT, "buck2_uv_evt"), > + DEFINE_RES_IRQ_NAMED(MT6360_LDO6_OC_EVT, "ldo6_oc_evt"), > + DEFINE_RES_IRQ_NAMED(MT6360_LDO7_OC_EVT, "ldo7_oc_evt"), > + DEFINE_RES_IRQ_NAMED(MT6360_LDO6_PGB_EVT, "ldo6_pgb_evt"), > + DEFINE_RES_IRQ_NAMED(MT6360_LDO7_PGB_EVT, "ldo7_pgb_evt"), > +}; > + > +static const struct resource mt6360_ldo_resources[] =3D { > + DEFINE_RES_IRQ_NAMED(MT6360_LDO1_OC_EVT, "ldo1_oc_evt"), > + DEFINE_RES_IRQ_NAMED(MT6360_LDO2_OC_EVT, "ldo2_oc_evt"), > + DEFINE_RES_IRQ_NAMED(MT6360_LDO3_OC_EVT, "ldo3_oc_evt"), > + DEFINE_RES_IRQ_NAMED(MT6360_LDO5_OC_EVT, "ldo5_oc_evt"), > + DEFINE_RES_IRQ_NAMED(MT6360_LDO1_PGB_EVT, "ldo1_pgb_evt"), > + DEFINE_RES_IRQ_NAMED(MT6360_LDO2_PGB_EVT, "ldo2_pgb_evt"), > + DEFINE_RES_IRQ_NAMED(MT6360_LDO3_PGB_EVT, "ldo3_pgb_evt"), > + DEFINE_RES_IRQ_NAMED(MT6360_LDO5_PGB_EVT, "ldo5_pgb_evt"), > +}; > + > +static const struct mfd_cell mt6360_devs[] =3D { > + OF_MFD_CELL("mt6360_adc", mt6360_adc_resources, > + NULL, 0, 0, "mediatek,mt6360_adc"), > + OF_MFD_CELL("mt6360_chg", mt6360_chg_resources, > + NULL, 0, 0, "mediatek,mt6360_chg"), > + OF_MFD_CELL("mt6360_led", mt6360_led_resources, > + NULL, 0, 0, "mediatek,mt6360_led"), > + OF_MFD_CELL("mt6360_pmic", mt6360_pmic_resources, > + NULL, 0, 0, "mediatek,mt6360_pmic"), > + OF_MFD_CELL("mt6360_ldo", mt6360_ldo_resources, > + NULL, 0, 0, "mediatek,mt6360_ldo"), > + OF_MFD_CELL("mt6360_tcpc", NULL, > + NULL, 0, 0, "mediatek,mt6360_tcpc"), > +}; > + > +static const unsigned short mt6360_slave_addr[MT6360_SLAVE_MAX] =3D { > + MT6360_PMU_SLAVEID, > + MT6360_PMIC_SLAVEID, > + MT6360_LDO_SLAVEID, > + MT6360_TCPC_SLAVEID, > +}; > + > +static int mt6360_pmu_probe(struct i2c_client *client) > +{ > + struct mt6360_pmu_data *mpd; > + unsigned int reg_data; > + int i, ret; > + > + mpd =3D devm_kzalloc(&client->dev, sizeof(*mpd), GFP_KERNEL); > + if (!mpd) > + return -ENOMEM; > + > + mpd->dev =3D &client->dev; > + i2c_set_clientdata(client, mpd); > + > + mpd->regmap =3D devm_regmap_init_i2c(client, &mt6360_pmu_regmap_c= onfig); > + if (IS_ERR(mpd->regmap)) { > + dev_err(&client->dev, "Failed to register regmap\n"); > + return PTR_ERR(mpd->regmap); > + } > + > + ret =3D regmap_read(mpd->regmap, MT6360_PMU_DEV_INFO, ®_data); > + if (ret) { > + dev_err(&client->dev, "Device not found\n"); > + return ret; > + } > + > + mpd->chip_rev =3D reg_data & CHIP_REV_MASK; > + if (mpd->chip_rev !=3D CHIP_VEN_MT6360) { > + dev_err(&client->dev, "Device not supported\n"); > + return -ENODEV; > + } > + > + mt6360_pmu_irq_chip.irq_drv_data =3D mpd; > + ret =3D devm_regmap_add_irq_chip(&client->dev, mpd->regmap, clien= t->irq, > + IRQF_TRIGGER_FALLING, 0, > + &mt6360_pmu_irq_chip, &mpd->irq_da= ta); > + if (ret) { > + dev_err(&client->dev, "Failed to add Regmap IRQ Chip\n"); > + return ret; > + } > + > + mpd->i2c[0] =3D client; > + for (i =3D 1; i < MT6360_SLAVE_MAX; i++) { > + mpd->i2c[i] =3D devm_i2c_new_dummy_device(&client->dev, > + client->adapter, > + mt6360_slave_addr= [i]); > + if (IS_ERR(mpd->i2c[i])) { > + dev_err(&client->dev, > + "Failed to get new dummy I2C device for a= ddress 0x%x", > + mt6360_slave_addr[i]); > + return PTR_ERR(mpd->i2c[i]); > + } > + i2c_set_clientdata(mpd->i2c[i], mpd); > + } > + > + ret =3D devm_mfd_add_devices(&client->dev, PLATFORM_DEVID_AUTO, > + mt6360_devs, ARRAY_SIZE(mt6360_devs), = NULL, > + 0, regmap_irq_get_domain(mpd->irq_data= )); > + if (ret) { > + dev_err(&client->dev, > + "Failed to register subordinate devices\n"); > + return ret; > + } > + > + return 0; > +} > + > +static int __maybe_unused mt6360_pmu_suspend(struct device *dev) > +{ > + struct i2c_client *i2c =3D to_i2c_client(dev); > + > + if (device_may_wakeup(dev)) > + enable_irq_wake(i2c->irq); > + > + return 0; > +} > + > +static int __maybe_unused mt6360_pmu_resume(struct device *dev) > +{ > + > + struct i2c_client *i2c =3D to_i2c_client(dev); > + > + if (device_may_wakeup(dev)) > + disable_irq_wake(i2c->irq); > + > + return 0; > +} > + > +static SIMPLE_DEV_PM_OPS(mt6360_pmu_pm_ops, > + mt6360_pmu_suspend, mt6360_pmu_resume); > + > +static const struct of_device_id __maybe_unused mt6360_pmu_of_id[] =3D { > + { .compatible =3D "mediatek,mt6360_pmu", }, > + {}, > +}; > +MODULE_DEVICE_TABLE(of, mt6360_pmu_of_id); > + > +static struct i2c_driver mt6360_pmu_driver =3D { > + .driver =3D { > + .pm =3D &mt6360_pmu_pm_ops, > + .of_match_table =3D of_match_ptr(mt6360_pmu_of_id), > + }, > + .probe_new =3D mt6360_pmu_probe, > +}; > +module_i2c_driver(mt6360_pmu_driver); > + > +MODULE_AUTHOR("Gene Chen "); > +MODULE_DESCRIPTION("MT6360 PMU I2C Driver"); > +MODULE_LICENSE("GPL v2"); > diff --git a/include/linux/mfd/mt6360.h b/include/linux/mfd/mt6360.h > new file mode 100644 > index 0000000..ea13040 > --- /dev/null > +++ b/include/linux/mfd/mt6360.h > @@ -0,0 +1,240 @@ > +/* SPDX-License-Identifier: GPL-2.0 */ > +/* > + * Copyright (c) 2020 MediaTek Inc. > + */ > + > +#ifndef __MT6360_H__ > +#define __MT6360_H__ > + > +#include > + > +enum { > + MT6360_SLAVE_PMU =3D 0, > + MT6360_SLAVE_PMIC, > + MT6360_SLAVE_LDO, > + MT6360_SLAVE_TCPC, > + MT6360_SLAVE_MAX, > +}; > + > +#define MT6360_PMU_SLAVEID (0x34) > +#define MT6360_PMIC_SLAVEID (0x1A) > +#define MT6360_LDO_SLAVEID (0x64) > +#define MT6360_TCPC_SLAVEID (0x4E) > + > +struct mt6360_pmu_data { > + struct i2c_client *i2c[MT6360_SLAVE_MAX]; > + struct device *dev; > + struct regmap *regmap; > + struct regmap_irq_chip_data *irq_data; > + unsigned int chip_rev; > +}; > + > +/* PMU register defininition */ > +#define MT6360_PMU_DEV_INFO (0x00) > +#define MT6360_PMU_CORE_CTRL1 (0x01) > +#define MT6360_PMU_RST1 (0x02) > +#define MT6360_PMU_CRCEN (0x03) > +#define MT6360_PMU_RST_PAS_CODE1 (0x04) > +#define MT6360_PMU_RST_PAS_CODE2 (0x05) > +#define MT6360_PMU_CORE_CTRL2 (0x06) > +#define MT6360_PMU_TM_PAS_CODE1 (0x07) > +#define MT6360_PMU_TM_PAS_CODE2 (0x08) > +#define MT6360_PMU_TM_PAS_CODE3 (0x09) > +#define MT6360_PMU_TM_PAS_CODE4 (0x0A) > +#define MT6360_PMU_IRQ_IND (0x0B) > +#define MT6360_PMU_IRQ_MASK (0x0C) > +#define MT6360_PMU_IRQ_SET (0x0D) > +#define MT6360_PMU_SHDN_CTRL (0x0E) > +#define MT6360_PMU_TM_INF (0x0F) > +#define MT6360_PMU_I2C_CTRL (0x10) > +#define MT6360_PMU_CHG_CTRL1 (0x11) > +#define MT6360_PMU_CHG_CTRL2 (0x12) > +#define MT6360_PMU_CHG_CTRL3 (0x13) > +#define MT6360_PMU_CHG_CTRL4 (0x14) > +#define MT6360_PMU_CHG_CTRL5 (0x15) > +#define MT6360_PMU_CHG_CTRL6 (0x16) > +#define MT6360_PMU_CHG_CTRL7 (0x17) > +#define MT6360_PMU_CHG_CTRL8 (0x18) > +#define MT6360_PMU_CHG_CTRL9 (0x19) > +#define MT6360_PMU_CHG_CTRL10 (0x1A) > +#define MT6360_PMU_CHG_CTRL11 (0x1B) > +#define MT6360_PMU_CHG_CTRL12 (0x1C) > +#define MT6360_PMU_CHG_CTRL13 (0x1D) > +#define MT6360_PMU_CHG_CTRL14 (0x1E) > +#define MT6360_PMU_CHG_CTRL15 (0x1F) > +#define MT6360_PMU_CHG_CTRL16 (0x20) > +#define MT6360_PMU_CHG_AICC_RESULT (0x21) > +#define MT6360_PMU_DEVICE_TYPE (0x22) > +#define MT6360_PMU_QC_CONTROL1 (0x23) > +#define MT6360_PMU_QC_CONTROL2 (0x24) > +#define MT6360_PMU_QC30_CONTROL1 (0x25) > +#define MT6360_PMU_QC30_CONTROL2 (0x26) > +#define MT6360_PMU_USB_STATUS1 (0x27) > +#define MT6360_PMU_QC_STATUS1 (0x28) > +#define MT6360_PMU_QC_STATUS2 (0x29) > +#define MT6360_PMU_CHG_PUMP (0x2A) > +#define MT6360_PMU_CHG_CTRL17 (0x2B) > +#define MT6360_PMU_CHG_CTRL18 (0x2C) > +#define MT6360_PMU_CHRDET_CTRL1 (0x2D) > +#define MT6360_PMU_CHRDET_CTRL2 (0x2E) > +#define MT6360_PMU_DPDN_CTRL (0x2F) > +#define MT6360_PMU_CHG_HIDDEN_CTRL1 (0x30) > +#define MT6360_PMU_CHG_HIDDEN_CTRL2 (0x31) > +#define MT6360_PMU_CHG_HIDDEN_CTRL3 (0x32) > +#define MT6360_PMU_CHG_HIDDEN_CTRL4 (0x33) > +#define MT6360_PMU_CHG_HIDDEN_CTRL5 (0x34) > +#define MT6360_PMU_CHG_HIDDEN_CTRL6 (0x35) > +#define MT6360_PMU_CHG_HIDDEN_CTRL7 (0x36) > +#define MT6360_PMU_CHG_HIDDEN_CTRL8 (0x37) > +#define MT6360_PMU_CHG_HIDDEN_CTRL9 (0x38) > +#define MT6360_PMU_CHG_HIDDEN_CTRL10 (0x39) > +#define MT6360_PMU_CHG_HIDDEN_CTRL11 (0x3A) > +#define MT6360_PMU_CHG_HIDDEN_CTRL12 (0x3B) > +#define MT6360_PMU_CHG_HIDDEN_CTRL13 (0x3C) > +#define MT6360_PMU_CHG_HIDDEN_CTRL14 (0x3D) > +#define MT6360_PMU_CHG_HIDDEN_CTRL15 (0x3E) > +#define MT6360_PMU_CHG_HIDDEN_CTRL16 (0x3F) > +#define MT6360_PMU_CHG_HIDDEN_CTRL17 (0x40) > +#define MT6360_PMU_CHG_HIDDEN_CTRL18 (0x41) > +#define MT6360_PMU_CHG_HIDDEN_CTRL19 (0x42) > +#define MT6360_PMU_CHG_HIDDEN_CTRL20 (0x43) > +#define MT6360_PMU_CHG_HIDDEN_CTRL21 (0x44) > +#define MT6360_PMU_CHG_HIDDEN_CTRL22 (0x45) > +#define MT6360_PMU_CHG_HIDDEN_CTRL23 (0x46) > +#define MT6360_PMU_CHG_HIDDEN_CTRL24 (0x47) > +#define MT6360_PMU_CHG_HIDDEN_CTRL25 (0x48) > +#define MT6360_PMU_BC12_CTRL (0x49) > +#define MT6360_PMU_CHG_STAT (0x4A) > +#define MT6360_PMU_RESV1 (0x4B) > +#define MT6360_PMU_TYPEC_OTP_TH_SEL_CODEH (0x4E) > +#define MT6360_PMU_TYPEC_OTP_TH_SEL_CODEL (0x4F) > +#define MT6360_PMU_TYPEC_OTP_HYST_TH (0x50) > +#define MT6360_PMU_TYPEC_OTP_CTRL (0x51) > +#define MT6360_PMU_ADC_BAT_DATA_H (0x52) > +#define MT6360_PMU_ADC_BAT_DATA_L (0x53) > +#define MT6360_PMU_IMID_BACKBST_ON (0x54) > +#define MT6360_PMU_IMID_BACKBST_OFF (0x55) > +#define MT6360_PMU_ADC_CONFIG (0x56) > +#define MT6360_PMU_ADC_EN2 (0x57) > +#define MT6360_PMU_ADC_IDLE_T (0x58) > +#define MT6360_PMU_ADC_RPT_1 (0x5A) > +#define MT6360_PMU_ADC_RPT_2 (0x5B) > +#define MT6360_PMU_ADC_RPT_3 (0x5C) > +#define MT6360_PMU_ADC_RPT_ORG1 (0x5D) > +#define MT6360_PMU_ADC_RPT_ORG2 (0x5E) > +#define MT6360_PMU_BAT_OVP_TH_SEL_CODEH (0x5F) > +#define MT6360_PMU_BAT_OVP_TH_SEL_CODEL (0x60) > +#define MT6360_PMU_CHG_CTRL19 (0x61) > +#define MT6360_PMU_VDDASUPPLY (0x62) > +#define MT6360_PMU_BC12_MANUAL (0x63) > +#define MT6360_PMU_CHGDET_FUNC (0x64) > +#define MT6360_PMU_FOD_CTRL (0x65) > +#define MT6360_PMU_CHG_CTRL20 (0x66) > +#define MT6360_PMU_CHG_HIDDEN_CTRL26 (0x67) > +#define MT6360_PMU_CHG_HIDDEN_CTRL27 (0x68) > +#define MT6360_PMU_RESV2 (0x69) > +#define MT6360_PMU_USBID_CTRL1 (0x6D) > +#define MT6360_PMU_USBID_CTRL2 (0x6E) > +#define MT6360_PMU_USBID_CTRL3 (0x6F) > +#define MT6360_PMU_FLED_CFG (0x70) > +#define MT6360_PMU_RESV3 (0x71) > +#define MT6360_PMU_FLED1_CTRL (0x72) > +#define MT6360_PMU_FLED_STRB_CTRL (0x73) > +#define MT6360_PMU_FLED1_STRB_CTRL2 (0x74) > +#define MT6360_PMU_FLED1_TOR_CTRL (0x75) > +#define MT6360_PMU_FLED2_CTRL (0x76) > +#define MT6360_PMU_RESV4 (0x77) > +#define MT6360_PMU_FLED2_STRB_CTRL2 (0x78) > +#define MT6360_PMU_FLED2_TOR_CTRL (0x79) > +#define MT6360_PMU_FLED_VMIDTRK_CTRL1 (0x7A) > +#define MT6360_PMU_FLED_VMID_RTM (0x7B) > +#define MT6360_PMU_FLED_VMIDTRK_CTRL2 (0x7C) > +#define MT6360_PMU_FLED_PWSEL (0x7D) > +#define MT6360_PMU_FLED_EN (0x7E) > +#define MT6360_PMU_FLED_Hidden1 (0x7F) > +#define MT6360_PMU_RGB_EN (0x80) > +#define MT6360_PMU_RGB1_ISNK (0x81) > +#define MT6360_PMU_RGB2_ISNK (0x82) > +#define MT6360_PMU_RGB3_ISNK (0x83) > +#define MT6360_PMU_RGB_ML_ISNK (0x84) > +#define MT6360_PMU_RGB1_DIM (0x85) > +#define MT6360_PMU_RGB2_DIM (0x86) > +#define MT6360_PMU_RGB3_DIM (0x87) > +#define MT6360_PMU_RESV5 (0x88) > +#define MT6360_PMU_RGB12_Freq (0x89) > +#define MT6360_PMU_RGB34_Freq (0x8A) > +#define MT6360_PMU_RGB1_Tr (0x8B) > +#define MT6360_PMU_RGB1_Tf (0x8C) > +#define MT6360_PMU_RGB1_TON_TOFF (0x8D) > +#define MT6360_PMU_RGB2_Tr (0x8E) > +#define MT6360_PMU_RGB2_Tf (0x8F) > +#define MT6360_PMU_RGB2_TON_TOFF (0x90) > +#define MT6360_PMU_RGB3_Tr (0x91) > +#define MT6360_PMU_RGB3_Tf (0x92) > +#define MT6360_PMU_RGB3_TON_TOFF (0x93) > +#define MT6360_PMU_RGB_Hidden_CTRL1 (0x94) > +#define MT6360_PMU_RGB_Hidden_CTRL2 (0x95) > +#define MT6360_PMU_RESV6 (0x97) > +#define MT6360_PMU_SPARE1 (0x9A) > +#define MT6360_PMU_SPARE2 (0xA0) > +#define MT6360_PMU_SPARE3 (0xB0) > +#define MT6360_PMU_SPARE4 (0xC0) > +#define MT6360_PMU_CHG_IRQ1 (0xD0) > +#define MT6360_PMU_CHG_IRQ2 (0xD1) > +#define MT6360_PMU_CHG_IRQ3 (0xD2) > +#define MT6360_PMU_CHG_IRQ4 (0xD3) > +#define MT6360_PMU_CHG_IRQ5 (0xD4) > +#define MT6360_PMU_CHG_IRQ6 (0xD5) > +#define MT6360_PMU_QC_IRQ (0xD6) > +#define MT6360_PMU_FOD_IRQ (0xD7) > +#define MT6360_PMU_BASE_IRQ (0xD8) > +#define MT6360_PMU_FLED_IRQ1 (0xD9) > +#define MT6360_PMU_FLED_IRQ2 (0xDA) > +#define MT6360_PMU_RGB_IRQ (0xDB) > +#define MT6360_PMU_BUCK1_IRQ (0xDC) > +#define MT6360_PMU_BUCK2_IRQ (0xDD) > +#define MT6360_PMU_LDO_IRQ1 (0xDE) > +#define MT6360_PMU_LDO_IRQ2 (0xDF) > +#define MT6360_PMU_CHG_STAT1 (0xE0) > +#define MT6360_PMU_CHG_STAT2 (0xE1) > +#define MT6360_PMU_CHG_STAT3 (0xE2) > +#define MT6360_PMU_CHG_STAT4 (0xE3) > +#define MT6360_PMU_CHG_STAT5 (0xE4) > +#define MT6360_PMU_CHG_STAT6 (0xE5) > +#define MT6360_PMU_QC_STAT (0xE6) > +#define MT6360_PMU_FOD_STAT (0xE7) > +#define MT6360_PMU_BASE_STAT (0xE8) > +#define MT6360_PMU_FLED_STAT1 (0xE9) > +#define MT6360_PMU_FLED_STAT2 (0xEA) > +#define MT6360_PMU_RGB_STAT (0xEB) > +#define MT6360_PMU_BUCK1_STAT (0xEC) > +#define MT6360_PMU_BUCK2_STAT (0xED) > +#define MT6360_PMU_LDO_STAT1 (0xEE) > +#define MT6360_PMU_LDO_STAT2 (0xEF) > +#define MT6360_PMU_CHG_MASK1 (0xF0) > +#define MT6360_PMU_CHG_MASK2 (0xF1) > +#define MT6360_PMU_CHG_MASK3 (0xF2) > +#define MT6360_PMU_CHG_MASK4 (0xF3) > +#define MT6360_PMU_CHG_MASK5 (0xF4) > +#define MT6360_PMU_CHG_MASK6 (0xF5) > +#define MT6360_PMU_QC_MASK (0xF6) > +#define MT6360_PMU_FOD_MASK (0xF7) > +#define MT6360_PMU_BASE_MASK (0xF8) > +#define MT6360_PMU_FLED_MASK1 (0xF9) > +#define MT6360_PMU_FLED_MASK2 (0xFA) > +#define MT6360_PMU_FAULTB_MASK (0xFB) > +#define MT6360_PMU_BUCK1_MASK (0xFC) > +#define MT6360_PMU_BUCK2_MASK (0xFD) > +#define MT6360_PMU_LDO_MASK1 (0xFE) > +#define MT6360_PMU_LDO_MASK2 (0xFF) > +#define MT6360_PMU_MAXREG (MT6360_PMU_LDO_MASK2) > + > +/* MT6360_PMU_IRQ_SET */ > +#define MT6360_PMU_IRQ_REGNUM (MT6360_PMU_LDO_IRQ2 - MT6360_PMU_CHG_IRQ= 1 + 1) > +#define MT6360_IRQ_RETRIG BIT(2) > + > +#define CHIP_VEN_MASK (0xF0) > +#define CHIP_VEN_MT6360 (0x50) > +#define CHIP_REV_MASK (0x0F) > + > +#endif /* __MT6360_H__ */ > -- > 2.7.4 > Hi Lee, i run checkpatch have 3 warning, but i think 1/2 can be ignored, i can prepare devicetree binding document first. does anything i can do when waiting review? 1. WARNING: Non-standard signature: Acked-for-mfd-by: #10: Acked-for-mfd-by: Lee Jones 2. WARNING: added, moved or deleted file(s), does MAINTAINERS need updating= ? #92: new file mode 100644. 3. WARNING: DT compatible string "mediatek,mt6360_pmu" appears un-documented -- check ./Documentation/devicetree/bindings/ #505: FILE: drivers/mfd/mt6360-core.c:409: + { .compatible =3D "mediatek,mt6360_pmu", },