Received: by 2002:a25:ef43:0:0:0:0:0 with SMTP id w3csp432576ybm; Tue, 26 May 2020 22:07:04 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyfWMmaD6N8hijvXhSYJ8vs0NWiH1o+MlKDlqer6LDbwvuMCFeKFtjPBVgScGymtncV9egt X-Received: by 2002:a17:906:6808:: with SMTP id k8mr4372758ejr.125.1590556024412; Tue, 26 May 2020 22:07:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1590556024; cv=none; d=google.com; s=arc-20160816; b=Rd8pkpjq/+0ihnl8eY2s9lo1BDX/AZSFZnlifqXKBU3fnX70kQwWuHCZWXnO0tZdr1 qx3/VKQ7XLMTTDGYqokHKa+bu8RkznqUPHfVrJaVgDc4vMjP1c78L+FzoAmWVFUEjVTE QX0FJmShZO+SmnU2eKFLYyr478vd70/wN5K/za03Q194/656559Y5Zvq9WM+LsZsdFpW ZXXoZW1riPOOkmLxzwYpUu6jU9nsz8vnbQc448Zv4lJhbd+Pw+FnYBgi2+X5dV77usqu d3/f3W7ygabRXF/dNG+1sYJrdd5OG54qt697cCN/E3ihdnQwezvAH/ZbhAA7MYchixyP iqeQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=mghp+WpbdLMN0nDPLyfzed/1h7X13BvnjtY+Osza9A4=; b=0GDwPDCgqg6bzhBW5AUcWY+H5r5SPNg+LiXfP5w4qpom3iEyDoEmEUTm0gAE9F4gLX zuhaXaSn4yjp3UB8mWt/sCaldg9H+1/nx/u1wWxeZDoZwB3u669HwzZwbVfZa/oD7ku2 m8KJI8+bfD3yJPnH+pV0bRWA0BytgqFr3J5qXMc0EMZl1F65kryvQjm1H3OLMa5FuVkp S8SZK8q1o+kBqqsjhrCjdJJym/m7GJxoZ8/TiBlFyU0OP6cgSPn94BhxvIe1HajCh4xm VM/w1rkTDM0ZbXp87vOi4Lfck7wZXIJ1ckfPnQUb2WTlUdY02okMRHJ0OvY9eCjOjssM IVyQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2020-01-29 header.b=C1LQYV9L; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id r19si1013180edm.596.2020.05.26.22.06.41; Tue, 26 May 2020 22:07:04 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2020-01-29 header.b=C1LQYV9L; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726150AbgE0CPi (ORCPT + 99 others); Tue, 26 May 2020 22:15:38 -0400 Received: from userp2120.oracle.com ([156.151.31.85]:42738 "EHLO userp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725271AbgE0CPi (ORCPT ); Tue, 26 May 2020 22:15:38 -0400 Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 04R2BjUd057186; Wed, 27 May 2020 02:15:21 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-transfer-encoding; s=corp-2020-01-29; bh=mghp+WpbdLMN0nDPLyfzed/1h7X13BvnjtY+Osza9A4=; b=C1LQYV9LfP5bvnSkNrP4Sgtk2MWKdoD5Zc2Vt4kmW/TIb4YMrf+/AkZc8MaDqD3XxYZB bQZnEsFKh9MTVH3wiu6sFFBZYcAdvNhrv39TwUAuqT2b1VvHD8NrRsepvwrNu4ATPVSt GFXqPAZvUf9Axc88vtFWdPNP8XIQdWbKlhxEVa6uLiUmuzzakZW1586MLMqsBn2IdoaH SMDpLp5W2//GZZtQTJFqkUQofEjLEzLi4Xahp81Vwmqg4h1RudfNOuBNTUgbbF1XLcL8 62QGBa6I5weuZnFjXza6u3GGkkLrH1/dioQSw99Pdaym82rbR3nUVZWTyB5R6SCe7XSA 2w== Received: from aserp3020.oracle.com (aserp3020.oracle.com [141.146.126.70]) by userp2120.oracle.com with ESMTP id 318xbjvyr2-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 27 May 2020 02:15:21 +0000 Received: from pps.filterd (aserp3020.oracle.com [127.0.0.1]) by aserp3020.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 04R27XpX133148; Wed, 27 May 2020 02:13:20 GMT Received: from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235]) by aserp3020.oracle.com with ESMTP id 317j5q90dv-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 27 May 2020 02:13:20 +0000 Received: from abhmp0013.oracle.com (abhmp0013.oracle.com [141.146.116.19]) by aserv0121.oracle.com (8.14.4/8.13.8) with ESMTP id 04R2DIAw024162; Wed, 27 May 2020 02:13:20 GMT Received: from ca-mkp.ca.oracle.com (/10.156.108.201) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Tue, 26 May 2020 19:13:18 -0700 From: "Martin K. Petersen" To: Dick Kennedy , linux-scsi@vger.kernel.org, Xiyu Yang , James Smart , linux-kernel@vger.kernel.org, "James E.J. Bottomley" Cc: "Martin K . Petersen" , Xin Tan , yuanxzhang@fudan.edu.cn, kjlu@umn.edu Subject: Re: [PATCH] scsi: lpfc: Fix lpfc_nodelist leak when processing unsolicited event Date: Tue, 26 May 2020 22:13:03 -0400 Message-Id: <159054550934.12032.465431351148000035.b4-ty@oracle.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <1590416184-52592-1-git-send-email-xiyuyang19@fudan.edu.cn> References: <1590416184-52592-1-git-send-email-xiyuyang19@fudan.edu.cn> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9633 signatures=668686 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 spamscore=0 suspectscore=1 mlxlogscore=999 mlxscore=0 adultscore=0 phishscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2004280000 definitions=main-2005270012 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9633 signatures=668686 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 spamscore=0 mlxscore=0 lowpriorityscore=0 priorityscore=1501 phishscore=0 cotscore=-2147483648 suspectscore=1 bulkscore=0 clxscore=1011 impostorscore=0 malwarescore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2004280000 definitions=main-2005270013 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 25 May 2020 22:16:24 +0800, Xiyu Yang wrote: > In order to create or activate a new node, lpfc_els_unsol_buffer() > invokes lpfc_nlp_init() or lpfc_enable_node() or lpfc_nlp_get(), all of > them will return a reference of the specified lpfc_nodelist object to > "ndlp" with increased refcnt. > > When lpfc_els_unsol_buffer() returns, local variable "ndlp" becomes > invalid, so the refcount should be decreased to keep refcount balanced. > > [...] Applied to 5.8/scsi-queue, thanks! [1/1] scsi: lpfc: Fix lpfc_nodelist leak when processing unsolicited event https://git.kernel.org/mkp/scsi/c/7217e6e694da -- Martin K. Petersen Oracle Linux Engineering