Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: GRSqhu7Ij8H6PUGsOjoVTH4LQEhYjTFL2JnYFfVSjdWWVEU2aqrurznGQy27uNZH7BA/6dLOJ/
 A/5tz9dRxjbQ==
IronPort-SDR: f0/a7uXNqJ5aDFrnDJ0yEoe7GmPGGF/fM4jFM9d1GXpNKVgxLRdXoBGZ/L70VPM+xs2wnh8j4G
 vfSzCZXTOKAg==
Subject: Re: [PATCH v8 2/2] clk: intel: Add CGU clock driver for a new SoC
To:     Stephen Boyd <sboyd@kernel.org>, linux-clk@vger.kernel.org,
        mturquette@baylibre.com
Cc:     robh@kernel.org, mark.rutland@arm.com,
        linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
        andriy.shevchenko@intel.com, qi-ming.wu@intel.com,
        yixin.zhu@linux.intel.com, cheol.yong.kim@intel.com,
        rtanwar <rahul.tanwar@intel.com>
References: <cover.1587102634.git.rahul.tanwar@linux.intel.com>
 <42a4f71847714df482bacffdcd84341a4052800b.1587102634.git.rahul.tanwar@linux.intel.com>
 <159054541310.88029.5777794695153819198@swboyd.mtv.corp.google.com>
From:   "Tanwar, Rahul" <rahul.tanwar@linux.intel.com>
Message-ID: <c91ec0e0-5a16-2e28-dae0-4219f5f5340f@linux.intel.com>
Date:   Wed, 27 May 2020 11:53:14 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101
 Thunderbird/68.8.1
MIME-Version: 1.0
In-Reply-To: <159054541310.88029.5777794695153819198@swboyd.mtv.corp.google.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


Hi Stephen,

On 27/5/2020 10:10 am, Stephen Boyd wrote:
> Quoting Rahul Tanwar (2020-04-16 22:54:47)
>> diff --git a/drivers/clk/x86/clk-cgu.c b/drivers/clk/x86/clk-cgu.c
>> new file mode 100644
>> index 000000000000..802a7fa88535
>> --- /dev/null
>> +++ b/drivers/clk/x86/clk-cgu.c
>> @@ -0,0 +1,636 @@
> [...]
>> +       ctx->membase = devm_platform_ioremap_resource(pdev, 0);
>> +       if (IS_ERR(ctx->membase))
>> +               return PTR_ERR(ctx->membase);
>> +
>> +       ctx->np = np;
>> +       ctx->dev = dev;
>> +       spin_lock_init(&ctx->lock);
>> +
>> +       ret = lgm_clk_register_plls(ctx, lgm_pll_clks,
>> +                                   ARRAY_SIZE(lgm_pll_clks));
>> +       if (ret)
>> +               return ret;
>> +
>> +       ret = lgm_clk_register_branches(ctx, lgm_branch_clks,
>> +                                       ARRAY_SIZE(lgm_branch_clks));
>> +       if (ret)
>> +               return ret;
>> +
>> +       ret = lgm_clk_register_ddiv(ctx, lgm_ddiv_clks,
>> +                                   ARRAY_SIZE(lgm_ddiv_clks));
>> +       if (ret)
>> +               return ret;
>> +
>> +       ret = devm_of_clk_add_hw_provider(dev, of_clk_hw_onecell_get,
>> +                                         &ctx->clk_data);
>> +       if (ret)
>> +               return ret;
> Are any of the clks unregistered on failure? It looks like devm_ isn't
> used for registration so nothing can be undone? Please fix this in a
> future patch.

Thanks a lot for accepting the patch series. I went through all of your
comments and i agree with all of them. Will fix it & address other
review concerns in a future patch once 5.8 is released.

Regards,
Rahul