Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932799AbWCQVuJ (ORCPT ); Fri, 17 Mar 2006 16:50:09 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932802AbWCQVuJ (ORCPT ); Fri, 17 Mar 2006 16:50:09 -0500 Received: from mxout.hispeed.ch ([62.2.95.247]:10916 "EHLO smtp.hispeed.ch") by vger.kernel.org with ESMTP id S932799AbWCQVuH (ORCPT ); Fri, 17 Mar 2006 16:50:07 -0500 From: Daniel Ritz To: "Lanslott Gish" Subject: Re: [RFC][PATCH] USB touch screen driver, all-in-one Date: Fri, 17 Mar 2006 22:50:15 +0100 User-Agent: KMail/1.7.2 Cc: "Greg KH" , "Dmitry Torokhov" , linux-kernel , linux-usb , tejohnson@yahoo.com, hc@mivu.no, vojtech@suse.cz References: <38c09b90603100124l1aa8cbc6qaf71718e203f3768@mail.gmail.com> <200603152253.24194.daniel.ritz-ml@swissonline.ch> <38c09b90603161846n47b5d47fnc6b4d4b9ff2d078b@mail.gmail.com> In-Reply-To: <38c09b90603161846n47b5d47fnc6b4d4b9ff2d078b@mail.gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200603172250.16667.daniel.ritz-ml@swissonline.ch> X-DCC-spamcheck-01.tornado.cablecom.ch-Metrics: smtp-06.tornado.cablecom.ch 32700; Body=8 Fuz1=8 Fuz2=8 Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2739 Lines: 78 On Friday 17 March 2006 03.46, Lanslott Gish wrote: > On 3/16/06, Daniel Ritz wrote: > > On Wednesday 15 March 2006 05.30, Lanslott Gish wrote: > > > did you mean like that? thx. > > > > > > regards, > > > > > > Lanslott Gish > > > =================================================================== > > > --- linux-2.6.16-rc6.patched/drivers/usb/input/usbtouchscreen.c > > > +++ linux-2.6.16-rc6/drivers/usb/input/usbtouchscreen.c > > > @@ -49,6 +49,13 @@ > > > static int swap_xy; > > > module_param(swap_xy, bool, 0644); > > > MODULE_PARM_DESC(swap_xy, "If set X and Y axes are swapped."); > > > +static int swap_x; > > > +module_param(swap_x, bool, 0644); > > > +MODULE_PARM_DESC(swap_x, "If set X axe is swapped before XY swapped."); > > > +static int swap_y; > > > +module_param(swap_y, bool, 0644); > > > +MODULE_PARM_DESC(swap_y, "If set Y axe is swapped before XY swapped."); > > > + > > > > > (i prefer invert_x and invert_y...) > > > "invert" is great, thx. > evtouch(X11 driver) called these swap_x and swap_y > i think i drop it alltogether. as greg already mentioned it should be sysfs attributes. ( besides it's completely doable in userspace. and evtouch can do it. ) > > > > > > /* device specifc data/functions */ > > > @@ -224,13 +231,17 @@ > > > * PanJit Part > > > */ > > > #ifdef CONFIG_USB_TOUCHSCREEN_PANJIT > > > + > > > static int panjit_read_data(char *pkt, int *x, int *y, int *touch, int *press) > > > { > > > - *x = pkt[1] | (pkt[2] << 8); > > > - *y = pkt[3] | (pkt[4] << 8); > > > + *x = (pkt[1] & 0x0F) | ((pkt[2]& 0xFF) << 8); > > > + *y = (pkt[3] & 0x0F) | ((pkt[4]& 0xFF) << 8); > > > > that just can't be right. you probably mean > > + *y = pkt[3] | ((pkt[4] & 0x0F) << 8); > > > > otherwise you mask out bits 4-7. but you want to limit it to 12 bits... > > (btw. no need for the & 0xFF mask since *pkt is char) > > > > you are right, sorry for my fault. the truely way is > > + *x = (pkt[1] & 0xFF) | ((pkt[2] & 0x0F) << 8); > + *y = (pkt[3] & 0xFF) | ((pkt[4] & 0x0F) << 8); > > still need 12 bits( 0x0FFF) and the masks to avoid get negative. my latest patch has it right. and no, you don't need the mask for the lower 8 bits, only for the upper 4. > > > BTW, may i also suggest add more module_param to max_x, max_y, min_x, min_y ? > i think these options is useful, too. no chance. (and if i remember correctly it's possible via evdev ioctl) rgds -daniel - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/