Received: by 2002:a25:ef43:0:0:0:0:0 with SMTP id w3csp585500ybm; Wed, 27 May 2020 03:03:29 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxryUYWKjsAfIzs0Djp4PgK2eJCzn7rknmTzvZHpXOy9RnJ0/2oJLlhykzrYFBG3cnO2SrO X-Received: by 2002:aa7:c418:: with SMTP id j24mr23750315edq.313.1590573808962; Wed, 27 May 2020 03:03:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1590573808; cv=none; d=google.com; s=arc-20160816; b=kWY9VN8qsw2TifVHTvZyJBNXDVwCZxXN89X0+KE2bcbh+R4trKLKM15mDlzdf2yx5m 0ROiWe8hZqEIpUYiVd93IgGO66AzpCKmNS/1z+raBeUe78yBzlK26SUHsHKa/wSa5v5q sCGffLeJzoXXBTgpL4fuThitrpAPuIqMOvrIinmipSvacKJpaatCaoEm2JGWHxxi7s7d eoztGH5R9Oqq1Lv9MLW3TfxZCOgJF0806VwYDM80EEV+OCwmwVBcBtrUaXcYqAj4l5iE f0ZWJznKEApjzMDWWZJToMdL+BFvfBRMgTYZmDUAe4PBXO2gxCdn+viMX9qTxhF0Y7JZ dpcw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=xPVRACJy9fFBJNoGOwzbsY+OhDOM+ZzlmVRKhKxtA14=; b=cnt8pLSsklVuBHrLLCYIgqSQXn65oQFz6EGvaLULbwKSZ9n4RQGM8LrIFeE4sN7o0L ZqjMMZY49+1kuiaB6yadRKsEXNWl+MH9pE/Ci59VMBZym0qBAGzk96IZxi5tx9cIMMSD /lMzGcOhVRv3IUORxCSJf5QOzICMwn5W9iVa+L0gXFAXyF7xH61RiW4dw+KGllerQxbG wjpvrwpIy3Gmu4U+M7r6TSZq2bV90UNcBPP2xhw3frjnqOazb29SlNBhoNkNXKMKDzh+ O5nUJuaUWL+X96OGx4TNyVQ10tKJCpwqCDdrLRR/dUC+Vuxfuj+ykL26iHBDUSqKORCq izQw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id h17si1799797eji.347.2020.05.27.03.03.06; Wed, 27 May 2020 03:03:28 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728075AbgE0GTC (ORCPT + 99 others); Wed, 27 May 2020 02:19:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53054 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725267AbgE0GTB (ORCPT ); Wed, 27 May 2020 02:19:01 -0400 Received: from shards.monkeyblade.net (shards.monkeyblade.net [IPv6:2620:137:e000::1:9]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CC09CC061A0F; Tue, 26 May 2020 23:19:01 -0700 (PDT) Received: from localhost (unknown [IPv6:2601:601:9f00:477::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 9CD37127F35C6; Tue, 26 May 2020 23:19:00 -0700 (PDT) Date: Tue, 26 May 2020 23:18:59 -0700 (PDT) Message-Id: <20200526.231859.398097568630300979.davem@davemloft.net> To: alexander.sverdlin@nokia.com Cc: netdev@vger.kernel.org, edumazet@google.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH] macvlan: Skip loopback packets in RX handler From: David Miller In-Reply-To: <20200526122751.409917-1-alexander.sverdlin@nokia.com> References: <20200526122751.409917-1-alexander.sverdlin@nokia.com> X-Mailer: Mew version 6.8 on Emacs 26.3 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 26 May 2020 23:19:00 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Alexander A Sverdlin Date: Tue, 26 May 2020 14:27:51 +0200 > From: Alexander Sverdlin > > Ignore loopback-originatig packets soon enough and don't try to process L2 > header where it doesn't exist. The very similar br_handle_frame() in bridge > code performs exactly the same check. > > This is an example of such ICMPv6 packet: ... > Call Trace, how it happens exactly: > ... > macvlan_handle_frame+0x321/0x425 [macvlan] > ? macvlan_forward_source+0x110/0x110 [macvlan] > __netif_receive_skb_core+0x545/0xda0 ... > Signed-off-by: Alexander Sverdlin Applied to net-next, thanks.