Received: by 2002:a25:ef43:0:0:0:0:0 with SMTP id w3csp620323ybm; Wed, 27 May 2020 04:03:28 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwTKzS58kqWCZ0grbbDfyNBBnzMXhfBUZPpGnntH6QYNSGJxH2dlCBTMe39Y+y+V1jHKJQP X-Received: by 2002:a17:906:b817:: with SMTP id dv23mr3373883ejb.185.1590577408155; Wed, 27 May 2020 04:03:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1590577408; cv=none; d=google.com; s=arc-20160816; b=BZyhTTo0wRkzZ6mSKQsp0OCe+2wl++f0rqv1VePeAPIuu3rVGrzrjHSrIseWmC5Rxk Vy+c7eEHPV5kvwNtLdx8ishYojkUJiC1aAMxF6KJy4rkgRrJ1LAwy0qIgJmo2IsVPMGl /q8SFvyr3z2nnbylSVUkeT0OhOv7OWz2ItUEfgZEtNxxxFz9OEZTllTVh6c8gaHOw8uR CD3AS82oCPtq6x5AKMoTe5vVezRa3utz2GVTQtOtsT2GO/jtWqsmSP6IqWJ3Ehz40zP7 lAVOn9u9cLmibXfH6blSU14daRmKuXqhPXd3WNJSOkSYIXIGtbAxA/FAxE6YT0NKiZcH E1eA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=/Z2IFpwXCCw7IjOefH/qQAgu0CPZL8WWzPI10NwmY4A=; b=aveieCNG17Xkdex6GFiU5IEOdgiedX/ehlA23y/F6H3B/KzqcZADD/hd4BQVCpQexM cDvollLEAGoEtwq7U0H7GOUA26+LXfuZEVv4o+dj9KAXUDtTGH8NjcCij/D6r1fYZTdi HGo4cfOVX14LK+KWs2FJfGJTBusLSipHa3KwqUbf0BwweuDas5RDF/bYwITYRojXNpax ejNQ9hbBYBFjRaZDtuLCWeAj/njDiV77gv7IbVJAQRhtH4C9JdpX0mLTrbB5BcGvvkY3 3efMo4W92p8uCVa3SAGXZ7CSrppH/5SJ31u60cPRg4pgzzaaoyjRQZxStaHymE8d+jLu za9A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@cirrus.com header.s=PODMain02222019 header.b=a5dyhoCv; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=cirrus.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id p3si1591992ejn.151.2020.05.27.04.03.03; Wed, 27 May 2020 04:03:28 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@cirrus.com header.s=PODMain02222019 header.b=a5dyhoCv; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=cirrus.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729549AbgE0I26 (ORCPT + 99 others); Wed, 27 May 2020 04:28:58 -0400 Received: from mx0b-001ae601.pphosted.com ([67.231.152.168]:46872 "EHLO mx0b-001ae601.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729349AbgE0I25 (ORCPT ); Wed, 27 May 2020 04:28:57 -0400 Received: from pps.filterd (m0077474.ppops.net [127.0.0.1]) by mx0b-001ae601.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 04R8LbhT023059; Wed, 27 May 2020 03:27:56 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cirrus.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=PODMain02222019; bh=/Z2IFpwXCCw7IjOefH/qQAgu0CPZL8WWzPI10NwmY4A=; b=a5dyhoCv/6DPxj5fo2SGX0JkkdUBxS0rsnSqVsPOHKh1aHARRnvT+DpKJCmJ6/6XpyVx GS7ZuShlhnWa6uMoFpaMXrU/RldJW6s9TxMsjvfbGkUETNghYW2vbD1Awt+FHBr4jm9T ZQ07zadzs8G7aiWtd09mKFQpEOAEgyKNlLeh8uiNUPuCvssZ7DnY1TLypo539Hn6rOZk MJgxCqGIzqArZZ89fhXZPUsem929Y/argHYnC+J3MaNWADXDdu8AsYVbhYHv57q4iym4 xo5RvXmLoETvL2ImxMXN5866J3xCEOY8wv5vaiB6GLTRZDTGayTj+XW7rdlkRSPW7eTL UQ== Authentication-Results: ppops.net; spf=fail smtp.mailfrom=ckeepax@opensource.cirrus.com Received: from ediex02.ad.cirrus.com ([87.246.76.36]) by mx0b-001ae601.pphosted.com with ESMTP id 31708pw10m-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT); Wed, 27 May 2020 03:27:56 -0500 Received: from EDIEX01.ad.cirrus.com (198.61.84.80) by EDIEX02.ad.cirrus.com (198.61.84.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1913.5; Wed, 27 May 2020 09:27:55 +0100 Received: from ediswmail.ad.cirrus.com (198.61.86.93) by EDIEX01.ad.cirrus.com (198.61.84.80) with Microsoft SMTP Server id 15.1.1913.5 via Frontend Transport; Wed, 27 May 2020 09:27:55 +0100 Received: from ediswmail.ad.cirrus.com (ediswmail.ad.cirrus.com [198.61.86.93]) by ediswmail.ad.cirrus.com (Postfix) with ESMTP id 2005D2AB; Wed, 27 May 2020 08:27:55 +0000 (UTC) Date: Wed, 27 May 2020 08:27:55 +0000 From: Charles Keepax To: Dinghao Liu CC: , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Thomas Gleixner , Enrico Weigelt , Kate Stewart , Shengjiu Wang , , , Subject: Re: [PATCH] ASoC: wm8962: Fix runtime PM imbalance on error Message-ID: <20200527082755.GI71940@ediswmail.ad.cirrus.com> References: <20200527024625.9937-1-dinghao.liu@zju.edu.cn> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20200527024625.9937-1-dinghao.liu@zju.edu.cn> User-Agent: Mutt/1.5.21 (2010-09-15) X-Proofpoint-SPF-Result: fail X-Proofpoint-SPF-Record: v=spf1 include:spf-001ae601.pphosted.com include:spf.protection.outlook.com ip4:5.172.152.52 -all X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=18 phishscore=0 adultscore=0 bulkscore=0 malwarescore=0 lowpriorityscore=0 clxscore=1011 mlxscore=0 spamscore=0 mlxlogscore=945 cotscore=-2147483648 priorityscore=1501 impostorscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2004280000 definitions=main-2005270063 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 27, 2020 at 10:46:22AM +0800, Dinghao Liu wrote: > pm_runtime_get_sync() increments the runtime PM usage counter even > the call returns an error code. Thus a pairing decrement is needed > on the error handling path to keep the counter balanced. > > Signed-off-by: Dinghao Liu > --- Acked-by: Charles Keepax Thanks, Charles