Received: by 2002:a25:ef43:0:0:0:0:0 with SMTP id w3csp813156ybm; Wed, 27 May 2020 08:37:10 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzSEVPpX8/fxNnXhfPkHpgmNqFiquee7auIsBrE0YD3B9Sq7h9dPBHPaiuMqEBwfkCZfOPD X-Received: by 2002:a17:906:c401:: with SMTP id u1mr6487381ejz.151.1590593829985; Wed, 27 May 2020 08:37:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1590593829; cv=none; d=google.com; s=arc-20160816; b=tE+71pVfwnZFBdxep28J3qxzHNs6PsJj5Q5YomrATj88F+tynYhpPJYR7RfIL/YD+c GY4cz/FVl++8AArrv+NvQ9FZMm1BkDdrnvzBgMpi2bdZhqHGZYPfYFQVF5T5UdPz6COc qbHsAhhpWRnPnZrxIqAZAam6USwbpqT82KEfNbVeFvDlhavYX10a4iA3N2J0FKTd4iVA LjIovBtkKbpcQJFj1w3S2KErtBUAmNvwMVtnzf3PFfrJUIWsJzkpAjY87GjOshW4nRty Xw940d/2avntGuYAfoVO5Y56Rb8CrD+m2ypjL+7L3sIAI7OP4beF/KqNJhtN0BBJcHGS 1jJA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=+ZMb7ayskfYmUMDD9vA/QW3XXA6gbYOmgUP9dQQUd5U=; b=RvZuNCybl71BrlN0rdVzanXJz8HKy4ofcDSd6lQSSKR+zYo4Z4FxUm27JpGR34v4iX OYH86ARTyRwQsN5GfBzXr5uFqt3Y5GfS//FXaZgQrFkqSptkf14sqRdCNqlKPTgHIDOU F4U0UKrhUkwf6k4fkipui/XDzLqVxZXJYJ3/bUOxYfLF3MdBV6H63G5MZRd09H1KE38K B4Xh6b/nQr5YtETU5kPLN2jOLxHINvMPOH82bKXqDdZQlgQbk9lhPqqqArPeZNxMwrcG nVMNdSHue2cwGpMl2IuWBNnmX3H8otrWcwPsaHETPk+LWjPokTU26SR4fUOp7Kxe/rEw KDPg== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=merlin.20170209 header.b=mP8NX0pu; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id l10si1084151edi.562.2020.05.27.08.36.47; Wed, 27 May 2020 08:37:09 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=merlin.20170209 header.b=mP8NX0pu; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729873AbgE0KeI (ORCPT + 99 others); Wed, 27 May 2020 06:34:08 -0400 Received: from merlin.infradead.org ([205.233.59.134]:53414 "EHLO merlin.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728983AbgE0KeG (ORCPT ); Wed, 27 May 2020 06:34:06 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=merlin.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=+ZMb7ayskfYmUMDD9vA/QW3XXA6gbYOmgUP9dQQUd5U=; b=mP8NX0puwAj0/ZU6+jWX/0WQ3e 8ygp9uA3lrNb4s3vGm00FjArWHocZnsNIRCZ4XB4DwqarHYo/Cs2MWU6GDuB3mmwmYzD43iHHL9cA x2SB+T0aw3iNHL5ZflXtVA7xWGHZi+yFYohUH89W51GojX3uyfRT8AJHdCKkFDxiNrSZXiXLGfOEf GKZ2Lc+1zS6NBRgmh8XsYqT3QlJVdX17eBX9UAepbGAV06PgsW87eHEZvnKH3q91j2Zp3Vsz1XxeH arsw0vw7sEkXS+RVmXZo8KiZz08FACCrhtvcF+F4JlIuvhx3vSWPMEUgT7Ji2XXWvWRYWzrLd3HmG AgV/5NfA==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=noisy.programming.kicks-ass.net) by merlin.infradead.org with esmtpsa (Exim 4.92.3 #3 (Red Hat Linux)) id 1jdtLh-000180-96; Wed, 27 May 2020 10:31:49 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id 88892300478; Wed, 27 May 2020 12:31:47 +0200 (CEST) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id 689CB2BD9C2B9; Wed, 27 May 2020 12:31:47 +0200 (CEST) Date: Wed, 27 May 2020 12:31:47 +0200 From: Peter Zijlstra To: Andi Kleen Cc: Kees Cook , Greg KH , x86@kernel.org, linux-kernel@vger.kernel.org, sashal@kernel.org, Andi Kleen , stable@vger.kernel.org Subject: Re: [PATCH v1] x86: Pin cr4 FSGSBASE Message-ID: <20200527103147.GI325280@hirez.programming.kicks-ass.net> References: <20200526052848.605423-1-andi@firstfloor.org> <202005260935.EB11D3EB7@keescook> <20200526231423.qcsolcpll534sgro@two.firstfloor.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200526231423.qcsolcpll534sgro@two.firstfloor.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 26, 2020 at 04:14:25PM -0700, Andi Kleen wrote: > > And if this is going to be more permanent, we can separate the mask > > (untested): > > The FSGSBASE one should not be permanent, it will be replaced > with the full FSGSBASE patches that set that bit correctly. Well, even with full FSGSBASE patches on, that CR4 bit should never get changed after boot.