Received: by 2002:a25:ef43:0:0:0:0:0 with SMTP id w3csp819633ybm; Wed, 27 May 2020 08:46:13 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwTP7Z1BwBaCmIyWHQoS+YyIB7txUw7sokevIgVnwDbnu5SF3V7f3OAVyoFTlh6NPqMgsXz X-Received: by 2002:a50:ed03:: with SMTP id j3mr1857440eds.250.1590594373395; Wed, 27 May 2020 08:46:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1590594373; cv=none; d=google.com; s=arc-20160816; b=DB/E4SN1OioxQxBELFqLztJmoEFtxh2pGazggbFlH3ar+S0nEm3tf1av7MlN4BYWNe h81sp3p0AKaX7OQwiJbL3ScnUZNIoaWSJSkalZn4aS7gtxgx86LLDFaa8FzlgL2HN9vJ iuxHWsgE2hTu5xmWcGiBY4zGMDPNk/4GbMeC1/8tMleiC8/EigIOPxorxm1khsVaTBoT ZW/haRNhYOjzSECClNLqcU7Uo4Hiz2fzLkZD8wfcuRQ3bZUJnO5Tnj2CcF4mKeJGQP3u ZLxEl8PtEK9APE5nAn/YM1xCL+EtkW6tYZhq9/u1+eVIdqh/BC4hw2Wgmq2gbXO/wIt9 o8RA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=kVEJK+6u7nnAm/woNunENElPw5UQMbPlEwwFNbLyCQo=; b=ZzVvPa/TrGiWRaDFWQjFnBrpA1yWHrxbSoLRdBG3dYtA2IUZF3Gifie+sw+am1pjrT 2HKoAB2XJaeoB1ffhHg47k3SUqGNxNo1nCu8CloIfjE9WZH5nygop1h/9Eve1pQLPb8R TFJ+QxViWMDCPfx3iuptZiLlCN56gSIs1Hh7m+edcpwp21pG5VFHvMrbMqVMcB5YidKU L1j29Fr6j+h3ZSYyNxJSGgbJGG6zh7TG8IU5SYaXHkgD/TH1/4L8uASnMh/fyWpWeouz sNE0COIWlL03/qO5HBsVq/w3U3KJQP2IIQ3fQJZyYFQuENHrpso0PZ7L5YkDtv2h3e+N Lddw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=RJY9LUFf; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id b21si2098757eju.737.2020.05.27.08.45.50; Wed, 27 May 2020 08:46:13 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=RJY9LUFf; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725883AbgE0L2C (ORCPT + 99 others); Wed, 27 May 2020 07:28:02 -0400 Received: from mail.kernel.org ([198.145.29.99]:59632 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726065AbgE0L2B (ORCPT ); Wed, 27 May 2020 07:28:01 -0400 Received: from localhost (fw-tnat.cambridge.arm.com [217.140.96.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id DE186207D3; Wed, 27 May 2020 11:28:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1590578881; bh=ef/jJPV9ByXtDirUxMky79f/X31SPpgZBquKZf4ExGg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=RJY9LUFfHCypglbuznceow9Hw1fql7iGoKCpk7ydeFGTRHjnp11jxf5g4owd2Cu3g itrvhN5P5c8PfdjW2ak56F3khIJ3z4UQGG+M3pUr/L7g6iSO6FfO5WP9i5dUxNfm6W IQzLRr9RP7/vfapSeVgVqbwwy2Ix4404Ii47l1IU= Date: Wed, 27 May 2020 12:27:59 +0100 From: Mark Brown To: Akshu Agrawal Cc: yuhsuan@chromium.org, Liam Girdwood , Jaroslav Kysela , Takashi Iwai , YueHaibing , Kuninori Morimoto , "moderated list:SOUND - SOC LAYER / DYNAMIC AUDIO POWER MANAGEM..." , open list Subject: Re: [PATCH] ASoC: AMD: Use mixer control to switch between DMICs Message-ID: <20200527112758.GE5308@sirena.org.uk> References: <20200527014023.2781-1-akshu.agrawal@amd.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="imjhCm/Pyz7Rq5F2" Content-Disposition: inline In-Reply-To: <20200527014023.2781-1-akshu.agrawal@amd.com> X-Cookie: Drop in any mailbox. User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --imjhCm/Pyz7Rq5F2 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, May 27, 2020 at 07:10:16AM +0530, Akshu Agrawal wrote: > + SOC_SINGLE_BOOL_EXT("Front Mic", 0, front_mic_get, front_mic_set), This should probably be a mux with two labelled options, or if it's a boolean control it should end in Switch. A mux definitely seems like a better option though. --imjhCm/Pyz7Rq5F2 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl7OTr4ACgkQJNaLcl1U h9DRYgf/akrvrra3kUeV1yqD3LwP+z/Awi1I/4x2sgSYHYzVEF60MkdDjY8+nYNZ YMvWIEcZYxu7AuOR6dKmzK6ogV0E2dTfiy4IaiftYE+FpFjVQSLml2E258WF4Fyl 5Uz7BzoBvRT/t3YseDiZ1MPR/PiA/RbA38oiE//OKqLNQvEo+TZFf6Z/mzh6v7Fy BhN9D7wbAIWk9LNzvlx/F4w+W9oOc822A573binK00Ye7oTZGz1jr1hZ16nzOTha BmwljhOAM2VQW9Lly8uz3DfHP/P8z1X/Y09/EoTiEiH83v59zVL3vh3s4GrcFX/m JUsmP5670wkUeRvmMe4muY+0ReOj7w== =YKkv -----END PGP SIGNATURE----- --imjhCm/Pyz7Rq5F2--