Received: by 2002:a25:ef43:0:0:0:0:0 with SMTP id w3csp819749ybm; Wed, 27 May 2020 08:46:20 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzkgjk7z+ZGWvqTZn7TQ3vf7Q4Cv0S/WeeQ3InPClhyweg+9dNYrFgV+9mTgVCjWk5sT2IZ X-Received: by 2002:a17:906:3607:: with SMTP id q7mr6427386ejb.81.1590594380565; Wed, 27 May 2020 08:46:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1590594380; cv=none; d=google.com; s=arc-20160816; b=Q+4UtETlM9VXxPIt0OGackqFz0BYhRUftvjK9NF8MKOVgWXkitW1ouSn06M4kt8nH7 J49xndmBkXC4oRBxhA4hjKWsWR8rL6hr0Dikf/GBZalEAia0wMTwwN4bx8lAMzaweJCR rRIH+bI+LUtvHaqMDi8mZs1ULKKJqpCbYkhPPmpqsHKIEvccL6/6F6MmmlSdfDHPJSRZ zf6xF8eCxcQX/nZnzKvwAxq5yaKp2OcdgiHrktqDV6NyDA+IJagHA8nOGbYFnusqKPTf MDjkHgWCcpwFPsrZo9gJFAU0STXkizotEzg93xo0ZeSWBwYIgEftMWOzEPnYx2HBfhU0 oobA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=L3VG+r4IL3PqDE0NrR8AJTqa7Bz6Bcn6dDbe0ZST8RI=; b=G1wTgiS4QdgIguGlGEXgHc85GsfNsfwaDpMzNtKtSMPbvCKYfexbsdQCzCGHjPorye q2d4kQiXeyjCqLbwFs8IgXdTszAnJoa5UBKTfYYEOXQRNJCmuLjfY9ikKu3KJDwbLjNy 5pgugv2LSpNkS1ktmi4j9CK4dR4rm/f1KWj0cU5fd4FFvN6X01JpjPjRPa2yAUWhb8Gr LTmZQrVlAOYJXDBRNFP2f+8ETyzsjOJ0GPVP8oSKI8PzyMJa/3Js9BbhiximYnhASGTg kwK+FebGgjfdVbx6DlWTlihbkVoTyfCk0A+/ySgnoS6cLBtHK7O318k2OccHI+iaZsVA Oe7A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=Zdeqej5Y; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id x16si2153338edi.31.2020.05.27.08.45.57; Wed, 27 May 2020 08:46:20 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=Zdeqej5Y; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728264AbgE0LcL (ORCPT + 99 others); Wed, 27 May 2020 07:32:11 -0400 Received: from us-smtp-1.mimecast.com ([207.211.31.81]:20709 "EHLO us-smtp-delivery-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725964AbgE0LcL (ORCPT ); Wed, 27 May 2020 07:32:11 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1590579130; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=L3VG+r4IL3PqDE0NrR8AJTqa7Bz6Bcn6dDbe0ZST8RI=; b=Zdeqej5YIcLpUNlskfRACMBF4zIcuzBgzFm/o8+sFqQ1W2iIN52yznXAfhtQ+bNFVpFJrN sMOF1LnlWhv7s7B76mVOb3t1+gu8lbjFpf+m4X/fk5Fq232PW1NBbxZWMqXApD4a8MMY4a a2ngxFunoS407FRle+iLwx5as7PMiPI= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-339-JcGnGmc4PV2vYDXpIgofAA-1; Wed, 27 May 2020 07:32:06 -0400 X-MC-Unique: JcGnGmc4PV2vYDXpIgofAA-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id AA331461; Wed, 27 May 2020 11:32:02 +0000 (UTC) Received: from dhcp-27-174.brq.redhat.com (unknown [10.40.192.182]) by smtp.corp.redhat.com (Postfix) with SMTP id 66FED12A4D; Wed, 27 May 2020 11:32:00 +0000 (UTC) Received: by dhcp-27-174.brq.redhat.com (nbSMTP-1.00) for uid 1000 oleg@redhat.com; Wed, 27 May 2020 13:32:02 +0200 (CEST) Date: Wed, 27 May 2020 13:31:59 +0200 From: Oleg Nesterov To: Greentime Hu Cc: Guo Ren , Vincent Chen , Paul Walmsley , Palmer Dabbelt , linux-riscv , Linux Kernel Mailing List Subject: Re: [RFC PATCH v4 01/13] ptrace: Use regset_size() for dynamic regset size. Message-ID: <20200527113158.GA9100@redhat.com> References: <3700190a602a6d30fcbf76e1eea667e29a65c4c9.1590474856.git.greentime.hu@sifive.com> <20200526140027.GC24212@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/27, Greentime Hu wrote: > > It seems I only needs to update this line, right? > - kiov->iov_len = min(kiov->iov_len, (__kernel_size_t) (regset->n * > regset->size)); > + kiov->iov_len = min(kiov->iov_len, (__kernel_size_t) > regset_size(task, regset)); Yes, agreed. Oleg.