Received: by 2002:a25:ef43:0:0:0:0:0 with SMTP id w3csp820099ybm; Wed, 27 May 2020 08:46:50 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw7T0aiRHSNC7eSQsaWwGIrzyLip6/ZNE1iOlBMbBGyS5qzpeheFUMsY1qKHpUd8ms4fKSS X-Received: by 2002:a05:6402:3106:: with SMTP id dc6mr24366504edb.19.1590594410214; Wed, 27 May 2020 08:46:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1590594410; cv=none; d=google.com; s=arc-20160816; b=USGe+vHjTtVGqkOmI+aSfXxI8wKhdpFE2UTrq10WZoeEvLk6C74pYdBNp4hPOeXwg0 q1mWWjX5mVmwPPHrPwtiJkxIiWceQQNmGix70AUTPgffP1o9LwQ41hk6XnWYYD8MvCIu 06sVbjrZek6Yq9WFor+lME+1VEs0YyQl4vTtAnU2sbC6DwP5ZOr479HkXvCxWjounNbg YaGzx95sa5of9k5sN6Lqqct1HHxAeMDTQqEse0sI2KA5M8QMDghje2oxvAmXGUJhyPmq tKlb5lj+3fsGLJlP7u0h9MTwrnHhEuoEvwABKhJJVf+mDmHwXFbadNt9Sy6QWZ/9Dm35 c5Lw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature; bh=sZeKxoqsJfHmJKWaGZ+FoPVmzG1uJu0Aa8XuYZUp/Ew=; b=hrjtdTTiBqu/fuKgacKYwg0869GAa6tswje677YCcBEXpAyxWVwpv3o/EU2E/zsBGH 8rqLXfZhzZMt79M7nyPuqcEEKPLTuSJvvD3VFQzvBSC2yGtUKKzeDrKCBVsHmJlCev38 8yCia2xTv/+A+renkML4SBknWSOlPIamL2f576NYoSItsD9Arpx/UQt89Xmu/JYyujTO R7NpxOQ/ZrEocExF74LalPhreDa/nTMFxzJoqo3IXZ5KYfPW71kBCYvF0SgJce2ZSSJL O1tCzKpm+2/H9Ysb26D7bRetoQtqSA3Cw+J4Lj1ZFDhmyT2V5SN4+Nwg9R3CjfdqSU8w aTRw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel-dk.20150623.gappssmtp.com header.s=20150623 header.b="VgXBx/n9"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id l16si1784693edv.461.2020.05.27.08.46.26; Wed, 27 May 2020 08:46:50 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel-dk.20150623.gappssmtp.com header.s=20150623 header.b="VgXBx/n9"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726942AbgE0Lmj (ORCPT + 99 others); Wed, 27 May 2020 07:42:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46656 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726600AbgE0Lmh (ORCPT ); Wed, 27 May 2020 07:42:37 -0400 Received: from mail-pl1-x62a.google.com (mail-pl1-x62a.google.com [IPv6:2607:f8b0:4864:20::62a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D5F5CC03E97A for ; Wed, 27 May 2020 04:42:36 -0700 (PDT) Received: by mail-pl1-x62a.google.com with SMTP id y11so1757048plt.12 for ; Wed, 27 May 2020 04:42:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=sZeKxoqsJfHmJKWaGZ+FoPVmzG1uJu0Aa8XuYZUp/Ew=; b=VgXBx/n9QvB+YvDn6NYJLz6oVH59pjcPxJRh65BhLU3L7ZuClmM3L2k6D/626PY954 QQyeqbu8PgPXQCenizXc2i0fC76rQLs8Wigkf4p7SMgbycDSZCVefXPmN+8UV1pawScy A2EFa4ZQzatLH1XSkfSK5ym9JQ6jWznNerWZ2LgW+2s1KfuNPJGOAi6T/vXRasdxGG5O KuIlKlb5pj0K1QBhbpZ77dep0qpYB5q901mYzXB6eaxxX+5v0gV/Js8+y+LOrYVQC57G xNoyGX2CFF0yNvJxOJQSSqMfHZ+KtdVhLsAgGn6KSWyP6rnnd7SyNkWQQHHdVyiC4nC7 N0gQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=sZeKxoqsJfHmJKWaGZ+FoPVmzG1uJu0Aa8XuYZUp/Ew=; b=Ow0XhqKQgAWeDIVnF+KdhuMxVa+ZWiIA+0kACzZeXlGxysV78CGCGL7Hxi9tdqpwXf THFQVrh4NblAkGxgvgM3PDd81mFGqYX35h63JvcRfmoiONn+hgiJuBotxB8YvIh/8xzx XLg2oDUh6cWhVv4wioi/5rXVhE26DH/+uaZR+83WONHf/JmLu7V0bVW79ARFN1RBWhVP naFyFjm4XeYE3UU0NmM9r0Kov4iORDybTc0oAYDW17kEUvFoiFDCgpMR/EEY2e1dF1ER HAiPaQ58Hs/t48uUt13s8aU1NeHNh2tpe6PtQdUf2DYMTF5pJPhbfbSjZ1Yf349Hf4wa fD6A== X-Gm-Message-State: AOAM5334m9uyIq8Uz1QlwyZHk1KnzRbYXPwMgx7Jkk5036lMVBtAxw82 Ogsu5zsj8sXTVe6paArTik/vN4rE05MpbQ== X-Received: by 2002:a17:90a:26a7:: with SMTP id m36mr4607945pje.28.1590579756112; Wed, 27 May 2020 04:42:36 -0700 (PDT) Received: from ?IPv6:2605:e000:100e:8c61:2cc3:8599:f649:862c? ([2605:e000:100e:8c61:2cc3:8599:f649:862c]) by smtp.gmail.com with ESMTPSA id v9sm1981838pgj.54.2020.05.27.04.42.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 27 May 2020 04:42:35 -0700 (PDT) Subject: Re: [PATCH][next] block: blk-crypto-fallback: remove redundant initialization of variable err To: Colin King , linux-block@vger.kernel.org Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org References: <20200526224902.63975-1-colin.king@canonical.com> From: Jens Axboe Message-ID: Date: Wed, 27 May 2020 05:42:33 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: <20200526224902.63975-1-colin.king@canonical.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 5/26/20 4:49 PM, Colin King wrote: > From: Colin Ian King > > The variable err is being initialized with a value that is never read > and it is being updated later with a new value. The initialization is > redundant and can be removed. Applied, thanks. -- Jens Axboe