Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <7240b1f9ef497fd040c7315d90711c642f709d16.camel@redhat.com>
Subject: Re: KVM broken after suspend in most recent kernels.
From:   Maxim Levitsky <mlevitsk@redhat.com>
To:     Sean Christopherson <sean.j.christopherson@intel.com>,
        Brad Campbell <lists2009@fnarfbargle.com>
Cc:     kvm@vger.kernel.org,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Date:   Wed, 27 May 2020 15:28:50 +0300
In-Reply-To: <20200527051354.GL31696@linux.intel.com>
References: <1f7a85cc-38a6-2a2e-cbe3-a5b9970b7b92@fnarfbargle.com>
         <f726be8c-c7ef-bf6a-f31e-394969d35045@fnarfbargle.com>
         <1f7b1c9a8d9cbb6f82e97f8ba7a13ce5b773e16f.camel@redhat.com>
         <a45bc9d7-ad0b-2ff0-edcc-5283f591bc10@fnarfbargle.com>
         <20200527051354.GL31696@linux.intel.com>
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.36.2 (3.36.2-1.fc32) 
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, 2020-05-26 at 22:13 -0700, Sean Christopherson wrote:
> On Mon, May 25, 2020 at 09:15:57PM +0800, Brad Campbell wrote:
> > > When you mean that KVM is broken after suspend, you mean that you
> > > can't
> > > start new VMs after suspend, or do VMs that were running before
> > > suspend
> > > break?  I see the later on my machine. I have AMD system though,
> > > so most
> > > likely this is another bug.
> > > 
> > > Looking at the commit, I suspect that we indeed should set the
> > > IA32_FEAT_CTL
> > > after resume from ram, since suspend to ram might count as a
> > > complete CPU
> > > reset.
> > > 
> > 
> > One of those "I should have clarified that" moments immediately
> > after I
> > pressed send.  I've not tried suspending with a VM running. It's
> > "can't start
> > new VMs after suspend".
> 
> Don't bother testing suspending with a VM, the only thing that will
> be
> different is that your system will hang on resume instead when
> running a
> VM.  If there are active VMs, KVM automatically re-enables VMX via
> VMXON
> after resume, and VMXON is what's faulting.
> 
> Odds are good the firmware simply isn't initializing IA32_FEAT_CTL,
> ever.
> The kernel handles the boot-time case, but I (obviously) didn't
> consider
> the suspend case.  I'll work on a patch.

This is exactly what I was thinking about this as well.

Best regards,
	Maxim Levitsky
>