Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: CFd8xfY1BDnoW0Zu22Uj3KKYVv7C54bHiomKm5zwTNaxWOdxUYD1NgJ6P82SHT3pXtX1QUxqPl
 5YPR/ezXHhhg==
From:   SeongJae Park <sjpark@amazon.com>
To:     Leonard Foerster <foersleo@amazon.com>
CC:     SeongJae Park <sjpark@amazon.com>, <akpm@linux-foundation.org>,
        "SeongJae Park" <sjpark@amazon.de>, <Jonathan.Cameron@Huawei.com>,
        <aarcange@redhat.com>, <acme@kernel.org>,
        <alexander.shishkin@linux.intel.com>, <amit@kernel.org>,
        <benh@kernel.crashing.org>, <brendan.d.gregg@gmail.com>,
        <brendanhiggins@google.com>, <cai@lca.pw>,
        <colin.king@canonical.com>, <corbet@lwn.net>, <dwmw@amazon.com>,
        <irogers@google.com>, <jolsa@redhat.com>, <kirill@shutemov.name>,
        <mark.rutland@arm.com>, <mgorman@suse.de>, <minchan@kernel.org>,
        <mingo@redhat.com>, <namhyung@kernel.org>, <peterz@infradead.org>,
        <rdunlap@infradead.org>, <riel@surriel.com>, <rientjes@google.com>,
        <rostedt@goodmis.org>, <sblbir@amazon.com>, <shakeelb@google.com>,
        <shuah@kernel.org>, <sj38.park@gmail.com>, <snu@amazon.de>,
        <vbabka@suse.cz>, <vdavydov.dev@gmail.com>,
        <yang.shi@linux.alibaba.com>, <ying.huang@intel.com>,
        <linux-damon@amazon.com>, <linux-mm@kvack.org>,
        <linux-doc@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: Re: [PATCH v13 03/15] mm: Introduce Data Access MONitor (DAMON)
Date:   Wed, 27 May 2020 14:40:49 +0200
Message-ID: <20200527124050.18038-1-sjpark@amazon.com>
In-Reply-To: <1590578611-26983-1-git-send-email-foersleo@amazon.com> (raw)
MIME-Version: 1.0
Content-Type: text/plain
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, 27 May 2020 13:23:31 +0200 Leonard Foerster <foersleo@amazon.com> wrote:

> On 2020-05-25T11:15:00+02:00 SeongJae Park <sjpark@amazon.com> wrote:
> 
> > From: SeongJae Park <sjpark@amazon.de>
> > 
> > This commit introduces a kernel module named DAMON.  Note that this
> > commit is implementing only the stub for the module load/unload, basic
> > data structures, and simple manipulation functions of the structures to
> > keep the size of commit small.  The core mechanisms of DAMON will be
> > implemented one by one by following commits.
> > 
> > Signed-off-by: SeongJae Park <sjpark@amazon.de>
> > ---
> > [...]
> > +
> > +/**
> > + * struct damon_ctx - Represents a context for each monitoring.
> > + * @tasks_list:		Head of monitring target tasks (&damon_task) list.
> 
> nit: monitring -> monitoring

Good catch!  Will fix in the next spin.


Thanks,
SeongJae Park

> 
> Reviewed-by: Leonard Foerster <foersleo@amazon.de>
>