Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 27 May 2020 14:42:15 +0200
From:   Wojtek Porczyk <woju@invisiblethingslab.com>
To:     Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
Cc:     Don Porter <porter@cs.unc.edu>,
        Thomas Gleixner <tglx@linutronix.de>,
        Andi Kleen <ak@linux.intel.com>,
        Sasha Levin <sashal@kernel.org>, linux-kernel@vger.kernel.org,
        bp@alien8.de, luto@kernel.org, hpa@zytor.com,
        dave.hansen@intel.com, tony.luck@intel.com,
        ravi.v.shankar@intel.com, chang.seok.bae@intel.com
Subject: Re: Re: [PATCH v12 00/18] Enable FSGSBASE instructions
Message-ID: <20200527124215.GK14256@invisiblethingslab.com>
References: <20200511045311.4785-1-sashal@kernel.org>
 <0186c22a8a6be1516df0703c421faaa581041774.camel@linux.intel.com>
 <20200515164013.GF29995@sasha-vm>
 <c566b89cc3ef6c164160cc56a820abac3fd70839.camel@linux.intel.com>
 <20200518153407.GA499505@tassilo.jf.intel.com>
 <371e6a92cad25cbe7a8489785efa7d3457ecef3b.camel@linux.intel.com>
 <87v9ksvoaq.fsf@nanos.tec.linutronix.de>
 <20200519164853.GA19706@linux.intel.com>
 <7eb45e02-03bf-0af0-c915-794bf49d66d7@cs.unc.edu>
 <1276588f1ea395bdedf8b5e3af15666f0095dc0d.camel@linux.intel.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="Kynn+LdAwU9N+JqL"
Content-Disposition: inline
In-Reply-To: <1276588f1ea395bdedf8b5e3af15666f0095dc0d.camel@linux.intel.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


--Kynn+LdAwU9N+JqL
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, May 27, 2020 at 11:20:08AM +0300, Jarkko Sakkinen wrote:
> On Fri, 2020-05-22 at 16:14 -0400, Don Porter wrote:
> > legacy code in SGX.  We have been following LKML discussions on this=20
> > instruction for years, and hoping this feature would be supported by=20
> > Linux, so that we can retire this module.  To our knowledge, every SGX=
=20
>=20
> Why have you followed this for years and never tried the patches?

For all the reasons stated before (we preferred a module, not a patchset, a=
nd
we didn't really care about implications), and because the general situation
about kernel drivers is a mess: Intel made three, mutually incompatible lin=
ux
drivers [1] and we used SDK driver, which incidentally is also how people
learn SGX programming in general.

With three different drivers and unclear future directions, we chose to wait
and see how the situation settles, so we stuck to the driver that was alrea=
dy
working.

Also, we're no kernel developers and there were/still are more urgent things
to fix in the graphene proper. For example we only recently have support for
running non-debug enclaves using DCAP LE [2].

[1] Here are my notes from when I was figuring out:
    https://graphene.rtfd.io/en/latest/sgx-intro.html#linux-kernel-drivers

[2] https://github.com/oscarlab/graphene/issues/881
    https://github.com/oscarlab/graphene/pull/978

--=20
pozdrawiam / best regards
Wojtek Porczyk
Graphene / Invisible Things Lab
=20
 I do not fear computers,
 I fear lack of them.
    -- Isaac Asimov

--Kynn+LdAwU9N+JqL
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEaO0VFfpr0tEF6hYkv2vZMhA6I1EFAl7OYCgACgkQv2vZMhA6
I1EnzRAAreQQvrt9oGbSrtNJ9t2bQRyG5l0jT7OhCTRWX5Wtfkv6q5KO4IkRodbW
bBLhAs5kSo75oXiisJD+otDO03Do+wEeQIfGoPqewARqwPS90d/gcZUG7Wgyopvu
beFRssdIwjf3SM/0GpvnUyHKdq5Ewk0REyrY2yrUVnFX82J13Cg8REuDREtOOdra
HYeBwO84uRHGEG/Om3dBDRyujO0rWRB7w6etr6ZSEGhgPZV1Nq7fv/QMFCW0RTpm
NapBcgjnKNARZSYw+cy/PR5SFad0qTdluwN/g4OUE4Daei2/NwoXjvNkRAMI7DB8
itfPVPQqalunGSva2hWj1wwyGa3aToTsZGW/2wQXjijiDoaoGku49lg2DBkvphZs
CIieYeX1y2NY7PUozLGbLEZ/lEFLfPIJSanBYh1vIsM0Q+HKD/HCandC2mw7gNLD
QOH4LRflKm57UYhqtdokbQXKJAde992t+CMKtIg6snh/nIVo3HcIK0StQnMMdSn/
T/GXLxxA3I9SoKN1+Ua50Qww/SDXw7LX+isWcNv7fTUtLrn0i47O//m1OlsZ1Qj9
0qlRX5eec5xWmE/R+LwtVUSjGtLtpI4g5nWgpud/NVz6C8rcXVsTy1BeehrJCpXH
ZmmO6W+WKlG7C8XiBKL4HZyzQr0lLFhTQ2oz/pIksiehue5QP+E=
=rRZW
-----END PGP SIGNATURE-----

--Kynn+LdAwU9N+JqL--