Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20200527133924.724819-1-arnd@arndb.de>
In-Reply-To: <20200527133924.724819-1-arnd@arndb.de>
From:   Jens Wiklander <jens.wiklander@linaro.org>
Date:   Wed, 27 May 2020 17:07:24 +0200
Message-ID: <CAHUa44HXs_h5ZBizHXDtYWa9Ubk=64AgiM5zj7rGx0CxVcSbTA@mail.gmail.com>
Subject: Re: [PATCH] tee: fix crypto select
To:     Arnd Bergmann <arnd@arndb.de>
Cc:     soc@kernel.org,
        =?UTF-8?B?VmVzYSBKw6TDpHNrZWzDpGluZW4=?= 
        <vesa.jaaskelainen@vaisala.com>,
        Devaraj Rangasamy <Devaraj.Rangasamy@amd.com>,
        Rijo Thomas <Rijo-john.Thomas@amd.com>,
        Gary R Hook <gary.hook@amd.com>,
        Herbert Xu <herbert@gondor.apana.org.au>,
        "tee-dev @ lists . linaro . org" <tee-dev@lists.linaro.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Arnd,

On Wed, May 27, 2020 at 3:39 PM Arnd Bergmann <arnd@arndb.de> wrote:
>
> When selecting a crypto cipher, we also need to select the
> subsystem itself:
>
> WARNING: unmet direct dependencies detected for CRYPTO_SHA1
>   Depends on [m]: CRYPTO [=m]
>   Selected by [y]:
>   - TEE [=y] && (HAVE_ARM_SMCCC [=n] || COMPILE_TEST [=y] || CPU_SUP_AMD [=y])
>   Selected by [m]:
>   - CRYPTO_DEV_QAT [=m] && CRYPTO [=m] && CRYPTO_HW [=y]
>   - CRYPTO_DEV_MEDIATEK [=m] && CRYPTO [=m] && CRYPTO_HW [=y] && (ARM && ARCH_MEDIATEK || COMPILE_TEST [=y])
>   - CRYPTO_DEV_SAFEXCEL [=m] && CRYPTO [=m] && CRYPTO_HW [=y] && (OF [=y] || PCI [=y] || COMPILE_TEST [=y]) && HAS_IOMEM [=y]
>   - CRYPTO_DEV_CCREE [=m] && CRYPTO [=m] && CRYPTO_HW [=y] && OF [=y] && HAS_DMA [=y]
>   - CRYPTO_DEV_SP_CCP [=y] && CRYPTO [=m] && CRYPTO_HW [=y] && CRYPTO_DEV_CCP [=y] && CRYPTO_DEV_CCP_DD [=m] && DMADEVICES [=y]
>
> Fixes: e33bcbab16d1 ("tee: add support for session's client UUID generation")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> The regression was introduced in the soc tree, I'd pick this patch
> up directly into that unless someone sees a problem

Thanks for taking care of this, please go ahead.

Cheers,
Jens

> ---
>  drivers/tee/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/tee/Kconfig b/drivers/tee/Kconfig
> index 806eb87d4da0..e99d840c2511 100644
> --- a/drivers/tee/Kconfig
> +++ b/drivers/tee/Kconfig
> @@ -3,6 +3,7 @@
>  config TEE
>         tristate "Trusted Execution Environment support"
>         depends on HAVE_ARM_SMCCC || COMPILE_TEST || CPU_SUP_AMD
> +       select CRYPTO
>         select CRYPTO_SHA1
>         select DMA_SHARED_BUFFER
>         select GENERIC_ALLOCATOR
> --
> 2.26.2
>