Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH 4.4 26/65] sched/fair, cpumask: Export for_each_cpu_wrap()
To:     Greg KH <gregkh@linuxfoundation.org>,
        nobuhiro1.iwamatsu@toshiba.co.jp
Cc:     linux-kernel@vger.kernel.org, stable@vger.kernel.org,
        peterz@infradead.org, lvenanci@redhat.com,
        torvalds@linux-foundation.org, efault@gmx.de, riel@redhat.com,
        tglx@linutronix.de, lwang@redhat.com, mingo@kernel.org,
        sashal@kernel.org
References: <20200526183905.988782958@linuxfoundation.org>
 <20200526183915.976645661@linuxfoundation.org>
 <OSBPR01MB29836310986EC6E2E132A02F92B10@OSBPR01MB2983.jpnprd01.prod.outlook.com>
 <20200527080944.GB119903@kroah.com>
From:   Daniel Jordan <daniel.m.jordan@oracle.com>
Message-ID: <ee459439-7f33-162f-83de-5106d5125e63@oracle.com>
Date:   Wed, 27 May 2020 10:03:16 -0400
MIME-Version: 1.0
In-Reply-To: <20200527080944.GB119903@kroah.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 5/27/20 4:09 AM, Greg KH wrote:
> On Wed, May 27, 2020 at 07:50:56AM +0000, nobuhiro1.iwamatsu@toshiba.co.jp wrote:
>>> Subject: [PATCH 4.4 26/65] sched/fair, cpumask: Export for_each_cpu_wrap()	
...
>>
>> This commit also needs the following commits:
>>
>> commit d207af2eab3f8668b95ad02b21930481c42806fd
>> Author: Michael Kelley <mhkelley@outlook.com>
>> Date:   Wed Feb 14 02:54:03 2018 +0000
>>
>>     cpumask: Make for_each_cpu_wrap() available on UP as well
>>     
>>     for_each_cpu_wrap() was originally added in the #else half of a
>>     large "#if NR_CPUS == 1" statement, but was omitted in the #if
>>     half.  This patch adds the missing #if half to prevent compile
>>     errors when NR_CPUS is 1.
>>     
>>     Reported-by: kbuild test robot <fengguang.wu@intel.com>
>>     Signed-off-by: Michael Kelley <mhkelley@outlook.com>
>>     Cc: Linus Torvalds <torvalds@linux-foundation.org>
>>     Cc: Peter Zijlstra <peterz@infradead.org>
>>     Cc: Thomas Gleixner <tglx@linutronix.de>
>>     Cc: kys@microsoft.com
>>     Cc: martin.petersen@oracle.com
>>     Cc: mikelley@microsoft.com
>>     Fixes: c743f0a5c50f ("sched/fair, cpumask: Export for_each_cpu_wrap()")
>>     Link: http://lkml.kernel.org/r/SN6PR1901MB2045F087F59450507D4FCC17CBF50@SN6PR1901MB2045.namprd19.prod.outlook.com
>>     Signed-off-by: Ingo Molnar <mingo@kernel.org>
>>
>> Please apply this commit.
> 
> Good catch, now queued up, thanks.

I left this commit out because the 4.4 kernel only uses
cpumask_next_wrap in padata, which is only enabled for SMP kernels, but
it's probably best to be safe.

Daniel