Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 27 May 2020 09:52:14 -0400
From:   Tejun Heo <tj@kernel.org>
To:     qiang.zhang@windriver.com
Cc:     jiangshanlai@gmail.com, markus.elfring@web.de,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5] workqueue: Remove unnecessary kfree() call in
 rcu_free_wq()
Message-ID: <20200527135214.GI83516@mtj.thefacebook.com>
References: <20200527075715.36849-1-qiang.zhang@windriver.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200527075715.36849-1-qiang.zhang@windriver.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, May 27, 2020 at 03:57:15PM +0800, qiang.zhang@windriver.com wrote:
> From: Zhang Qiang <qiang.zhang@windriver.com>
> 
> The data structure member "wq->rescuer" was reset to a null pointer
> in one if branch. It was passed to a call of the function "kfree"
> in the callback function "rcu_free_wq" (which was eventually executed).
> The function "kfree" does not perform more meaningful data processing
> for a passed null pointer (besides immediately returning from such a call).
> Thus delete this function call which became unnecessary with the referenced
> software update.
> 
> Fixes: def98c84b6cd ("workqueue: Fix spurious sanity check failures in destroy_workqueue()")
> 
> Suggested-by: Markus Elfring <Markus.Elfring@web.de> 
> Signed-off-by: Zhang Qiang <qiang.zhang@windriver.com>

Applied to wq/for-5.8.

Thanks.

-- 
tejun