Received: by 2002:a25:ef43:0:0:0:0:0 with SMTP id w3csp942994ybm; Wed, 27 May 2020 11:46:46 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxHILZFUbNQFyu6hE5vMofaY4/tEazZsc0/5a0VB2y3sy/6hiL+J4pUeVOWMQntKIhMPZlq X-Received: by 2002:a17:907:441c:: with SMTP id om20mr6991901ejb.62.1590605206258; Wed, 27 May 2020 11:46:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1590605206; cv=none; d=google.com; s=arc-20160816; b=Izu2sS5wpQASiyeWdohT3c1q1HlhY+FFYks8LtKtmTC/Hv9+1G92doHAoJx7xMNHWa EpLguMWoJF0YckLuIX8PvaBMpUudSzOCIaCHj8+cvDd4VZulSh/n/90zy4QKnuHtsUXK 6sZ6J1FLoxRbe/S6O7L4ZFj2/E5/KKV7piXYDi5b5j63Di0/9h4JOyN8z37IwMEzWT5T wKxX54NKCqkHAyFuNY9SvVjEDuHRFyOzTfdve7h9SIkIOF5fmyCvdO9+JpLnCE8GKaWK lqBBEdAHs9fnEO4mEDRz8IHXExYo2Wuv3ulzzkgMDrJSdO5k7cnKynzkWATy5un9iZQa SvWQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version; bh=MJCziSxQM5MfRN1dMq6/83vFtwhMDp229qpT13GZPmE=; b=zunAWvb8PbVZ81w2q07sEZ62Gfiht+HkaX0bZplBrMUcOt5Bh9g86uUp2z9hPKmFoQ KyTY7/nNF53UoOKaAHu9FTExxx+w/KJ9KWL319sI9iBAj74Q2vdowHSpDHiqOzGuNPeF zSOpTOI378ZUWk+Ztx198z9GNvGCNnN0nF6uwQdOLz8MoBiclO7vIQwfgYyT1p2R1WdZ x2507S5X3NWJXoBAWi8dIszoa9uMZfBa2fYzdb3l6XJDzgu51ZQYUnElooQuRKbC1TYb dZzyb855BmFCimxoJToeQAmSW1aQYixherPPDno5uYDKpqXEux9zIn1eTdjMGH80urf6 3pDQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id b23si2414231edx.118.2020.05.27.11.46.23; Wed, 27 May 2020 11:46:46 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389293AbgE0Ogr (ORCPT + 98 others); Wed, 27 May 2020 10:36:47 -0400 Received: from mout.kundenserver.de ([217.72.192.73]:46809 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389152AbgE0Ogr (ORCPT ); Wed, 27 May 2020 10:36:47 -0400 Received: from mail-qt1-f175.google.com ([209.85.160.175]) by mrelayeu.kundenserver.de (mreue107 [212.227.15.145]) with ESMTPSA (Nemesis) id 1MwxNF-1ip7fK26qx-00ySSH for ; Wed, 27 May 2020 16:36:45 +0200 Received: by mail-qt1-f175.google.com with SMTP id j32so4369995qte.10 for ; Wed, 27 May 2020 07:36:45 -0700 (PDT) X-Gm-Message-State: AOAM532zAwiZbeCqmBTkRbMEC0HFf8QFQmLNJGUJN6cCdL8npzv4AGec Ftqlj04Bh2YscXQH5h/NMkrGcO0SHQ6UGQ4XfIs= X-Received: by 2002:ac8:691:: with SMTP id f17mr4501313qth.204.1590590204402; Wed, 27 May 2020 07:36:44 -0700 (PDT) MIME-Version: 1.0 References: <20200527134254.854672-1-arnd@arndb.de> In-Reply-To: From: Arnd Bergmann Date: Wed, 27 May 2020 16:36:28 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [Nouveau] [PATCH] nouveau: add fbdev dependency To: Ilia Mirkin Cc: Ben Skeggs , David Airlie , Daniel Vetter , nouveau , dri-devel , LKML Content-Type: text/plain; charset="UTF-8" X-Provags-ID: V03:K1:IkTtRky3C2ijnqvAwwC/+tGbWXDIHPSww6i892k0Lnz51LcdXbh ZQdI0iNm4vgqvQ0o4RCc0LyWxF0ZuFHdEYmJn9aGPbOtfeNmgae2FIw6Q0IydcLcdjzPDc6 Hm7LJt3ZT51zWo8Pu9BdpX3x6TgpASDhfAV7D+565LhFBx67r67kID0Is36fpWCOvuFiAtC t7FMGTDs3exdOLIxoNWAA== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:ZnalMiJdDrQ=:hqm6wrxMUmBXjlwTImbTVr R5eK6oRgBs7YRGHA21AWdAJ5ackmba4Ept/xwNYpoUZ8iRS9BA4MpPNZyFTBDRBq7aVFs6XwA mrcNosr3bOS7MwAcslCV2Uh37jhfyoBAI1AdtskxJsT+LzqnV5OBB+uOXGc9tKDHI795NSERa m6/xYdnyXmio8ZODvgxO0W9XD0r2yIrNHb5cnEdnqOzpyvvd9hLYKNmoHgiwLnibbAKDXlHxw LvfPqUFN3UfWOAcRDRYOkmBWepHgJycAG5iia6k5/DLkc5cIR32vCqVRXbdveLfaJNZ6v/UGs IJta6SQugFHzJcpY9BEFVoYhswzvn7E5msVXpIbnal2VHxq39KaCMvQTviihout8TLgfoch3U SD+uql5ymVGPGC7cWb3VYCS9FKeQGVY9Y2QonwoOL+e6xxkdNIKcyWg/dSSejS8Tt1FpMffr+ gD6SWORbztUC+7ynurE6QtRFnr7fGr8JpsG5hCtW+1wcPBxlJVZ63fhPebWSOZufVk2991Fgx MdFPPDvpzgKf2pTVWKj/K52HBtXtNYM+ZxYIRX22u2Bjv9G+9odKOSPuwKnbQNBglKWV/ye13 SrniUFa9tX1p9ImRzlVb4UsgLrKR0R/sEPqFPZAwXbDpY8Rolki96JzIhiP8SBDEzI+CqvRac r7HNFawN2ilA9GJ6hVzc2AwcLTX8VuMKtTAdVCP9gXrpYOKW4fnqBFDU6NnY0gbjs/zi3i8+G X/Vh36zKqcpPZh2/zWMhgkoGSIPO61ikeLmEDJe5tTUxnVvlhWTsc0UpzhjWC1a2qoznWpQvv fqwTUjZkk5gj0cMyEsNu1P5pcZn+/0VzKb9Mm5FuBNtmDfSMVo= Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 27, 2020 at 4:05 PM Ilia Mirkin wrote: > > Isn't this already fixed by > > https://cgit.freedesktop.org/drm/drm/commit/?id=7dbbdd37f2ae7dd4175ba3f86f4335c463b18403 Ok, I see that fixes the link error, but I when I created my fix, that did not seem like the correct solution because it reverts part of the original patch without reverting the rest of it. Unfortunately there was no changelog text in the first patch to explain why this is safe. Could you double-check if the behavior is still correct after the two patches? Arnd