Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751133AbWCRE5N (ORCPT ); Fri, 17 Mar 2006 23:57:13 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751300AbWCRE5N (ORCPT ); Fri, 17 Mar 2006 23:57:13 -0500 Received: from mail16.syd.optusnet.com.au ([211.29.132.197]:56034 "EHLO mail16.syd.optusnet.com.au") by vger.kernel.org with ESMTP id S1751133AbWCRE5M (ORCPT ); Fri, 17 Mar 2006 23:57:12 -0500 From: Con Kolivas To: Nick Piggin Subject: Re: [PATCH][RFC] mm: swsusp shrink_all_memory tweaks Date: Sat, 18 Mar 2006 15:56:22 +1100 User-Agent: KMail/1.9.1 Cc: "Rafael J. Wysocki" , ck@vds.kolivas.org, Andreas Mohr , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Pavel Machek , Stefan Seyfried References: <200603101704.AA00798@bbb-jz5c7z9hn9y.digitalinfra.co.jp> <200603181546.20794.kernel@kolivas.org> <441B9205.5010701@yahoo.com.au> In-Reply-To: <441B9205.5010701@yahoo.com.au> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200603181556.23307.kernel@kolivas.org> Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1303 Lines: 36 On Saturday 18 March 2006 15:52, Nick Piggin wrote: > Con Kolivas wrote: > > On Saturday 18 March 2006 15:41, Nick Piggin wrote: > >>>Index: linux-2.6.16-rc6-mm1/include/linux/swap.h > >>>=================================================================== > >>>--- linux-2.6.16-rc6-mm1.orig/include/linux/swap.h 2006-03-18 > >>>13:29:38.000000000 +1100 +++ > >>>linux-2.6.16-rc6-mm1/include/linux/swap.h 2006-03-18 14:50:11.000000000 > >>>+1100 @@ -66,6 +66,51 @@ typedef struct { > >>> unsigned long val; > >>> } swp_entry_t; > >>> > >>>+struct scan_control { > >> > >>Why did you put this here? scan_control really can't go outside vmscan.c, > >>it is meant only to ease the passing of lots of parameters, and not as a > >>consistent interface. > > > > #ifdeffery > > Sorry I don't understand... My bad. I added the suspend_pass member to struct scan_control within an #ifdef CONFIG_PM to allow it to not be unnecessarily compiled in in the !CONFIG_PM case and wanted to avoid having the #ifdefs in vmscan.c so moved it to a header file. Cheers, Con - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/