Received: by 2002:a25:ef43:0:0:0:0:0 with SMTP id w3csp963724ybm; Wed, 27 May 2020 12:18:57 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxFhptuVDylneogLxFt+B/DZwqui6NtTJ1+OMLSbdVp5oaV8sXNQTqdzabO2YPclSNb9olt X-Received: by 2002:a05:6402:155a:: with SMTP id p26mr8283047edx.376.1590607137679; Wed, 27 May 2020 12:18:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1590607137; cv=none; d=google.com; s=arc-20160816; b=bmX0VBMsE8zNzLnWHaff320oVYiplGbSR7cDuiCD9oya5bp+mRklY4yMlBnsBspdjQ cGPa4bnCgMwIrOlcdJswVZWM/9A8IPT1RpB21LAEMHWn8GXHap4SG/dk1W/HT8AsuU/N OvsbkF/ZdniBT8VYCv+0jQvnjmFqHeVMpXXACDOr4fYzz4uTVO2bp8u+vYyPMw7me081 5jqgGHdBtlGfwMkFaqLK6gSJXr/Jra6xUdfuZMPIbzmcEncgVoLdTB6yeNYtrjDEpAhX nZaFSKpV63EAiN7XHKeKmi2q0Sd2PfrJLhQDFFOv/jl12MDIxXm85Zdu7/ibts2MGVdp +sLQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=MXtUXHnihi65Qkky3QBg/wO8Z4FKZ8HK0jwFU/d0C1U=; b=apQIsqxiscw4tIod/6G31odh6LDTrOd5g9m06JLEm+3xaVTDBFad2mu2scec1Vws+C P/r52KfzOgpRS/udQFuOgbSosXxRtyeM90YS0lYY3kS7fZzCc0yyXq1FHWt9PQLl1Svo VPnwJSgXSNZt0uXwX/wvw6DyOCg7MaMLpH98eLSFf34lXRR5KGRsQoYoiswhLlzi5c2y mDTGRR6FOWh5AxiBhz2WJyfqmNzMbUfI8PpxooNrRoC2nQPtxwUZiOgiFstniSSzuzD+ C3ik9khLR0PdZKTu/RpwLU/hW3EOkfHU40CKvy2a6eKeCZB+TJzF9s/ZPgrDSuLNn4nl DheQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@anholt-net.20150623.gappssmtp.com header.s=20150623 header.b="mAXh/LKA"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id pk16si2546992ejb.310.2020.05.27.12.18.35; Wed, 27 May 2020 12:18:57 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@anholt-net.20150623.gappssmtp.com header.s=20150623 header.b="mAXh/LKA"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387596AbgE0Ra6 (ORCPT + 98 others); Wed, 27 May 2020 13:30:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44596 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726487AbgE0Ra5 (ORCPT ); Wed, 27 May 2020 13:30:57 -0400 Received: from mail-lj1-x243.google.com (mail-lj1-x243.google.com [IPv6:2a00:1450:4864:20::243]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 323E0C03E97D for ; Wed, 27 May 2020 10:30:57 -0700 (PDT) Received: by mail-lj1-x243.google.com with SMTP id k5so29896946lji.11 for ; Wed, 27 May 2020 10:30:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=anholt-net.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=MXtUXHnihi65Qkky3QBg/wO8Z4FKZ8HK0jwFU/d0C1U=; b=mAXh/LKAKtst4Z3OgR5OvCltmndxuNEjZQX+8dipX11S4NVUuzI1BduWwJIOd+6DbB 6a+NxABiUGXEAf0RRGCvjxerV1sRnnXWb9tnLSD2EL0cWq62ZIoDDhmWb3h6DcFZKRnq vYqaWZiaXxv8mG5WFibpZalTRI7liMgwoPwfLPMs5bjBFbIiOiNdnugZKvOwMzZ6uSfX Vy6rNk6gQ584/+hDTLOf+SvZBSBIpqid54R/B5q4Kq+q9O1s9BbZ7hw3UWlJxyFPE8+o UZE1fx8or/NhVPUNdYyYiAIl2BUAVuY70wq7G5z+Y5QcQk6Lr81KS6MqXz1eHZwM3Q4k 6Jow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=MXtUXHnihi65Qkky3QBg/wO8Z4FKZ8HK0jwFU/d0C1U=; b=nte+ZUyxPdH+yC0iRKpTi6edREX9/OJZklRb5YNEhyZJYVWVssBGFo5ucIpetlz4up M1SgaI+LVrkZXLYR9XOeEieTEgXh5qAQQ6c2Hb3Q5U6IYTj/nqxurmYTLbTegUonlwVM rHGq0OOYqNvqsvGbCiPShs+tUFpvDHR1oqxGSFqU2e2ifJhK3zC9R6ROkeCxiAueHIQQ DrEoFggcRoJXesMq/LCcK2ZTzwvCnMzkhlQHb7uYOhNBXevRvL41IMTmIgwp5X3X2Q4N QhRFbsV5Ql3y4CzagGPijPzZSoLJ819DoiXtnD2duxpq/TQTRHmDhKUQ6XhSLaI4a4rq UCfg== X-Gm-Message-State: AOAM533EmE4hNI3pKYepHmpJ2pgIgkvwutYkiW9lDTqJShm+Y4v+DjRA LEu++pCZkn6vJeYKJaHepDvdRh4fo6RoBlEFni4GLg== X-Received: by 2002:a2e:8ed3:: with SMTP id e19mr3799428ljl.367.1590600655617; Wed, 27 May 2020 10:30:55 -0700 (PDT) MIME-Version: 1.0 References: <2c6a651cac6359cb0244a40d3b7a14e72918f169.1590594512.git-series.maxime@cerno.tech> In-Reply-To: <2c6a651cac6359cb0244a40d3b7a14e72918f169.1590594512.git-series.maxime@cerno.tech> From: Eric Anholt Date: Wed, 27 May 2020 10:30:44 -0700 Message-ID: Subject: Re: [PATCH v3 040/105] drm/vc4: crtc: Turn pixelvalve reset into a function To: Maxime Ripard Cc: Nicolas Saenz Julienne , DRI Development , linux-rpi-kernel@lists.infradead.org, bcm-kernel-feedback-list@broadcom.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Dave Stevenson , Tim Gover , Phil Elwell Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 27, 2020 at 8:50 AM Maxime Ripard wrote: > > The driver resets the pixelvalve FIFO in a number of occurences without > always using the same sequence. > > Since this will be critical for BCM2711, let's move that sequence to a > function so that we are consistent. > > Signed-off-by: Maxime Ripard Patch 34-40 also r-b. Going to take a little break, this is a lot to try to process at once. Hopefully you can merge reviewed stuff to drm-misc and shorten the series.