Received: by 2002:a25:ef43:0:0:0:0:0 with SMTP id w3csp987189ybm; Wed, 27 May 2020 13:01:11 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw+tl2siEgWHvxgeItmQW4M3WSkHt9knKck0STMotA8i8FkVSbvsU6iCHBnxAJrVGPSXGqT X-Received: by 2002:a17:906:d8d7:: with SMTP id re23mr10405ejb.22.1590609671225; Wed, 27 May 2020 13:01:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1590609671; cv=none; d=google.com; s=arc-20160816; b=cZ+FqLaEPD5Lw04XbGElQlJZ0Zvx0RgU6wdNc4iuVn+EfJ5dT5PlRiFUiYgvb0neHe /H++KJuThYvpMrvc541TmJ7MI0JklFst7yLOw7TdVlnAaJ2Qkqtq9mmj1XBSU08fke4c 19bNEK8G/ULAXdUassYP2NFFDu5+1ZK9ox7Qzyavb+DJtPGiunHnER/RAqFoy3IEaHok bmlqhvaTwnLaZt/r0N20/OxawCY/tIixw92fl4AoQ0CbVM3WAXfht3LjEs+UHdQHaexs PXuZJqwqL7CJWBh5tStIa2RdFd2C9x9MCjDr1AMSTOsaQ1at9LDT6BHOgapFKD+BBya9 Cbnw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :dkim-signature:dkim-filter:dmarc-filter; bh=q3TLvJ9CIfB/1wbg5oIw6CZmCCpeVyOuikrOuGzN8wA=; b=0qmr45HgQav/PxDM9s9z9LbS7pxwb+V2ktTcRPL4LYd9Wwm6EUiDtLbiUmWPadGG6g 0BlVZ7thjjVPaTKo3Q8eAYNmIddyZT6QxhzBTr/nHA+LM5p0CDUv75NmGrlkoBmAmtmy YwrCpu53k441+4wT8zs7SEr9ZivvdmtGoEZyxX7Ltx9BP46dl4P42AkAh1cZgOyF8mH0 pLkwNVs7t2v1Y65/rKEGjmQ5VMOnHvuYtrgLD55uRDnTh9vxtv8IpBoo44aNjUh3ZHyS tdLmnLIQAACOjj0dM6hfCjI9aTRTdS+xkIRsdORG4caKPuug0zkpAnMDmCtkOGZSaVNj L5gA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@umn.edu header.s=google header.b=iSjjF+W7; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=umn.edu Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id b5si2540372ejk.381.2020.05.27.13.00.38; Wed, 27 May 2020 13:01:11 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@umn.edu header.s=google header.b=iSjjF+W7; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=umn.edu Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387416AbgE0Tzs (ORCPT + 99 others); Wed, 27 May 2020 15:55:48 -0400 Received: from mta-p7.oit.umn.edu ([134.84.196.207]:50154 "EHLO mta-p7.oit.umn.edu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728398AbgE0Tzq (ORCPT ); Wed, 27 May 2020 15:55:46 -0400 Received: from localhost (unknown [127.0.0.1]) by mta-p7.oit.umn.edu (Postfix) with ESMTP id 49XM5G0R5kz9vYy6 for ; Wed, 27 May 2020 19:55:46 +0000 (UTC) X-Virus-Scanned: amavisd-new at umn.edu Received: from mta-p7.oit.umn.edu ([127.0.0.1]) by localhost (mta-p7.oit.umn.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id fq-L_IA2FQS0 for ; Wed, 27 May 2020 14:55:45 -0500 (CDT) Received: from mail-il1-f198.google.com (mail-il1-f198.google.com [209.85.166.198]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mta-p7.oit.umn.edu (Postfix) with ESMTPS id 49XM5F5xp4z9vLH1 for ; Wed, 27 May 2020 14:55:45 -0500 (CDT) DMARC-Filter: OpenDMARC Filter v1.3.2 mta-p7.oit.umn.edu 49XM5F5xp4z9vLH1 DKIM-Filter: OpenDKIM Filter v2.11.0 mta-p7.oit.umn.edu 49XM5F5xp4z9vLH1 Received: by mail-il1-f198.google.com with SMTP id q24so3572031ili.12 for ; Wed, 27 May 2020 12:55:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=umn.edu; s=google; h=from:to:cc:subject:date:message-id; bh=q3TLvJ9CIfB/1wbg5oIw6CZmCCpeVyOuikrOuGzN8wA=; b=iSjjF+W7C++RnXuhE6xA97IPJEc37+fmpoEckipRxMbfZd7b7rJ9U99XRoYCjMOUoE 9bpsnGsBCPwrMuKtiyBQSdQXD06vFEj5R+v6qA7VyuLOexIruIZMnGDZx2UBWVzz2FHq OdxtczifndOGVGRZBd5gQowMpBEvPV/IPyPhEnn1a9ytoddnkZkuKjGQqXFV6aSbgIm7 N/bfr9r0Pb/AekpiJKA5DvtWn2bFbBdTuzJPKEtTbqp23V/ASN47pwvt1grw3GxnWonL vfciYVl69sKcy7ew1k8B3dKcmHjMePfW9LqGwIfVcjgzyFQwGdjEZHUfCgT4q0pBLTfU YLPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=q3TLvJ9CIfB/1wbg5oIw6CZmCCpeVyOuikrOuGzN8wA=; b=XFxrXqz4Xq8GI0OAUXhaTvOaw/yHtjgBLTS9TC+XcmJJVdm+MHjsGxWqo5mK04vqIf B3IvZgj9tzXGn0bECxAbFJdt2ClPiqps55Hl3z3QUFykTDvxX9bOuWl4sUHe8Sj2/y0B lejIcKpbvdW42Ii/XoPiR48iBExdlCK/hD8qvPU9NL8GADkn72qv8+pFVQRy+lUmn0cJ tjBp7Tx4LuJz4Ft2RrUH2ikRo60oOqnQNJcv1eZg+yY04/g1FzVlnv93C1uvAerzbUYz ljOh3fZqCrWiOe5iaxD3Gm3Cdjd/mdCu0SxjjTz7YWuEpVbhgfhoRZvSfmM51GWvZJew aPsw== X-Gm-Message-State: AOAM532mVne3MX+BqKf3kSquOyTZ8zcr+J++TVKuE+Y3Hz/z0Shbr3tp TjQgrI26vXGb+JsB5ozru7GbSW7xYl6GkUpSuWakSSNFfgaOUjQYtepF3J5Lnpk7X0zOUeR528E Cx39KDgJiCELmX+uuu2K8huct/Ns7 X-Received: by 2002:a92:850c:: with SMTP id f12mr5148865ilh.86.1590609345275; Wed, 27 May 2020 12:55:45 -0700 (PDT) X-Received: by 2002:a92:850c:: with SMTP id f12mr5148837ilh.86.1590609344875; Wed, 27 May 2020 12:55:44 -0700 (PDT) Received: from qiushi.dtc.umn.edu (cs-kh5248-02-umh.cs.umn.edu. [128.101.106.4]) by smtp.gmail.com with ESMTPSA id u1sm1596638iol.42.2020.05.27.12.55.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 May 2020 12:55:43 -0700 (PDT) From: wu000273@umn.edu To: kjlu@umn.edu Cc: wu000273@umn.edu, Ryusuke Konishi , Andrew Morton , Vyacheslav Dubeyko , linux-nilfs@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] nilfs2: Fix reference count leak in nilfs_sysfs_create_snapshot_group. Date: Wed, 27 May 2020 14:55:32 -0500 Message-Id: <20200527195532.28077-1-wu000273@umn.edu> X-Mailer: git-send-email 2.17.1 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Qiushi Wu kobject_init_and_add() takes reference even when it fails. If this function returns an error, kobject_put() must be called to properly clean up the memory associated with the object. Previous commit "b8eb718348b8" fixed a similar problem. Fixes: a5a7332a291b ("nilfs2: add /sys/fs/nilfs2//mounted_snapshots/group") Signed-off-by: Qiushi Wu --- fs/nilfs2/sysfs.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/fs/nilfs2/sysfs.c b/fs/nilfs2/sysfs.c index e60be7bb55b0..b2517c5e773a 100644 --- a/fs/nilfs2/sysfs.c +++ b/fs/nilfs2/sysfs.c @@ -209,8 +209,10 @@ int nilfs_sysfs_create_snapshot_group(struct nilfs_root *root) "%llu", root->cno); } - if (err) + if (err) { + kobject_put(&root->snapshot_kobj); return err; + } return 0; } -- 2.17.1