Received: by 2002:a25:ef43:0:0:0:0:0 with SMTP id w3csp994398ybm; Wed, 27 May 2020 13:12:12 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzjd5SO5PsiYgbcgYnVdIekzNuxfYPl/ggWcHIoT6GJHuXWtx35Qnyh73aD3vo+ZJmMcQgh X-Received: by 2002:a17:906:9157:: with SMTP id y23mr58334ejw.0.1590610332787; Wed, 27 May 2020 13:12:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1590610332; cv=none; d=google.com; s=arc-20160816; b=mVlstAdGwiGTzC0DLevEsVrUSnLvqVzC+ObYdjqJuzBCRL7CJgH/08OhzR1pBHsRrd 2sBKMVOBR5YvKoxpK8332j6JxfXs+RtyVVb9a/FsZZDOjo7d2OZDX5gALv9aBehjqbyN 2zf3D8n2TX19nzF5cCH+UYULQK/C+XX3UsZmWfD7v8BhgK+QroLB2SYwtkwcu1ShtnA4 Qv37zEju6m5otD9EQaERAbKtnoQ8Gtp725FqSSlyN9rKVfjdAxCJjUZcqTBJ94Ypm5AR EsCHmT40q8cSEpx9dcHaREhgUDc1EwPlj8RsmVDL+ofz0sxHpv/yw/c7FU6eFqUD9ml5 Wr6w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :dkim-signature; bh=ff0veuCnIjYmgwag8ngcpJVZBkJjrexCu8sGOekdCkQ=; b=AM5MKYt3z10sg18sxQifSOJZ1+RtmMlTdoVYk6YRMztX4TzJ8t8aX7u/YgI5+1lBto 4IsvkV/x2CPUhtXOae+qZNTOmgPmWvvkF/kEUdStFN7R9ZPl5Jsme7Fq7/4ah980IzpD oqGM6kgorz2MnrmcTvpIQDKTV0bVr14Gnk43OPj+yjeu4irDaG/tn/WZteTuDikLDzHK G3EjhVOeMqQhCEzvx8l9WHRYQWnH8wXOOMbP1z4SO+5/2xOD21t8l8o/ot59yw2lMtms sRkCmNU5lR5FaMrT/YCaZlLiWqsV5I8lbMKwm0PLn8p+B/IJ7NFJCn+27bw5/WPJfwTq 3InA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=vSBjwSbC; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id ce6si2259147edb.379.2020.05.27.13.11.45; Wed, 27 May 2020 13:12:12 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=vSBjwSbC; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728398AbgE0UFv (ORCPT + 99 others); Wed, 27 May 2020 16:05:51 -0400 Received: from mail.kernel.org ([198.145.29.99]:41008 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726114AbgE0UFv (ORCPT ); Wed, 27 May 2020 16:05:51 -0400 Received: from localhost.localdomain (unknown [194.230.155.118]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id DF9D42089D; Wed, 27 May 2020 20:05:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1590609950; bh=N1nKAU4vjXzrN3ZCzfQIK8tGr2UNnnDVh5ijat7Jixc=; h=From:To:Cc:Subject:Date:From; b=vSBjwSbCJvKlikusm/wmEr/7TTDzTbgl52W4bOlziIe35z6bmG7aVvt16cX4vA3Ds JawzsuArKpqNtEmfpTUHEY4PpJ0UflU2koaEGTxsAfJy7ykbE1JLOiYLsX0PVK6ntO MBQLohmfCYcFetFH5Zo07tt1jDsbH52VrZ740kqc= From: Krzysztof Kozlowski To: Rob Herring , Tomeu Vizoso , Steven Price , Alyssa Rosenzweig , David Airlie , Daniel Vetter , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [PATCH v3] drm/panfrost: Reduce the amount of logs on deferred probe Date: Wed, 27 May 2020 22:05:44 +0200 Message-Id: <20200527200544.7849-1-krzk@kernel.org> X-Mailer: git-send-email 2.17.1 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org There is no point to print deferred probe (and its failures to get resources) as an error. Also there is no need to print regulator errors twice. In case of multiple probe tries this would pollute the dmesg. Signed-off-by: Krzysztof Kozlowski Reviewed-by: Steven Price --- Changes since v2: 1. Rebase 2. Add Steven's review Changes since v1: 1. Remove second error message from calling panfrost_regulator_init() --- drivers/gpu/drm/panfrost/panfrost_device.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/panfrost/panfrost_device.c b/drivers/gpu/drm/panfrost/panfrost_device.c index 8136babd3ba9..b172087eee6a 100644 --- a/drivers/gpu/drm/panfrost/panfrost_device.c +++ b/drivers/gpu/drm/panfrost/panfrost_device.c @@ -101,7 +101,9 @@ static int panfrost_regulator_init(struct panfrost_device *pfdev) pfdev->comp->num_supplies, pfdev->regulators); if (ret < 0) { - dev_err(pfdev->dev, "failed to get regulators: %d\n", ret); + if (ret != -EPROBE_DEFER) + dev_err(pfdev->dev, "failed to get regulators: %d\n", + ret); return ret; } @@ -213,10 +215,8 @@ int panfrost_device_init(struct panfrost_device *pfdev) } err = panfrost_regulator_init(pfdev); - if (err) { - dev_err(pfdev->dev, "regulator init failed %d\n", err); + if (err) goto err_out0; - } err = panfrost_reset_init(pfdev); if (err) { -- 2.17.1