Received: by 2002:a25:ef43:0:0:0:0:0 with SMTP id w3csp1045100ybm; Wed, 27 May 2020 14:46:09 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxhtI6YhGtoVP25Gbudy/nk1t+6Vk3EsgF/FTKKJ35WS9xVv893mS54nu3GaHaso6CUOVlZ X-Received: by 2002:a17:906:8748:: with SMTP id hj8mr313471ejb.335.1590615968996; Wed, 27 May 2020 14:46:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1590615968; cv=none; d=google.com; s=arc-20160816; b=lI5g8DgyVREZfbAjKlnxpDBV7wdZ8hZza6KA2Exq9ltMFg5vWPsDIu253hKdhRjphB 2N9bj2uOJg0QzEHYJUTrPD5pBfI547Gp5sonb9AjCNMz63PWJcadj06fSeUJ7HN+kNiw z14zp5ZH5y0YVM1I492f6ksdds+DGMWLrCeabwngil+HieiZ4i4U8GwvWOMkdiIT/VTN 8h/TTbPmNGAM5IvhHi5sxwFqkiz1rlkiUP83wXzjbRIxsvNDIeHrfZ9aC9cjddPvZdzb cPgCmSmzVO7S7J5fo/79//vQCyWCwSDPKq/BAD3kH20VU0TyGs0bMnuJzRpEYCHR5nz8 un9g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:to:content-transfer-encoding:mime-version :message-id:date:subject:cc:from:dkim-signature; bh=sGrZKBWfZ9CzbVCqf0bzxeml/dCqTei6g4aLYiJ/QE4=; b=sAu8/Sn19i6/Jo303gScdt0YKTWvKZGHsmPfTdnKHaVC/ahzCcfAcnjhp6swIOPNeR klJ+g5RjT2tX/QdjkP/N06R+aasFrsODhzyKRU7BfH/dRv+K/dxCt0oN5e7WDSmiPWOq /300OOL64CaG5q67njjOsy9e7UFE24cq1K8HpBIovAcRijbXjBp6HhteULUwGq7G2571 ehSSYIO0tGMheMGJhXwCZrGgm0zQ7txNtZiwqGV+V8mINF5cQhXYFmTyyVT5Zeu3oURS DGdp8ghpapD0UkFbanohlDuGOk/lakyQPd2AmWY3rxnkELNqv/wZw+VnFt+KoeRtvVzE nPyg== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=MTxj59cR; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id w4si2458915ede.150.2020.05.27.14.45.46; Wed, 27 May 2020 14:46:08 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=MTxj59cR; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389635AbgE0PGO (ORCPT + 98 others); Wed, 27 May 2020 11:06:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50236 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389316AbgE0PGM (ORCPT ); Wed, 27 May 2020 11:06:12 -0400 Received: from mail-pf1-x444.google.com (mail-pf1-x444.google.com [IPv6:2607:f8b0:4864:20::444]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D737DC05BD1E; Wed, 27 May 2020 08:06:12 -0700 (PDT) Received: by mail-pf1-x444.google.com with SMTP id n15so11950678pfd.0; Wed, 27 May 2020 08:06:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=sGrZKBWfZ9CzbVCqf0bzxeml/dCqTei6g4aLYiJ/QE4=; b=MTxj59cROwN+53QYo4SSPVrpTjgGU1PkLYOSYGSCHQQSuo3EKGDjduRBdIVJd4yeUO ykpuutiv1VYJx00VQ2a0UB6AVWfP/+CYxxDEsPAqb5HvAR9ZBNjI6okRkfJ1TXCNVsaq q78/VzeQuwhteET3ohKSKEdMKpGa3Ky5nFYl3lwYs6aPP+NFRgA+0ozbwzryXYls1ayk K1gNz+Tc8zZ2d1NYOrs1IRErPxA9uqksG2lhwYelhbmXm3+e8k7xvNtRW7+Bdl51fFnT riWMwTbbtelwf8qBZPB6nQNr0W/iuIETaQtPDmDRxX28+OHSATPtH9CIIJ8iLVk1mbNU sfAw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=sGrZKBWfZ9CzbVCqf0bzxeml/dCqTei6g4aLYiJ/QE4=; b=XsC3eRBLpGnwnPo1cDSO59GdCTnN9o969ivzDRUTfwJH1Jf5EO8YmgbJ91N3saBZBR R4tc3KNg/PTsqlXQ5tu3LC4CY1pFcITuRF3Udh+bOnsfwmHDeru7s7xz1Mpl0+iGWvaH ehBcZikOM+yhrrp6vkFK5ajZsSHW9tVpOgoKs5p6Ltcot9+OZdwVm70EQe5WXNLF3pMJ pTPmKQnKf0osn/+7DxMnRRZPeejz/vaY6DSyFtV/Cgd4St0jJj5jaknVD9KlIi6kOEDH OJdZOWPHJT3RUAFxsS2S+NGnt9OAq/H/UeNDQmR/A8iSCKdw6Gsyhjbo1p8s4RwRCn2s Xwkw== X-Gm-Message-State: AOAM533wVpH9YjHW5cMir0Xei5Yxofb2b+EPyrf2t5VWAB2dkabOC9Rt 7iY1vyZJ120vr3D8LElDz8Q= X-Received: by 2002:a05:6a00:1490:: with SMTP id v16mr4235765pfu.173.1590591972237; Wed, 27 May 2020 08:06:12 -0700 (PDT) Received: from suzukaze.ipads-lab.se.sjtu.edu.cn ([202.120.40.82]) by smtp.gmail.com with ESMTPSA id q18sm2214682pgt.74.2020.05.27.08.06.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 May 2020 08:06:11 -0700 (PDT) From: Chuhong Yuan Cc: Jonathan Cameron , Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald-Stadler , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Chuhong Yuan Subject: [PATCH] iio: mma8452: add missed iio_device_unregister in probe failure Date: Wed, 27 May 2020 23:06:06 +0800 Message-Id: <20200527150606.539130-1-hslester96@gmail.com> X-Mailer: git-send-email 2.26.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit To: unlisted-recipients:; (no To-header on input) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org mma8452_probe() calls iio_device_register() but misses to call iio_device_unregister() when probe fails. Add the missed call in error handler to fix it. Signed-off-by: Chuhong Yuan --- drivers/iio/accel/mma8452.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/iio/accel/mma8452.c b/drivers/iio/accel/mma8452.c index 00e100fc845a..813bca7cfc3e 100644 --- a/drivers/iio/accel/mma8452.c +++ b/drivers/iio/accel/mma8452.c @@ -1685,10 +1685,13 @@ static int mma8452_probe(struct i2c_client *client, ret = mma8452_set_freefall_mode(data, false); if (ret < 0) - goto buffer_cleanup; + goto unregister_device; return 0; +unregister_device: + iio_device_unregister(indio_dev); + buffer_cleanup: iio_triggered_buffer_cleanup(indio_dev); -- 2.26.2