Received: by 2002:a25:ef43:0:0:0:0:0 with SMTP id w3csp1049332ybm; Wed, 27 May 2020 14:54:56 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwyxauedpZqX4InZrxH/wWdYwdafvOQgJL8sSpppwiH1huvfu0osxXwIU1o025HOry/8ShB X-Received: by 2002:a05:6402:17ba:: with SMTP id j26mr195247edy.324.1590616412820; Wed, 27 May 2020 14:53:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1590616412; cv=none; d=google.com; s=arc-20160816; b=JHO3Q/NeKg5wmE7gXNzus29t6x12j+iBK5U3JB6cdQvGdllsULdzg4vqH4gIbmfGGl XNojeawEDc1KEBpwBzcAQNnZ/1HR0xyESuMRnbnywlfOuP0NyAsaMDDKlDjSS7QSURWu WNHIukSH6+6xfhEMRPg8gwnKsbMDo0lhotWramtrVdA01BkjbCxT+aUBLFlDU2BdrGA/ JasVwLBpa1KpIsXC7+EB2e/ugO9YVteMkcdoK7/eO4LudjshJxiQdmc3CjGdJoNY4P0z xrEtizgOuLSOjKSBN2MmT47gDENIKlCrWEjcKdXy0mAf8RZeDUm+VdTSzgd3rXGWt3/i ThfA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=/hBQwlO36HqTw7b3/a9y2PU9fbwGlde7Xw6IvZwUL1k=; b=Vuq+JPtD9sM2TdWqyDEycT7cOgSNyBAjLSUZWe5yS2Z11EtCXLo2I9hfGBhgHWojbo 7yVOsbd9c8JfTTqSnOoxea2hEA+8wgqKlHSrkcRbsUhfGBGGMshmAk1xw5UUQEbJOpBN rxYmP1pfeZ9vscYBkwzjSpSi0pAxftVbjdYwZlLxoAJQjoybi/IjBJSRJR9VApeYjr5Y 82nIOJrCCgyKkRNZTtrz8NyLUnh5QkjlZ6oI6Cm72aXc47JgXJO10VMSzQ0PV6WIPCoV FRBCyGHsZC7y4MAuIRfh+hQM0I9JB0YZ2cokZwSItBcufsyfks8e01ElYMV/nq42jb7x 8ddA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@alien8.de header.s=dkim header.b=Nd9abdxS; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alien8.de Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id cd16si2593597ejb.649.2020.05.27.14.53.09; Wed, 27 May 2020 14:53:32 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@alien8.de header.s=dkim header.b=Nd9abdxS; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alien8.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728148AbgE0TFD (ORCPT + 99 others); Wed, 27 May 2020 15:05:03 -0400 Received: from mail.skyhub.de ([5.9.137.197]:36922 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725766AbgE0TFD (ORCPT ); Wed, 27 May 2020 15:05:03 -0400 Received: from zn.tnic (p200300ec2f0b8700dda2f727e1b752eb.dip0.t-ipconnect.de [IPv6:2003:ec:2f0b:8700:dda2:f727:e1b7:52eb]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id DFFDF1EC02B3; Wed, 27 May 2020 21:05:01 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1590606302; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=/hBQwlO36HqTw7b3/a9y2PU9fbwGlde7Xw6IvZwUL1k=; b=Nd9abdxSIUPRqq0wm4UFeDxDA4cN2klC1VYeab2tmXCHyJBaaQSrgI7P9Te07A4B9DCe9k GlIKjetw2s7t3wlqhp0Au822vwm0MGl1Yc3BqRAY3DAp6mNdo1BOPVDVgbqCLZGoXIh1ld HLDYcv2h+g7BGIYFEqUr9pC6ErZtKRM= Date: Wed, 27 May 2020 21:04:56 +0200 From: Borislav Petkov To: Al Viro Cc: Alexander Potapenko , Kees Cook , Andrew Morton , Alexey Dobriyan , LKML , sunhaoyl@outlook.com, x86@kernel.org Subject: Re: [PATCH] fs/binfmt_elf.c: allocate initialized memory in fill_thread_core_info() Message-ID: <20200527190456.GD1721@zn.tnic> References: <20200420153352.6682533e794f591dae7aafbc@linux-foundation.org> <202004201540.01C8F82B@keescook> <20200421034249.GB23230@ZenIV.linux.org.uk> <20200512010901.GQ23230@ZenIV.linux.org.uk> <20200512034400.GA1537486@ZenIV.linux.org.uk> <20200513033349.GR23230@ZenIV.linux.org.uk> <20200524234535.GA23230@ZenIV.linux.org.uk> <20200526223817.GA3819674@ZenIV.linux.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20200526223817.GA3819674@ZenIV.linux.org.uk> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 26, 2020 at 11:38:17PM +0100, Al Viro wrote: > Folks, could you test the following? > > copy_xstate_to_kernel(): don't leave parts of destination uninitialized > > copy the corresponding pieces of init_fpstate into the gaps instead. > > Signed-off-by: Al Viro Am I taking this through tip (would prefer to as there's other FPU stuff pending) or should I ack this so that you can send it upwards? Thx. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette