Received: by 2002:a25:ef43:0:0:0:0:0 with SMTP id w3csp1071139ybm; Wed, 27 May 2020 15:32:57 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzZNIAsv5Bm2IYijYPm/4riQYguHw6GLbHIhh0Lng3rIRQjcEEknQmqjemYVH40rQCVvqvG X-Received: by 2002:a17:906:2e50:: with SMTP id r16mr435741eji.305.1590618777781; Wed, 27 May 2020 15:32:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1590618777; cv=none; d=google.com; s=arc-20160816; b=cTxE7SzQFXSsKFc6yu+s6QuJKO1XY+3oHpGlvw50ksLga0qIybHTg0tCqBgJnTipt7 Ex1WNdPR+p2kPO3itCp317OwIcEbn5rmHwEUA2z6aOcA09HCke2aRDCp5OV6Dk2ADb2c 6YguQoLrCtRbl19xITNzc6UGWx79PtFzxhANhcR0U1dNTqugSSv+cGc1MFumcJ97QR1c gCLbaHrBh/jNpamfaulPapRpEji9cIwdp7peCH+ItFyHpoiMpkAt7VGL6AEtAHeD3AMJ DsXKYyIwJ0dNy9/gXtM7oHOtjmAc/NvxU0dQs2WSELF3qTBR+yzP2/tP6uXxRXbfPLu7 Y3nA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:cc:to:subject :message-id:date:from:in-reply-to:references:mime-version; bh=o45U6a0JJiJ6Q15pEMPo5YnsNVRrlzBVEwHctW96/us=; b=NMX1r7WKpWool5PYzPZpVYfOFVZI3GI9LMsE50ULn/65lR2LtR5NCjodLAcJTYyg9+ tPxGdOAVVaK73GkLHqIxoyHpPp+wPbt4TLQY+k7GPPmEC9X3A8rDkqKy9tqDDwY7uRoF Fp77QjIFNM/PAwuzNHUMg8VCC2YhssToenHBgeliqq5wcuPLpRqvsCpcrpKcF5f3diRq YUTHRdBrSlqXJdPyvf7f+cmZ99sWi7empbsDM3LpqvBAPl8P6dhtDzorLXb2l50G6HvI Pe0oMqCruIoamNX9dSxvkOq3KJJ+Fk3odCvGwMFQ+Gd/95kI8sHzcoU1nrXrNtjWQOS1 ODxw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id a4si2748414ejr.560.2020.05.27.15.32.15; Wed, 27 May 2020 15:32:57 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725848AbgE0WaL convert rfc822-to-8bit (ORCPT + 99 others); Wed, 27 May 2020 18:30:11 -0400 Received: from mout.kundenserver.de ([212.227.126.133]:41419 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725385AbgE0WaK (ORCPT ); Wed, 27 May 2020 18:30:10 -0400 Received: from mail-qt1-f177.google.com ([209.85.160.177]) by mrelayeu.kundenserver.de (mreue011 [212.227.15.129]) with ESMTPSA (Nemesis) id 1MF3Y8-1jp2uP0LBw-00FRqj; Thu, 28 May 2020 00:30:09 +0200 Received: by mail-qt1-f177.google.com with SMTP id k22so5915055qtm.6; Wed, 27 May 2020 15:30:08 -0700 (PDT) X-Gm-Message-State: AOAM531BeyRwL05UY3rtLnPZvc2nbJNbb7sKMNzq6Vi5Bajd5Ejmnh1S VuZGpF2Ko/O/HaUuElbXzRtWmFX7xz/WtjZB+eY= X-Received: by 2002:ac8:306d:: with SMTP id g42mr167827qte.18.1590618607910; Wed, 27 May 2020 15:30:07 -0700 (PDT) MIME-Version: 1.0 References: <20200527134911.1024114-1-arnd@arndb.de> <877dwx3u9y.fsf@x220.int.ebiederm.org> In-Reply-To: <877dwx3u9y.fsf@x220.int.ebiederm.org> From: Arnd Bergmann Date: Thu, 28 May 2020 00:29:51 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] binfmt_elf_fdpic: fix execfd build regression To: "Eric W. Biederman" Cc: Alexander Viro , Kees Cook , =?UTF-8?Q?Valdis_Kl=C4=93tnieks?= , Greg Ungerer , Linux FS-devel Mailing List , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT X-Provags-ID: V03:K1:mn+FbMg1s8+W/BDX/3TYVn27SMUH65f55dYgmSvfH4jdsYFfBLN z7kZYksZI7k4rE/aPCtpd8B0zCr3lc2MCl477i9HRgfOTNNQvwgyslE9gElrBxeNPuMfTFA pKQWoLs59oveokwRsYlhTFlCpyoLvrjil4lsGlg7h5t48jWeIH8zg3XAob0nqKCeJvx3YgD uU/kHsAqfz/bePWAWTWIw== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:QbcoB7o2wfg=:5y+a6YqR/iiqxWm3KiMSh8 /XtzUvtTg6sBa4ovt8apLRxrFxKc2FcD077v61lk//Lc+IixzyXbY+C8lOQXG9Au4lhrOPfMm jEvZuL/sC6UZhRdFqI/NulbPU7CH9/7MjrZP5RNVFYBgc28hY9Rb+1uQljgTmWowEUYa/HYI2 wiaWPra/Ix/gK/J2+1FB9YOj9xeuOz9sBdFJbNa9KibFvwYK5juZzHkd/kWnxO9uzKNGUcrhu ccicWTVJkspNDwzcviFVJ6IX0JdjI2y5qhTCDH7pSSGWlYDJgQ8JOg8bIEREyrzpi1+1s6I6I 6nzbxGdreRG93NcZIgpFVJ6iNh85VZMOSTzdM2zsFAI71fHP/TZXe5RRW0BSzdRTeKSXxalFW t5EYdNF0SPCHHGe0+e1XSvswHM9XzKCBEi4doL6P+07BDrFXRj3Ksq5LK0UV/H8mguyaSZhay M6Ku7Rbal/ApvOnsHor2VedqGgAxp9mQfFSlxoMP1ZNB4NCaHIg+PKjaLAiIgyW05hkmfX3Q8 tEWGCsXBhYKADsRl8vJy3T/17NN4dczfHjKWRQnG6xMJCW8Iqfv1F3lY1MZEskZv0j5sinsvZ ou4PNsIy+g2X0GVd62R12t3P4aI9rkkRmXuCw95v0rfStyDmCACU+0r1ussGC2CmB/0oLXvIS oZRI3tYH+VmCYjSRVygeETzGPQWKOR/EAGBfTVxXWbVfgL3Co0g5M+s/eUu0u8NTIVbrkEBa3 puEnjO9quI2tyfTUaKRT+ySkhKprEvhLJgT8GhgY7HHfBVZ8LSCIgf5N+VEAI0u0tTcUp3Qp0 n4TMSWbhtY0IlXqaFAHKYVK79qJMC3LJaY0Ks4eROXiSomhISs= Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 28, 2020 at 12:12 AM Eric W. Biederman wrote: > > Arnd Bergmann writes: > > > The change to bprm->have_execfd was incomplete, leading > > to a build failure: > > > > fs/binfmt_elf_fdpic.c: In function 'create_elf_fdpic_tables': > > fs/binfmt_elf_fdpic.c:591:27: error: 'BINPRM_FLAGS_EXECFD' undeclared > > > > Change the last user of BINPRM_FLAGS_EXECFD in a corresponding > > way. > > > > Reported-by: Valdis Klētnieks > > Fixes: b8a61c9e7b4a ("exec: Generic execfd support") > > Signed-off-by: Arnd Bergmann > > --- > > I have no idea whether this is right, I only looked briefly at > > the commit that introduced the problem. > > It is correct and my fault. > > Is there an easy to build-test configuration that includes > binfmt_elf_fdpic? > > I have this sense that it might be smart to unify binfmt_elf > and binftm_elf_fdpic to the extent possible, and that will take build > tests. It should be included in an ARM allmodconfig. Nicolas Pitr did the work to support ELF_FDPIC on ARM with MMU a while ago, but I'm not sure what it would take to make this architecture independent or support build-testing on x86. Arnd