Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 27 May 2020 16:05:08 -0700
From:   Andrew Morton <akpm@linux-foundation.org>
To:     Wei Yang <richard.weiyang@gmail.com>
Cc:     Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        Jesse Brandeburg <jesse.brandeburg@intel.com>,
        christian.brauner@ubuntu.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] bitops: simplify get_count_order_long()
Message-Id: <20200527160508.2ef29d6904c07ca6c650638c@linux-foundation.org>
In-Reply-To: <20200527224542.yx45druzqtlaxrl7@master>
References: <20200524123551.9469-1-richard.weiyang@gmail.com>
        <20200525091458.GK1634618@smile.fi.intel.com>
        <20200525144312.mbw2z3ydncyasvss@master>
        <20200525153216.GD1634618@smile.fi.intel.com>
        <20200525134110.5737dd603d5fa1230e2f7ece@linux-foundation.org>
        <20200525215741.zd3gry4yyqqplix6@master>
        <20200525153146.c1337b1ca7af386ac30e5702@linux-foundation.org>
        <20200527224542.yx45druzqtlaxrl7@master>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, 27 May 2020 22:45:42 +0000 Wei Yang <richard.weiyang@gmail.com> wrote:

> /* a tiny module only meant to test get_count_order/long */
> unsigned int order_comb[][2] = {
> 	{0x00000003,  2},
> 	{0x00000004,  2},
> 	{0x00001fff, 13},
> 	{0x00002000, 13},
> 	{0x50000000, 32},
> 	{0x80000000, 32},
> };
> 
> static int __init test_getorder_startup(void)
> {
> 	int i;
> 
> 	for (i = 0; i < ARRAY_SIZE(order_comb); i++) {
> 		if (order_comb[i][1] != get_count_order(order_comb[i][0]))
> 			pr_warn("get_count_order wrong for %lx\n",
> 					order_comb[i][0]);
> 	}
> 
> 	return 0;
> }
> 
> Since I don't get a way to iterate all the possibilities, some random
> combination is chosen. Is this one looks good?

Looks good.

You might want to add a less-negative number as well?  0x80030000. 
Something that won't turn positive if it has 1 subtracted from it.