Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20200426032410.10425-1-wuxy@bitland.com.cn>
In-Reply-To: <20200426032410.10425-1-wuxy@bitland.com.cn>
From:   Nicolas Boichat <drinkcat@chromium.org>
Date:   Thu, 28 May 2020 08:45:34 +0800
Message-ID: <CANMq1KAGtMMC7SW7aeDQuogF+Ux40=AFYO8V-F_JkEMtAa3eUQ@mail.gmail.com>
Subject: Re: [PATCH] [v3]mtd: spi-nor: winbond: add 1.8v SPI NOR Flash IDs
To:     wuxy@bitland.com.cn
Cc:     Andrew Morton <akpm@linux-foundation.org>, linux-mm@kvack.org,
        lkml <linux-kernel@vger.kernel.org>,
        wuxy <wuxy@bitland.corp-partner.google.com>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi,

First, you need to cc linux-mtd@lists.infradead.org, make sure to use
the get_maintainer.pl script to get the cc list (you're cc-ing mm
people here, but you should cc mtd folks instead).

On Sun, Apr 26, 2020 at 11:24 AM <wuxy@bitland.com.cn> wrote:
>
> From: wuxy <wuxy@bitland.corp-partner.google.com>
>
> Winbond has new 1.8V SPI NOR Flash IDs,we need to use the SPI
> flash ID in kukui series,this patch can support the new flash IDs.
> This patch copied from:https://patchwork.ozlabs.org/patch/1150756/,
> The original patch is invalid,so re-submit a new patch for this.

This is historical stuff, and does not belong in the commit message,
please move that below the ---.

Also, since you're merely rebasing/fixing a patch authored by ST Lin,
I'd keep the original author and signed off:
Signed-off-by: ST Lin <stlin2@winbond.com>

Thanks!

>
> TEST=boot to shell,get the spi information from 'dmesg'.
>
> Signed-off-by: Xingyu Wu <wuxy@bitland.corp-partner.google.com>
> ---
>  drivers/mtd/spi-nor/winbond.c | 9 +++++++++
>  1 file changed, 9 insertions(+)
>
> diff --git a/drivers/mtd/spi-nor/winbond.c b/drivers/mtd/spi-nor/winbond.c
> index 17deabad57e1..cda4f8847bd6 100644
> --- a/drivers/mtd/spi-nor/winbond.c
> +++ b/drivers/mtd/spi-nor/winbond.c
> @@ -61,6 +61,15 @@ static const struct flash_info winbond_parts[] = {
>                              SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) },
>         { "w25m512jv", INFO(0xef7119, 0, 64 * 1024, 1024,
>                             SECT_4K | SPI_NOR_QUAD_READ | SPI_NOR_DUAL_READ) },
> +       { "w25q64jwxxIM", INFO(0xef8017, 0, 64 * 1024, 128,
> +                           SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ |
> +                           SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB) },
> +       { "w25q128jwxxIM", INFO(0xef8018, 0, 64 * 1024, 256,
> +                           SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ |
> +                           SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB) },
> +       { "w25q256jwxxIM", INFO(0xef8019, 0, 64 * 1024, 512,
> +                           SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ |
> +                           SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB) },
>  };
>
>  /**
> --
> 2.20.1
>
>
>