Received: by 2002:a25:ef43:0:0:0:0:0 with SMTP id w3csp146671ybm; Wed, 27 May 2020 22:21:14 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy8HpfjvAp5IX9xxmnMtkg518/CCtwdzYVqeBMUUUcLvvgiIaYcEGRZOu7DbuN02iozBpuM X-Received: by 2002:a50:858d:: with SMTP id a13mr1319915edh.239.1590643273811; Wed, 27 May 2020 22:21:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1590643273; cv=none; d=google.com; s=arc-20160816; b=iKzjxDbzqaygBd95sarzmTSBNvAvmuqGfzx5nmhniAMOtA4FmdKWA2PeGmZaOPgbsD dWATTdapKWpClAJqUMiblrGg/eCboNqvAWGGjlY3vHpwkN9i5+c596GZm9ENhhu69Rvp qXULHkrD++KLu7ai1wTf69xsLpNObZURS95Y5lxjYN8p1bqwJ5+aI6Sq3+f8Wc5AqpKu E6oFWjJbQ83rPSA0dANvt4P5see6x/LFHdX1FhFKCrxMD1hFh26IA9UtLT0iz0bh70K8 olKI0ywQpOeFlngRZKMHFIDH9d3H9CPcfQQ8A4Z15WWznf4PdT24XI+WVYN3YKPYfZFu g9ig== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:organization:in-reply-to :content-transfer-encoding:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:ironport-sdr :ironport-sdr; bh=Cf6blF45nkxoVUqIznnm0y7Ex9woSSnmz6B5+WVxWUM=; b=WHjBVdgE1xKTntGQHs75xw/Oqe1eCELtTABLdKL1xeY6R/TCJWLGZtcHc+qFV/K8kf rJjIpaDIyajyC49kwWhDkARFHXe516mDym9xKCtPLdK3cTVJsfhPdPc1++Q+86wKzNUR jMVPbS8sn4B0iCiuazsEXzAAKuUA/lw9m5cGQXCPmOMzmwVklcZ2lYHwk0RzIErGYQ+z 4vsVwP0hISAMNWAU9fXXz9rkVf7B/DCP8Li2aDjGJedDx4v65DJ/Qv5L3oz/yxDgprHQ qH0kGQSSkyN6f6dQ/MUmdbAv9Mubm7V+jC5x30X0KUERPWmYf5TdySLJfblsVjKOmx4F o2DA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id q8si3028828edn.307.2020.05.27.22.20.51; Wed, 27 May 2020 22:21:13 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728020AbgE1FQm (ORCPT + 99 others); Thu, 28 May 2020 01:16:42 -0400 Received: from mga09.intel.com ([134.134.136.24]:1646 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727866AbgE1FNe (ORCPT ); Thu, 28 May 2020 01:13:34 -0400 IronPort-SDR: ZKMVKwoNJcxY87oGn5ZnXK8C+Sr98cBsLIuzWJPk5kuQaAtOsgxVjx/cGPtvI8V6FbmKIf4qwu mSFzbbCsbogQ== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 May 2020 22:13:33 -0700 IronPort-SDR: enoUrQ5QFuqRwd2IG/kk76A5FrNr4x6c280uzLz7f93LgPpJDDpxv9zEE24NlmyGOH0HBTWCBA BJ1kfX7A3uXA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,443,1583222400"; d="scan'208";a="302352681" Received: from dmescala-mobl1.amr.corp.intel.com (HELO localhost) ([10.252.59.102]) by fmsmga002.fm.intel.com with ESMTP; 27 May 2020 22:13:24 -0700 Date: Thu, 28 May 2020 08:13:23 +0300 From: Jarkko Sakkinen To: Borislav Petkov Cc: linux-kernel@vger.kernel.org, x86@kernel.org, linux-sgx@vger.kernel.org, akpm@linux-foundation.org, dave.hansen@intel.com, sean.j.christopherson@intel.com, nhorman@redhat.com, npmccallum@redhat.com, haitao.huang@intel.com, andriy.shevchenko@linux.intel.com, tglx@linutronix.de, kai.svahn@intel.com, josh@joshtriplett.org, luto@kernel.org, kai.huang@intel.com, rientjes@google.com, cedric.xing@intel.com, puiterwijk@redhat.com, Serge Ayoun , Jethro Beekman Subject: Re: [PATCH v30 07/20] x86/sgx: Enumerate and track EPC sections Message-ID: <20200528051323.GA6613@linux.intel.com> References: <20200515004410.723949-1-jarkko.sakkinen@linux.intel.com> <20200515004410.723949-8-jarkko.sakkinen@linux.intel.com> <20200525092304.GD25636@zn.tnic> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20200525092304.GD25636@zn.tnic> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, May 25, 2020 at 11:23:04AM +0200, Borislav Petkov wrote: > Enabling this gives: > > In file included from arch/x86/kernel/cpu/sgx/main.c:11: > arch/x86/kernel/cpu/sgx/encls.h:189:51: warning: ‘struct sgx_einittoken’ declared inside parameter list will not be visible outside of this definition or declaration > 189 | static inline int __einit(void *sigstruct, struct sgx_einittoken *einittoken, > | ^~~~~~~~~~~~~~ > In file included from arch/x86/kernel/cpu/sgx/reclaim.c:12: > arch/x86/kernel/cpu/sgx/encls.h:189:51: warning: ‘struct sgx_einittoken’ declared inside parameter list will not be visible outside of this definition or declaration > 189 | static inline int __einit(void *sigstruct, struct sgx_einittoken *einittoken, > | > > You need a forward declaration somewhere. It is a left-over from v28 and should be "void *". To backtrack what happened it looks that I squashed the change that does this to "x86/sgx: Linux Enclave Driver". This is fixed now in my tree. /Jarkko