Received: by 2002:a25:ef43:0:0:0:0:0 with SMTP id w3csp157252ybm; Wed, 27 May 2020 22:43:05 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxsBsc3WpJIlOdOTkeV5tZIkDT75/suT37nTGwIoZ5CMO6dbOtxxtgskgoNY4jB+DQbbMFC X-Received: by 2002:a17:907:1110:: with SMTP id qu16mr1529980ejb.539.1590644584883; Wed, 27 May 2020 22:43:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1590644584; cv=none; d=google.com; s=arc-20160816; b=Fo5AllnWaTJdcmCqdXLyrzxqWNB5H7232SThJCX29GXtEBhIn+S+UdmlMyKxgcACJa DDOUEsh67dGiA9XNX7QQTtbcprklC320xRFLWu6s2ZYm1U4vnNi4SFo0+knHuwYB1kgM n5pF0iSApRpMFm0qFaK0kFN960MQh/OS+B+S1lVOPbM/cNGbdKduu/rJG117pivtcNAX zMTk3cq3Oy2tTt5Fnd+Is3FhKmp6KblKdzsO5JF+uPFVkc5jnU3hzE6I2DXxeccPXMnu w784cQ/Qw8aYJHWIUOfqaJhbnHW7xnQ7VJIfW0y0/az1AHsFN8nY0pRfytDWTA99bAY8 QWOQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=4NVlnvH2L/cYRkCm5hQ2+fmz61uNYxGY9AD8xRJmRwA=; b=MLc1OqbsT0gqR2oc3FrL7m2RgNm2scveruW1ZIEjPB9zRNspNCiGvmql+uqeqC6uvG i349QxP65VUTFZXhO7C4WIw99E6y2faaPRqkilkAk3aw+il6IpeSDYjWef9XakUBH4JS H2N+h6F8tn8r5f04hUCEDxKjq62NS8xQwnhI5BqBwXZ9LnXqjGE4GSkEvDgMjt1Hew/a UnKMjRc/59k9AXj/eMEUrL15kDMVz6RO2IdPIxvXIvsuf9sAXT5TEI1aHl4wMRCOxENk hi+ar2fC0XF3b9A8ej9BZlx5CGn47iwkyWks/8ZjXIeFMetRzcKvbf2mtKor8jJwfXhS 4T7Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=cMukcwnT; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id bz15si2907851ejc.559.2020.05.27.22.42.42; Wed, 27 May 2020 22:43:04 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=cMukcwnT; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727916AbgE1Fk7 (ORCPT + 99 others); Thu, 28 May 2020 01:40:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44678 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727897AbgE1Fk5 (ORCPT ); Thu, 28 May 2020 01:40:57 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BA771C05BD1E; Wed, 27 May 2020 22:40:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender :Reply-To:Content-Type:Content-ID:Content-Description; bh=4NVlnvH2L/cYRkCm5hQ2+fmz61uNYxGY9AD8xRJmRwA=; b=cMukcwnTJJsoPTbpZu69MUgPA9 mEzSBxgPmva8SNLYcW9HoysLjqA7xebO+hTM+RinEFuPKfU0XMu/1+/v27sxyAZU69y3U4LpQmJl3 vDgEobIMWfrosZbXls3iOODZ9g5+7UUX8EYUk9LMH9kMGRX0U0gt4d6iIiQJZTsYMGWwyC8WlW/Hi pfK1QZoQ409C9knIfsil37oPoVFDM+aIwtfg0Q8k7rsY5kqIOpWYDxCPQBekUt7SQ2s8QuBOfgWSV bYlZXFeJ47HR7e7ha2FKUAPWLSF6yR+CvQCeTYPL2lm6i8iCW5JqtWPZrqfMqeLqkuoorp02juEC/ TQQXYKrQ==; Received: from p4fdb1ad2.dip0.t-ipconnect.de ([79.219.26.210] helo=localhost) by bombadil.infradead.org with esmtpsa (Exim 4.92.3 #3 (Red Hat Linux)) id 1jeBHh-0002KI-Og; Thu, 28 May 2020 05:40:54 +0000 From: Christoph Hellwig To: Al Viro Cc: Linus Torvalds , Ian Kent , David Howells , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-security-module@vger.kernel.org, netfilter-devel@vger.kernel.org Subject: [PATCH 03/14] bpfilter: switch to kernel_write Date: Thu, 28 May 2020 07:40:32 +0200 Message-Id: <20200528054043.621510-4-hch@lst.de> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200528054043.621510-1-hch@lst.de> References: <20200528054043.621510-1-hch@lst.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org While pipes don't really need sb_writers projection, __kernel_write is an interface better kept private, and the additional rw_verify_area does not hurt here. Signed-off-by: Christoph Hellwig --- net/bpfilter/bpfilter_kern.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/bpfilter/bpfilter_kern.c b/net/bpfilter/bpfilter_kern.c index c0f0990f30b60..1905e01c3aa9a 100644 --- a/net/bpfilter/bpfilter_kern.c +++ b/net/bpfilter/bpfilter_kern.c @@ -50,7 +50,7 @@ static int __bpfilter_process_sockopt(struct sock *sk, int optname, req.len = optlen; if (!bpfilter_ops.info.pid) goto out; - n = __kernel_write(bpfilter_ops.info.pipe_to_umh, &req, sizeof(req), + n = kernel_write(bpfilter_ops.info.pipe_to_umh, &req, sizeof(req), &pos); if (n != sizeof(req)) { pr_err("write fail %zd\n", n); -- 2.26.2